Differential D361

INP-1764 - Set correct exit code, when exception happens in CLI
ClosedPublic
Actions

Authored by alex on Apr 26 2019, 3:03 AM.

Tags

Subscribers

None

Details

Reviewers

Commits

rINP16660: Fixes INP-1764 - Set correct exit code, when exception happens in CLI

Test Plan

open SSH connection to Web Server with In-Portal on it
change current directory to In-Portal directory
run php index.php ; echo $? command
confirm, that after all output 0 is displayed (means no errors)
in the /index.php file after $application->Init(); line add throw new RuntimeException('Test');
run php index.php ; echo $? command
confirm, that after all output 1 is displayed (means has errors)

Diff Detail

Repository

Branch

/in-portal/branches/5.2.x

Lint

Lint Errors

Excuse: Not sure how to fix.

Severity	Location	Code	Message
Error	core/kernel/utility/logger.php:1280	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded

Unit

No Unit Test Coverage

Build Status

Buildable 924
Build 924: arc lint + arc unit

Event Timeline

alex created this revision.Apr 26 2019, 3:03 AM

Herald added a reviewer: erik. · View Herald TranscriptApr 26 2019, 3:03 AM

alex requested review of this revision.Apr 26 2019, 3:03 AM

Harbormaster completed remote builds in B924: Diff 901.Apr 26 2019, 3:03 AM

alex added a project: Restricted Project.Apr 26 2019, 3:04 AM

Tested, in both cases got wrong code 255 (not 0 and not 1 )

This revision now requires changes to proceed.Apr 26 2019, 7:17 AM

Tested - got 0 and 1 codes, as planned.

This revision is now accepted and ready to land.Apr 14 2020, 5:45 AM

erik added a comment.Apr 14 2020, 2:03 PM

This comment was removed by erik.

This revision was landed with ongoing or failed builds.Jan 5 2021, 2:52 AM

Closed by commit rINP16660: Fixes INP-1764 - Set correct exit code, when exception happens in CLI (authored by alex, committed by ). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 901

core/kernel/utility/logger.php

Loading...