MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields
ClosedPublic
Actions

Authored by alex on Feb 23 2021, 3:19 AM.

Details

Reviewers

erik

Commits

Test Plan

login to Admin Console (the free In-Commerce module must be installed)
go to Configuration → E-commerce → Payment Types section
ensure, that Credit Card (manual) payment type is enabled
go to E-commerce → Orders section
create new sales order with Credit Card payment type
confirm, that:
- no notices were stored in System Log while moving between sale order tabs
- the credit card expiration was stored to the database

Repository

rMINC Modules.In-Commerce

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

alex requested review of this revision.Feb 23 2021, 3:19 AM

alex added a project: Restricted Project.Feb 23 2021, 3:19 AM

Previous fix changed logic of the code to allow empty field values, but that wasn't on purpose.

This revision is now accepted and ready to land.Feb 23 2021, 4:56 AM

This revision was landed with ongoing or failed builds.Jul 8 2022, 3:20 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			branches/5.2.x/units/orders/orders_item.php (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	982	16637		Feb 23 2021, 3:18 AM	★	★
Diff 2	983	16637	Previous fix changed logic of the code to allow empty field values, but that…	Feb 23 2021, 3:28 AM	★	★
Diff 3	1045	16696	rMINC16697	Jul 8 2022, 3:20 AM	★	★