Differential D395

MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields
ClosedPublic
Actions

Authored by alex on Feb 23 2021, 3:19 AM.

Details

Reviewers

erik

Commits

rMINC16697: Fixes MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear"…

Test Plan

login to Admin Console (the free In-Commerce module must be installed)
go to Configuration → E-commerce → Payment Types section
ensure, that Credit Card (manual) payment type is enabled
go to E-commerce → Orders section
create new sales order with Credit Card payment type
confirm, that:
- no notices were stored in System Log while moving between sale order tabs
- the credit card expiration was stored to the database

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint Errors

Excuse: Not fixing non-changed code.

Severity	Location	Code	Message
Error	modules/in-commerce/units/orders/orders_item.php:35	PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExact	Generic.WhiteSpace.ScopeIndent.IncorrectExact

Unit

No Unit Test Coverage

Build Status

Buildable 1005
Build 1005: arc lint + arc unit

Event Timeline

alex created this revision.Feb 23 2021, 3:19 AM

Herald added a reviewer: erik. · View Herald TranscriptFeb 23 2021, 3:19 AM

alex requested review of this revision.Feb 23 2021, 3:19 AM

Harbormaster completed remote builds in B1005: Diff 982.Feb 23 2021, 3:19 AM

alex added a project: Restricted Project.Feb 23 2021, 3:19 AM

Previous fix changed logic of the code to allow empty field values, but that wasn't on purpose.

Harbormaster completed remote builds in B1006: Diff 983.Feb 23 2021, 3:28 AM

erik accepted this revision.Feb 23 2021, 4:56 AM

This revision is now accepted and ready to land.Feb 23 2021, 4:56 AM

This revision was landed with ongoing or failed builds.Jul 8 2022, 3:20 AM

Closed by commit rMINC16697: Fixes MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear"… (authored by alex, committed by ). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			modules/in-commerce/units/orders/orders_item.php (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	982	16637		Feb 23 2021, 3:18 AM	★	★
Diff 2	983	16637	Previous fix changed logic of the code to allow empty field values, but that…	Feb 23 2021, 3:28 AM	★	★
Diff 3	1045	16696	rMINC16697	Jul 8 2022, 3:20 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 982

View Options

modules/in-commerce/units/orders/orders_item.php

MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fieldsClosedPublicActions