Page MenuHomeIn-Portal Phabricator

MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields

Authored by alex on Feb 23 2021, 3:19 AM.


Test Plan
  1. login to Admin Console (the free In-Commerce module must be installed)
  2. go to ConfigurationE-commercePayment Types section
  3. ensure, that Credit Card (manual) payment type is enabled
  4. go to E-commerceOrders section
  5. create new sales order with Credit Card payment type
  6. confirm, that:
    • no notices were stored in System Log while moving between sale order tabs
    • the credit card expiration was stored to the database

Diff Detail

rINP In-Portal
Lint ErrorsExcuse: Not fixing non-changed code.
No Unit Test Coverage
Build Status
Buildable 1006
Build 1006: arc lint + arc unit

Event Timeline

alex created this revision.Feb 23 2021, 3:19 AM
alex requested review of this revision.Feb 23 2021, 3:19 AM
alex added a project: Restricted Project.Feb 23 2021, 3:19 AM
alex updated this revision to Diff 983.Feb 23 2021, 3:28 AM

Previous fix changed logic of the code to allow empty field values, but that wasn't on purpose.

erik accepted this revision.Feb 23 2021, 4:56 AM
This revision is now accepted and ready to land.Feb 23 2021, 4:56 AM
This revision was landed with ongoing or failed builds.Jul 8 2022, 3:20 AM
This revision was automatically updated to reflect the committed changes.