Differential D435

INP-1831 - Allow specifying "HookToModule" in hook declarations
ClosedPublic
Actions

Authored by alex on Oct 7 2022, 5:39 AM.

Tags

Subscribers

None

Details

Reviewers

Commits

rINP16764: Fixes INP-1831 - Allow specifying "HookToModule" in hook declarations
rMINC16765: Bug INP-1831 - Allow specifying "HookToModule" in hook declarations

Test Plan

login to the Admin Console
go to the Configuration → Website → Modules section
disable all modules, except In-Portal and In-Commerce
go to the Tools → System Tools button
press the Deploy button
go to the Logs & Reports → System Log section
confirm, that such warnings weren't added during unit config cache rebuild (happens during deployment):

* Prefix lst doesn't exist when trying to hook from p:OnSaveVirtualProduct in ...\core\kernel\managers\hook_manager.php on line 97`
* Prefix lst doesn't exist when trying to hook from p:OnDeleteListingType in ...\core\kernel\managers\hook_manager.php on line 97
* Prefix lst doesn't exist when trying to hook from p:OnModifyPaidListingConfig in ...\core\kernel\managers\hook_manager.php on line 97

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Oct 7 2022, 5:39 AM

Herald added a reviewer: erik. · View Herald TranscriptOct 7 2022, 5:39 AM

alex requested review of this revision.Oct 7 2022, 5:39 AM

Harbormaster completed remote builds in B1140: Diff 1102.Oct 7 2022, 5:39 AM

alex edited the test plan for this revision. (Show Details)Oct 7 2022, 5:42 AM

alex added a project: Restricted Project.Oct 7 2022, 6:00 AM

alex added a child revision: D436: INP-1832 - Use "p-rel" unit for relation management in the In-Commerce module.

erik accepted this revision.Oct 10 2022, 5:30 AM

This revision is now accepted and ready to land.Oct 10 2022, 5:30 AM

This revision was landed with ongoing or failed builds.Nov 16 2023, 2:33 AM

Closed by commit rINP16764: Fixes INP-1831 - Allow specifying "HookToModule" in hook declarations (authored by alex, committed by ). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 1166

branches/5.2.x/core/kernel/utility/unit_config_reader.php

Loading...