INP-1831 - Allow specifying "HookToModule" in hook declarations
ClosedPublic
Actions

Authored by alex on Oct 7 2022, 5:39 AM.

Details

Reviewers

Commits

rINP16764: Fixes INP-1831 - Allow specifying "HookToModule" in hook declarations
rMINC16765: Bug INP-1831 - Allow specifying "HookToModule" in hook declarations

Test Plan

login to the Admin Console
go to the Configuration → Website → Modules section
disable all modules, except In-Portal and In-Commerce
go to the Tools → System Tools button
press the Deploy button
go to the Logs & Reports → System Log section
confirm, that such warnings weren't added during unit config cache rebuild (happens during deployment):

* Prefix lst doesn't exist when trying to hook from p:OnSaveVirtualProduct in ...\core\kernel\managers\hook_manager.php on line 97`
* Prefix lst doesn't exist when trying to hook from p:OnDeleteListingType in ...\core\kernel\managers\hook_manager.php on line 97
* Prefix lst doesn't exist when trying to hook from p:OnModifyPaidListingConfig in ...\core\kernel\managers\hook_manager.php on line 97

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint Errors

Excuse: Better to keep CS uniformed (even if broken)

Severity	Location	Code	Message
Error	core/kernel/utility/unit_config_reader.php:481	PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace	CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace
Error	core/kernel/utility/unit_config_reader.php:481	PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace	CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace
Error	modules/in-commerce/units/products/products_config.php:50	PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeyword	CodingStandard.Arrays.Array.SpaceAfterKeyword
Error	modules/in-commerce/units/products/products_config.php:50	PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterOpen	CodingStandard.Arrays.Array.SpaceAfterOpen
Error	modules/in-commerce/units/products/products_config.php:50	PHPCS.E.CodingStandard.Arrays.Array.SpaceBeforeClose	CodingStandard.Arrays.Array.SpaceBeforeClose
Error	modules/in-commerce/units/products/products_config.php:50	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found
Error	modules/in-commerce/units/products/products_config.php:62	PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeyword	CodingStandard.Arrays.Array.SpaceAfterKeyword
Error	modules/in-commerce/units/products/products_config.php:62	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found
Error	modules/in-commerce/units/products/products_config.php:74	PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeyword	CodingStandard.Arrays.Array.SpaceAfterKeyword
Error	modules/in-commerce/units/products/products_config.php:74	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found

Unit

No Unit Test Coverage

Build Status

Buildable 1140
Build 1140: arc lint + arc unit

Event Timeline

alex created this revision.Oct 7 2022, 5:39 AM

Herald added a reviewer: erik. · View Herald TranscriptOct 7 2022, 5:39 AM

alex requested review of this revision.Oct 7 2022, 5:39 AM

Harbormaster completed remote builds in B1140: Diff 1102.Oct 7 2022, 5:39 AM

alex edited the test plan for this revision. (Show Details)Oct 7 2022, 5:42 AM

alex added a project: Restricted Project.Oct 7 2022, 6:00 AM

alex added a child revision: D436: INP-1832 - Use "p-rel" unit for relation management in the In-Commerce module.

erik accepted this revision.Oct 10 2022, 5:30 AM

This revision is now accepted and ready to land.Oct 10 2022, 5:30 AM

This revision was landed with ongoing or failed builds.Nov 16 2023, 2:33 AM

Closed by commit rINP16764: Fixes INP-1831 - Allow specifying "HookToModule" in hook declarations (authored by alex, committed by ). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1102	16733		Oct 7 2022, 5:39 AM	★	★
Diff 2	1166	16763	rINP16764	Nov 16 2023, 2:33 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

	Status	Author	Revision
	Closed	alex	D436 INP-1832 - Use "p-rel" unit for relation management in the In-Commerce module
	Closed	alex	D435 INP-1831 - Allow specifying "HookToModule" in hook declarations

Diff 1102

View Options

core/kernel/utility/unit_config_reader.php