Page MenuHomeIn-Portal Phabricator
Differential D436

INP-1832 - Use "p-rel" unit for relation management in the In-Commerce module
ClosedPublic
Actions

Authored by alex on Oct 7 2022, 5:59 AM.

Details

Reviewers
erik
Commits
rINP16766: Fixes INP-1832 - Use "p-rel" unit for relation management in the In-Commerce…
rMINC16767: Bug INP-1832 - Use "p-rel" unit for relation management in the In-Commerce…
Test Plan
  1. login to the Admin Console
  2. go to the Configuration → Website → Modules section
  3. disable all modules, except In-Portal
  4. go to the Tools → System Tools button
  5. press the Deploy button
  6. go to the Logs & Reports → System Log section
  7. confirm, that such warnings weren't added during unit config cache rebuild (happens during deployment):
* Prefix p doesn't exist when trying to hook from rel:OnDeleteForeignRelations in ...\core\kernel\managers\hook_manager.php on line 97

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Better to stick to current CS
SeverityLocationCodeMessage
Errorcore/units/relationship/relationship_config.php:52PHPCS.E.CodingStandard.Commenting.InlineComment.SpacingBeforeCodingStandard.Commenting.InlineComment.SpacingBefore
Errormodules/in-commerce/units/products/products_config.php:127PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/products/products_config.php:127PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-commerce/units/products/products_config.php:133PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/products/products_config.php:133PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-commerce/units/products/products_config.php:225PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/products/products_config.php:225PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-commerce/units/products/products_config.php:226PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/products/products_config.php:226PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-commerce/units/products/products_config.php:227PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/products/products_config.php:227PHPCS.E.CodingStandard.Formatting.ItemAssignment.NoSpacingAfterCodingStandard.Formatting.ItemAssignment.NoSpacingAfter
Errormodules/in-commerce/units/products/products_config.php:227PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-commerce/units/products/products_config.php:227PHPCS.E.Squiz.WhiteSpace.OperatorSpacing.NoSpaceAfterSquiz.WhiteSpace.OperatorSpacing.NoSpaceAfter
Errormodules/in-commerce/units/products/products_config.php:228PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/products/products_config.php:228PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-commerce/units/products/products_config.php:462PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/products/products_config.php:462PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Unit
No Unit Test Coverage
Build Status
Buildable 1141
Build 1141: arc lint + arc unit

Event Timeline

alex created this revision.Oct 7 2022, 5:59 AM
alex requested review of this revision.Oct 7 2022, 6:00 AM
alex added a project: Restricted Project.Oct 7 2022, 6:00 AM
alex added a parent revision: D435: INP-1831 - Allow specifying "HookToModule" in hook declarations.
alex edited the test plan for this revision. (Show Details)
erik accepted this revision.Oct 10 2022, 5:36 AM
This revision is now accepted and ready to land.Oct 10 2022, 5:36 AM
This revision was landed with ongoing or failed builds.Nov 16 2023, 2:42 AM
Closed by commit rINP16766: Fixes INP-1832 - Use "p-rel" unit for relation management in the In-Commerce… (authored by alex, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1110316733Oct 7 2022, 5:59 AM
★
★
Diff 2116716764rINP16766Nov 16 2023, 2:42 AM
★
★

Diff 1103

View Options

core/units/relationship/relationship_config.php

Loading...
View Options

modules/in-commerce/admin_templates/products/products_relations.tpl

Loading...
View Options

modules/in-commerce/admin_templates/products/relations_edit.tpl

Loading...
View Options

modules/in-commerce/units/products/products_config.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server