INP-1521 - Don't expose InitList and PrintList tag communication to Web Request
ClosedPublic
Actions

Authored by alex on Dec 5 2015, 8:32 AM.

Details

Reviewers

Commits

rMINC16315: Bug INP-1521 - Don't expose InitList and PrintList tag communication to Web…
rINP16314: Fixes INP-1521 - Don't expose InitList and PrintList tag communication to Web…

Test Plan

go to Admin Console
go to Website & Content → Structure & Data section
create Sub Directory category in Directory category
go to Directory → Sub Directory category
create 2 links, that has New = Always, Hot = Never, Pop = Never, Status = Active
create 2 links, that has New = Never, Hot = Always, Pop = Never, Status = Active
create 2 links, that has New = Never, Hot = Never, Pop = Always, Status = Active
go to Front-End
go to Directory → Sub Directory category using top menu
confirm, that in sidebar following sideboxes are present:
- New Links and it's showing only new links
- Hot Links and it's showing only hot links
- Popular Links and it's showing only pop links
confirm, that on the right all created links are shown

Diff Detail

Repository

rINP In-Portal

Branch

branches/5.2.x

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 267
Build 267: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 423.Dec 5 2015, 8:32 AM

alex retitled this revision from to INP-1521 - Don't expose InitList and PrintList tag communication to Web Request.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1521.

Herald added a reviewer: glebs. · View Herald TranscriptDec 5 2015, 8:32 AM

alex added a child revision: D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.Dec 6 2015, 8:36 AM

glebs accepted this revision.Dec 9 2015, 2:16 AM

glebs edited edge metadata.

This revision is now accepted and ready to land.Dec 9 2015, 2:16 AM

Closed by commit rINP16314: Fixes INP-1521 - Don't expose InitList and PrintList tag communication to Web… (authored by alex). · Explain WhyJan 17 2016, 6:18 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	423	16303		Dec 5 2015, 8:32 AM	★	★
Diff 2	450	16313	Commit rINP16314	Jan 17 2016, 6:18 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Status	Author	Revision
Closed	alex	D17 INP-1388 - Make CKEditor stylesheet within theme editable
Closed	alex	D68 INP-1422 - Store class map on disk
Closed	alex	D62 INP-1424 Don't call "refreshModuleInfo" twice in a row
Closed	alex	D64 INP-1426 Speed up admin tree cache building
Changes Planned	alex	D180 INP-1516 - Do not use "Web Request" and "Session" concepts in CLI
Closed	alex	D50 INP-1413 - Don't do full Application Init during deployment
Closed	alex	D174 INP-1520 - Honor manually set owner of categories/category items created from CLI
Closed	alex	D175 INP-1521 - Don't expose InitList and PrintList tag communication to Web Request
Closed	alex	D179 INP-1523 - Populate user info, when sending membership expiration e-mails
Closed	alex	D176 MINL-18 - Change link categories automatically according to it's Listing Type
Closed	alex	D173 MINN-11 - Specify category for RSS feed articles via "CategoryId" field
Closed	alex	D169 INP-1517 - Define INDEX_FILE constant in each CLI script
Closed	alex	D170 INP-1518 - Remove excessive owner detection code from "cacheItemOwner" method
Closed	alex	D172 MINN-10 - Don't use Web Request during Article adding/editing
Closed	alex	D207 INP-1543 - Return detected theme/language ID immediately from "getPassedID" method
Closed	alex	D16 INP-1387 - Move primary theme/language detection into corresponding units
Closed	alex	D208 INP-1544 - Delete expired session without using "Session" object
Closed	alex	D212 MINB-26 - Don't persist data for anonymous users
Closed	alex	D282 INP-1665 - Add/use "kApplication::permissionCheckingDisabled" method

Diff 423

View Options

core/kernel/db/db_tag_processor.php

View Options

core/units/visits/visits_tag_processor.php

View Options

modules/in-commerce/units/products/products_tag_processor.php

			Path	Packages
M			core/kernel/db/db_tag_processor.php (25 lines)
M			core/units/visits/visits_tag_processor.php (7 lines)
M			modules/in-commerce/units/products/products_tag_processor.php (9 lines)

INP-1521 - Don't expose InitList and PrintList tag communication to Web RequestClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 423

core/kernel/db/db_tag_processor.php

core/units/visits/visits_tag_processor.php

modules/in-commerce/units/products/products_tag_processor.php

INP-1521 - Don't expose InitList and PrintList tag communication to Web Request
ClosedPublic
Actions

Revision Contents
Changeset List