After applying the patch make sure, that svn:ignore SVN property on /install/cache in all modules (including core) matches value from the .gitignore file in that folder.
Details
Details
- Reviewers
glebs - Commits
- rMCUS16157: Bug INP-1422 - Store class map on disk
rINP16156: Fixes INP-1422 - Store class map on disk
rMINL16161: Bug INP-1422 - Store class map on disk
rMINB16159: Bug INP-1422 - Store class map on disk
Restricted Diffusion Commit
rMINN16162: Bug INP-1422 - Store class map on disk
rMINC16160: Bug INP-1422 - Store class map on disk
NOTE: Blocking Differential Revisions must be also applied.
- perform installation of In-Portal (without modules and with some/all modules)
- confirm, that it's possible
- open In-Portal and do some common stuff, like browsing Front-End/Admin Console
- confirm, that no error happens
- create any class, e.g. new helper and don't register it in any unit config
- run php tools/build_class_map.php script
- confirm, that new class mention was added to a /install/cache/class_map.php file of module, where you've added the class
- try using the helper like $this->Application->recallObject('HelperClassName');
- confirm, that proper class instance was created
- register helper class under different (than class name) pseudo without specifying file key during registration
- try using the helper like $this->Application->recallObject('HelperPseudoName');
- confirm, that proper class instance was created
- create another helper class, but this time don't run class map update script
- try using the helper like $this->Application->recallObject('AnotherHelperClassName');
- confirm, that exception is thrown with suggestion to use class map rebuild script
- repeat last 3 steps but use makeClass method instead (before direct makeClass call on wrong class would end up in weird error)
- confirm, that classes, interfaces and traits are all discovered and placed into classmap
Diff Detail
Diff Detail
- Repository
- rINP In-Portal
- Branch
- /in-portal/branches/5.3.x
- Lint
Lint Errors Excuse: Errors are on lines, surrounding the changes and will be dealt in separate commits. - Unit
No Unit Test Coverage
Event Timeline
Comment Actions
- moving error reporting about non-existing class from recallObject to makeClass
- mention class map rebuild script in error message about missing class
composer.json | ||
---|---|---|
7 | In fact it maybe better to:
|
Comment Actions
Make PHP parser required only during development. In case missing PHP parser throw an exception immediately.