Unexpected output: Affected paths: relative - resubmit patch.
⚙ D175 INP-1521 - Don't expose InitList and PrintList tag communication to Web Request
Page MenuHomeIn-Portal Phabricator
Differential D175

INP-1521 - Don't expose InitList and PrintList tag communication to Web Request
ClosedPublic
Actions

Authored by alex on Dec 5 2015, 8:32 AM.

Details

Reviewers
glebs
Commits
rMINC16315: Bug INP-1521 - Don't expose InitList and PrintList tag communication to Web…
rINP16314: Fixes INP-1521 - Don't expose InitList and PrintList tag communication to Web…
Test Plan
  1. go to Admin Console
  2. go to Website & Content → Structure & Data section
  3. create Sub Directory category in Directory category
  4. go to Directory → Sub Directory category
  5. create 2 links, that has New = Always, Hot = Never, Pop = Never, Status = Active
  6. create 2 links, that has New = Never, Hot = Always, Pop = Never, Status = Active
  7. create 2 links, that has New = Never, Hot = Never, Pop = Always, Status = Active
  8. go to Front-End
  9. go to Directory → Sub Directory category using top menu
  10. confirm, that in sidebar following sideboxes are present:
    • New Links and it's showing only new links
    • Hot Links and it's showing only hot links
    • Popular Links and it's showing only pop links
  11. confirm, that on the right all created links are shown

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 267
Build 267: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 423.Dec 5 2015, 8:32 AM
alex retitled this revision from to INP-1521 - Don't expose InitList and PrintList tag communication to Web Request.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1521.
glebs accepted this revision.Dec 9 2015, 2:16 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Dec 9 2015, 2:16 AM
Closed by commit rINP16314: Fixes INP-1521 - Don't expose InitList and PrintList tag communication to Web… (authored by alex). · Explain WhyJan 17 2016, 6:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 142316303Dec 5 2015, 8:32 AM
★
★
Diff 245016313Commit rINP16314Jan 17 2016, 6:18 AM
★
★

Diff 423

View Options

core/kernel/db/db_tag_processor.php

Loading...
View Options

core/units/visits/visits_tag_processor.php

Loading...
View Options

modules/in-commerce/units/products/products_tag_processor.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server