Unexpected output: Affected paths: relative - resubmit patch.
⚙ D353 INP-1755 Make images in Admin Console Retina-friendly
Page MenuHomeIn-Portal Phabricator

INP-1755 Make images in Admin Console Retina-friendly
Needs ReviewPublic

Authored by glebs on Nov 8 2018, 4:34 AM.

Details

Reviewers
alex
Test Plan
  1. Login to admin console
  2. Confirm you see new flat icons everywhere

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: not related to task
SeverityLocationCodeMessage
Errorcore/units/admin/admin_events_handler.php:338PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errorcore/units/admin/admin_events_handler.php:338PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/admin/admin_events_handler.php:339PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errorcore/units/admin/admin_events_handler.php:339PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/admin/admin_events_handler.php:340PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errorcore/units/admin/admin_events_handler.php:340PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/ban_rules/ban_rules_config.php:132PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errorcore/units/ban_rules/ban_rules_config.php:132PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/categories/categories_config.php:468PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errorcore/units/categories/categories_config.php:468PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/categories/categories_config.php:470PHPCS.E.CodingStandard.Commenting.InlineComment.NotCapitalCodingStandard.Commenting.InlineComment.NotCapital
Errorcore/units/categories/categories_config.php:478PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndCharCodingStandard.Commenting.InlineComment.InvalidEndChar
Errorcore/units/categories/categories_config.php:497PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errorcore/units/categories/categories_config.php:497PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/categories/categories_config.php:499PHPCS.E.CodingStandard.Commenting.InlineComment.NotCapitalCodingStandard.Commenting.InlineComment.NotCapital
Errorcore/units/categories/categories_config.php:507PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndCharCodingStandard.Commenting.InlineComment.InvalidEndChar
Errorcore/units/categories/categories_config.php:525PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errorcore/units/categories/categories_config.php:525PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/categories/categories_config.php:527PHPCS.E.CodingStandard.Commenting.InlineComment.NotCapitalCodingStandard.Commenting.InlineComment.NotCapital
Errorcore/units/categories/categories_config.php:535PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndCharCodingStandard.Commenting.InlineComment.InvalidEndChar
Errorcore/units/categories/categories_tag_processor.php:97PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace
Errorcore/units/categories/categories_tag_processor.php:97PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace
Errorcore/units/categories/categories_tag_processor.php:99PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.NoLineAfterCloseCodingStandard.WhiteSpace.ControlStructureSpacing.NoLineAfterClose
Errorcore/units/categories/categories_tag_processor.php:100PHPCS.E.CodingStandard.Formatting.BlankLineBeforeReturn.BlankLineBeforeReturnCodingStandard.Formatting.BlankLineBeforeReturn.BlankLineBeforeReturn
Errorcore/units/categories/categories_tag_processor.php:105PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace
Unit
No Unit Test Coverage
Build Status
Buildable 900
Build 900: arc lint + arc unit

Event Timeline

glebs created this revision.Nov 8 2018, 4:34 AM
glebs updated this revision to Diff 880.Nov 8 2018, 9:44 AM

Changes for all modules

alex requested changes to this revision.Nov 9 2018, 4:16 AM
alex added inline comments.
core/admin_templates/incs/grid_blocks.tpl
535

Please undo this change, because by mistake it ended up in icon-change commit, but should be in D340.

This revision now requires changes to proceed.Nov 9 2018, 4:16 AM
glebs updated this revision to Diff 882.Nov 9 2018, 6:05 AM
glebs edited edge metadata.

Remove unneded changes from grid_blocks.tpl