Page MenuHomeIn-Portal Phabricator
Feed Advanced Search

Mar 20 2023

erik updated the diff for D351: INP-1750 - Support PHP Memcached extension for caching.

Done requested changes - returned fallback to FakeCacheHandler zero time parameterusage and comments.

Mar 20 2023, 6:28 AM · Restricted Project
erik added a comment to D443: INP-1838 - Set expiration limit for life-time cached keys.

Testing internal caches expiration for Memcache
ITEM site_serial:1766886194:1:master:last_cache_rebuild [68 b; 0 s]
Failed condition "these keys have infinite expiration (the 1738250904 number might differ on your install)" - given "0 s" is not like some great integer like "1738250904"

Mar 20 2023, 6:10 AM · Restricted Project

Mar 17 2023

erik added a comment to D443: INP-1838 - Set expiration limit for life-time cached keys.

Detected that after memcache restart, test setCache with $application->setCache('key_with_def_exp', 'v1');, is passed only when twice open index.php. First index.php opening does not set value.

Mar 17 2023, 1:55 PM · Restricted Project

Feb 23 2023

erik updated the diff for D351: INP-1750 - Support PHP Memcached extension for caching.

Renoved fallback logic, updated test plan.

Feb 23 2023, 4:45 AM · Restricted Project

Feb 22 2023

erik updated the test plan for D351: INP-1750 - Support PHP Memcached extension for caching.
Feb 22 2023, 5:02 AM · Restricted Project

Feb 7 2023

erik accepted D440: INP-1569 - Create System Log record, when stale semaphore is discovered or hit.
Feb 7 2023, 5:03 AM

Feb 3 2023

erik requested changes to D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.

Tried test part 4. No messages in system log given. Maybe, because of START TRANSACTION SQL command. Transaction not committed, so no records created in DB.

Feb 3 2023, 1:46 AM · Restricted Project

Dec 5 2022

erik added a comment to D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.

On processing line with "Step 4." comment, i have lock much more then 50 seconds. Practically, it never ends. In case, when lock continue, in other debug window go to step 5 - lock ends, but no system log record about this lock created.

Dec 5 2022, 5:10 AM · Restricted Project

Dec 2 2022

erik added a comment to D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.

@alex trouble in part3 1 G - cant't get "detailed lock retry info is shown in the system log".

Dec 2 2022, 12:42 PM · Restricted Project

Nov 8 2022

erik accepted D438: INP-1834 - Connect "mtdowling/cron-expression" library.
Nov 8 2022, 12:51 PM · Restricted Project
erik requested changes to D438: INP-1834 - Connect "mtdowling/cron-expression" library.

Found difference from test plan expectation:
test Hour field validation: has error on 30-35 value

Nov 8 2022, 11:30 AM · Restricted Project

Oct 25 2022

erik accepted D437: INP-1833 - Add database server index to the error messages.
Oct 25 2022, 6:39 AM · Restricted Project

Oct 10 2022

erik accepted D436: INP-1832 - Use "p-rel" unit for relation management in the In-Commerce module.
Oct 10 2022, 5:36 AM · Restricted Project
erik accepted D435: INP-1831 - Allow specifying "HookToModule" in hook declarations.
Oct 10 2022, 5:30 AM · Restricted Project

Oct 7 2022

erik accepted D434: INP-1830 - Clear incompletely configured e-mail on error.
Oct 7 2022, 2:16 AM · Restricted Project

Oct 6 2022

erik accepted D433: INP-1829 - Add "keep_cents" field option for "kFormatter::Format" method.
Oct 6 2022, 5:06 AM · Restricted Project

Sep 19 2022

erik accepted D432: INP-1828 - Preserve engine type, when creating a temporary tables.
Sep 19 2022, 7:02 AM

Sep 15 2022

erik accepted D431: INP-1826 - Convert search/custom having filters into a where filters in grids.
Sep 15 2022, 5:18 AM

Sep 14 2022

erik requested changes to D431: INP-1826 - Convert search/custom having filters into a where filters in grids.

There is not simple filter by g.Name, but complex filter "((1) AND ( (g.Name) LIKE '%mem%'))", where part "(1) AND" is excessive. Maybe, this "(1) AND" should be removed from SQL request.

Sep 14 2022, 5:26 AM

Sep 9 2022

erik accepted D429: INP-1825 - Show In-Portal-specific superglobals in Debugger.
Sep 9 2022, 9:34 AM

Aug 24 2022

erik accepted D426: INP-1756 - Create "Security*" classes for security-related jobs.
Aug 24 2022, 6:50 AM
erik accepted D427: INP-1422 - Store class map on disk.
Aug 24 2022, 6:37 AM

Aug 17 2022

erik accepted D413: INP-1809 - Introduce active editing window tracking system.
Aug 17 2022, 7:17 AM · Restricted Project

Aug 10 2022

erik accepted D425: INP-1821 - Don't check event-based permissions from template for "root" user.
Aug 10 2022, 5:21 AM

Aug 9 2022

erik accepted D422: INP-1818 - Reset cURL settings only upon connection closing.
Aug 9 2022, 5:53 AM
erik accepted D423: INP-1819 - Allow retrieving response headers after making the cURL request.
Aug 9 2022, 5:53 AM

Aug 8 2022

erik accepted D424: INP-1820 - Optionally store added record data in the Changes Log.

Tested with clean install only.

Aug 8 2022, 9:36 AM · Restricted Project

Jul 27 2022

erik requested changes to D229: INP-1565 Add support for "relative" date format.

Math is incorrect.

Jul 27 2022, 1:43 PM

Jul 20 2022

erik accepted D421: MINN-27 - Add missing export-related virtual fields.
Jul 20 2022, 5:22 AM
erik accepted D401: INP-1790 - Remove trailing space from "FieldsSeparatedBy" field of catalog item units.
Jul 20 2022, 5:10 AM · Restricted Project

Jul 19 2022

erik updated the diff for D243: INP-1571 Form field validation should account for array-like field values.

Added code to avoid "Array to string conversion" notice. Added related test plan part.

Jul 19 2022, 9:53 AM
erik updated the test plan for D243: INP-1571 Form field validation should account for array-like field values.
Jul 19 2022, 9:46 AM
erik accepted D388: INP-1791 - Add "picker" control type for configuration settings.
Jul 19 2022, 7:58 AM · Restricted Project
erik accepted D416: INP-1812 - Change "LeftJoinOptimizer" to find table aliases usage only at word boundaries.
Jul 19 2022, 7:56 AM

Jul 15 2022

erik requested changes to D388: INP-1791 - Add "picker" control type for configuration settings.
  1. In the test plan part 4 need "Picker" value, not "Checkboxes"
  2. However, if "Checkboxes" selected, looks incorrect - shown only one checkbox, not multiple checkboxes with one-two-three labels.
  3. Items alphabetical sorting is not applied on page load, so after save/on page reload options order may change.
Jul 15 2022, 12:48 PM · Restricted Project

Jul 14 2022

erik requested changes to D416: INP-1812 - Change "LeftJoinOptimizer" to find table aliases usage only at word boundaries.

Работает всё как надо, но наверное надо исправить Test Plan. В "Plan 2" и "Plan 3" в SQL не хватает фильтра WHERE ((52x_Users.UserType = 0))

Jul 14 2022, 10:35 AM
erik accepted D269: INP-1645 - Create categories during theme scan based on their location in SMS.
Jul 14 2022, 10:09 AM
erik accepted D419: INP-1816 - Use argument-based cache in the "kApplication::GetDefaultThemeId" method.
Jul 14 2022, 9:19 AM · Restricted Project

Jul 6 2022

erik updated the diff for D420: INP-1817 - Change engine for storing export user presets.

Added missing table creation on in-portal upgrade

Jul 6 2022, 10:45 AM

Jul 5 2022

erik updated the diff for D420: INP-1817 - Change engine for storing export user presets.

Changed install schema due Jenkins message - all primary key fields must be without null values

Jul 5 2022, 10:01 AM
erik updated the diff for D420: INP-1817 - Change engine for storing export user presets.

Made all requested improvements

Jul 5 2022, 6:03 AM

Jul 4 2022

erik requested review of D420: INP-1817 - Change engine for storing export user presets.
Jul 4 2022, 12:57 PM

Apr 6 2022

erik accepted D413: INP-1809 - Introduce active editing window tracking system.
Apr 6 2022, 12:49 PM · Restricted Project

Sep 22 2021

erik accepted D415: INP-1811 - Support partitions in grids and direct INSERT/UPDATE clauses.
Sep 22 2021, 10:37 AM

Sep 8 2021

erik accepted D414: INP-1810 - Use linked info in "OnNew" event only, when it's available.
Sep 8 2021, 5:37 AM

Aug 27 2021

erik updated the diff for D411: INP-1757 - Replace "each" function usage with equivalent code.

Made all requested fixes

Aug 27 2021, 9:31 AM

Aug 6 2021

erik accepted D412: INP-1808 - Create "E-mail Log" records using corresponding unit.
Aug 6 2021, 9:19 AM

Aug 5 2021

erik updated the diff for D411: INP-1757 - Replace "each" function usage with equivalent code.

Done requested changes in all other modules

Aug 5 2021, 1:59 PM
erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Aug 5 2021, 1:51 PM

Aug 4 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Aug 4 2021, 5:59 AM

Jul 29 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jul 29 2021, 1:46 PM
erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jul 29 2021, 6:22 AM

Jul 28 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jul 28 2021, 1:51 PM

Jul 21 2021

erik accepted D413: INP-1809 - Introduce active editing window tracking system.
Jul 21 2021, 9:35 AM · Restricted Project

Jul 16 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jul 16 2021, 2:18 AM

Jul 15 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jul 15 2021, 6:10 AM

Jul 14 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jul 14 2021, 5:56 AM

Jul 13 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jul 13 2021, 5:57 AM

Jul 12 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jul 12 2021, 5:57 AM

Jul 2 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jul 2 2021, 3:05 AM

Jun 30 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jun 30 2021, 5:56 AM

Jun 29 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jun 29 2021, 5:59 AM

Jun 23 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jun 23 2021, 1:57 PM
erik accepted D410: INP-1807 - Use dedicated connection for "kLogger" class.
Jun 23 2021, 5:30 AM

Jun 21 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jun 21 2021, 1:18 PM
erik requested review of D411: INP-1757 - Replace "each" function usage with equivalent code.
Jun 21 2021, 11:49 AM

Jun 17 2021

erik accepted D392: INP-1794 - Show database query execution times during deployment.
Jun 17 2021, 5:39 AM · Restricted Project

Jun 2 2021

erik accepted D409: INP-1806 - Display output of executed MySQL commands during build script execution.
Jun 2 2021, 5:57 AM · Restricted Project

May 18 2021

erik requested changes to D407: INP-1804 - Don't reset current user after all Scheduled Tasks were executed.

No output detected after doing test plan.

May 18 2021, 5:09 AM · Restricted Project
erik accepted D408: INP-1805 - Execute "adm:OnBeforeShutdown" event before AJAX request ending.
May 18 2021, 4:30 AM · Restricted Project

May 7 2021

erik accepted D405: INP-1802 - Speed up detection of countries with states.
May 7 2021, 2:44 AM · Restricted Project
erik accepted D406: INP-1803 - Show non-executed SQLs during deployment.
May 7 2021, 2:34 AM · Restricted Project

Mar 30 2021

erik accepted D404: INP-1801 - Use dynamic protocol during installation.
Mar 30 2021, 5:27 AM

Mar 24 2021

erik accepted D402: MINC-198 - Don't use "continue" inside a "switch" statement.
Mar 24 2021, 5:26 AM

Mar 17 2021

erik requested changes to D401: INP-1790 - Remove trailing space from "FieldsSeparatedBy" field of catalog item units.

Partially tested.
6 records appears in the System Log on one News record export.

  1. Field "ThumbnailImage" is not defined in "n" unit config
  2. Undefined index: ThumbnailImage
  3. Field "FullImage" is not defined in "n" unit config
  4. Undefined index: FullImage
  5. Field "ImageAlt" is not defined in "n" unit config
  6. Undefined index: ImageAlt
Mar 17 2021, 6:04 AM · Restricted Project
erik accepted D400: INP-1800 - Remove duplicate primary theme detection query.

Tested. Parent Section dropdown is not empty, "Home" value is visible in the Parent Section dropdown.

Mar 17 2021, 5:38 AM

Mar 15 2021

erik added a comment to D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.

Made QA changes, extended test plan.

Mar 15 2021, 10:43 AM · Restricted Project
erik updated the test plan for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 15 2021, 10:41 AM · Restricted Project
erik updated the diff for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.

QA Fixes

Mar 15 2021, 10:41 AM · Restricted Project

Mar 12 2021

erik updated the test plan for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 12 2021, 1:00 PM · Restricted Project
erik added inline comments to D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 12 2021, 12:17 PM · Restricted Project
erik updated the diff for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.

Added system user check to session LoggedIn method.

Mar 12 2021, 1:54 AM · Restricted Project

Mar 11 2021

erik requested review of D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 11 2021, 10:47 AM · Restricted Project

Mar 8 2021

erik accepted D398: INP-1798 - Include validation errors and temp mode flag in kDBItem validation error message.
Mar 8 2021, 4:42 AM · Restricted Project

Mar 4 2021

erik accepted D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
Mar 4 2021, 5:48 AM

Mar 3 2021

erik accepted D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.

Test plan is all right. But, beyond this patch, exists SQL error when doing "View Chart" for "By Product" and "By Section" cases. Problematic SQL is like

Mar 3 2021, 9:14 AM
erik accepted D390: INP-1792 - Support HTML markup with Title Presets.
Mar 3 2021, 5:04 AM
erik accepted D391: INP-1793 - Disable output buffering in Console.
Mar 3 2021, 4:56 AM · Restricted Project
erik accepted D396: INP-1797 - Speed up formatter class access from "kDBItem".
Mar 3 2021, 4:48 AM · Restricted Project

Feb 23 2021

erik accepted D395: MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields.
Feb 23 2021, 4:56 AM · Restricted Project

Feb 19 2021

erik accepted D392: INP-1794 - Show database query execution times during deployment.
Feb 19 2021, 3:50 AM · Restricted Project
erik added a comment to D393: INP-1795 - Invoke language pack comparison tool upon deploy using AppleScript.

Cant test this - do not have macOS

Feb 19 2021, 3:36 AM · Restricted Project
erik accepted D394: INP-1796 - Add method for setting database error handler.
Feb 19 2021, 3:22 AM

Aug 27 2020

erik accepted D384: INP-1786 - Don't use "continue" inside a "switch" statement.
Aug 27 2020, 5:31 AM · Restricted Project
erik accepted D385: INP-1787 - Don't use "get_magic_quotes_gpc" function.
Aug 27 2020, 5:29 AM · Restricted Project

Aug 17 2020

erik accepted D381: INP-1783 - Add "checkboxes" control type for configuration settings.
Aug 17 2020, 1:22 PM · Restricted Project
erik accepted D382: INP-1784 - Adjust "grid_total_td" block to respect "format" parameter.
Aug 17 2020, 1:14 PM · Restricted Project
erik accepted D383: INP-1785 - Always apply "no_default" format, when getting original field value.
Aug 17 2020, 1:06 PM · Restricted Project
erik added a comment to D384: INP-1786 - Don't use "continue" inside a "switch" statement.

Can't test - have PHP 7.2.19 only

Aug 17 2020, 1:02 PM · Restricted Project
erik added a comment to D385: INP-1787 - Don't use "get_magic_quotes_gpc" function.

I have no php 7.4 on VM to test/review this.

Aug 17 2020, 6:02 AM · Restricted Project