Page MenuHomeIn-Portal Phabricator
Feed All Stories

Jan 17 2016

alex updated the diff for D143: INP-1491 - Round numbers in kFormatter before using "sprintf".

Grammar fix.

Jan 17 2016, 4:31 AM · Restricted Project
alex updated the diff for D143: INP-1491 - Round numbers in kFormatter before using "sprintf".

Add code comment, that describes why high precision formats are not supported.

Jan 17 2016, 4:17 AM · Restricted Project
ci added a comment to rINP16304: Fixes INP-1514 - Reset validation errors before object loading.

Build #40 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/40/

Jan 17 2016, 3:58 AM
alex committed rINP16304: Fixes INP-1514 - Reset validation errors before object loading.
Fixes INP-1514 - Reset validation errors before object loading
Jan 17 2016, 3:44 AM
alex closed D167: INP-1514 Reset validation errors before object loading by committing rINP16304: Fixes INP-1514 - Reset validation errors before object loading.
Jan 17 2016, 3:44 AM · Restricted Project

Jan 14 2016

alex requested changes to D186: Remove excessive "dest_country" conversion in Shipping Quotes Engine.

The test plan is incomplete. Test plan should be written for someone, who doesn't understand what they are testing.

Jan 14 2016, 5:46 AM · Restricted Project
alex retitled D186: Remove excessive "dest_country" conversion in Shipping Quotes Engine from MINC-141 Remove excessive dest_country conversion in shipping quotes engine to Remove excessive "dest_country" conversion in Shipping Quotes Engine.
Jan 14 2016, 5:44 AM · Restricted Project
erik retitled D186: Remove excessive "dest_country" conversion in Shipping Quotes Engine from to MINC-141 Remove excessive dest_country conversion in shipping quotes engine.
Jan 14 2016, 5:05 AM · Restricted Project

Jan 13 2016

alex updated the test plan for D185: MINC-139 - Remove product object after Shopping Cart printing.
Jan 13 2016, 5:16 AM · Restricted Project
alex updated the test plan for D185: MINC-139 - Remove product object after Shopping Cart printing.
Jan 13 2016, 5:11 AM · Restricted Project
alex accepted D158: INP-1487 Create empty search result table, when search keyword is too short.

Keep up the good work.

Jan 13 2016, 4:39 AM · Restricted Project
glebs updated the test plan for D185: MINC-139 - Remove product object after Shopping Cart printing.
Jan 13 2016, 3:46 AM · Restricted Project
glebs retitled D185: MINC-139 - Remove product object after Shopping Cart printing from to MINC-139 Remove project object after Shopping Cart printing.
Jan 13 2016, 3:45 AM · Restricted Project

Jan 12 2016

alex retitled D184: MINC-140 - Assign last order to user registered after checkout process from to MINC-140 - Assign last order to user registered after checkout process.
Jan 12 2016, 8:56 AM · Restricted Project

Dec 25 2015

glebs accepted D183: MINC-138 - Update Order user via "OrdersItem" object on the user login/registration page.
Dec 25 2015, 2:39 AM · Restricted Project

Dec 24 2015

glebs accepted D181: INP-1525 - Register default build events when re-reading caches.
Dec 24 2015, 3:27 AM
glebs accepted D179: INP-1523 - Populate user info, when sending membership expiration e-mails.
Dec 24 2015, 3:27 AM

Dec 18 2015

alex requested review of D183: MINC-138 - Update Order user via "OrdersItem" object on the user login/registration page.

False alarm. Turned out to be an issue within customized code on one of the projects.

Dec 18 2015, 5:39 AM · Restricted Project
alex planned changes to D183: MINC-138 - Update Order user via "OrdersItem" object on the user login/registration page.

I'm getting No Permission error today (not sure why I wasn't getting it when this was developed initially). Need to investigate.

Dec 18 2015, 5:15 AM · Restricted Project

Dec 17 2015

alex retitled D183: MINC-138 - Update Order user via "OrdersItem" object on the user login/registration page from to MINC-138 - On user login/registration update Order user via "OrdersItem" object.
Dec 17 2015, 6:21 AM · Restricted Project

Dec 16 2015

erik retitled D182: MINC-137 Shopping cart update via AJAX support from to MINC-137 Shopping cart update via AJAX support.
Dec 16 2015, 4:25 AM · Restricted Project

Dec 15 2015

glebs accepted D177: INP-1522 - Adapt error output for CLI.
Dec 15 2015, 1:38 AM

Dec 14 2015

alex updated the test plan for D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.
Dec 14 2015, 4:57 AM
glebs accepted D178: INP-1524 - Disable auto-complete on password fields on user creation page.
Dec 14 2015, 2:02 AM

Dec 11 2015

alex retitled D181: INP-1525 - Register default build events when re-reading caches from to INP-1525 - Register default build events when re-reading caches.
Dec 11 2015, 11:25 AM
glebs accepted D176: MINL-18 - Change link categories automatically according to it's Listing Type.
Dec 11 2015, 1:38 AM

Dec 9 2015

glebs accepted D175: INP-1521 - Don't expose InitList and PrintList tag communication to Web Request.
Dec 9 2015, 2:16 AM

Dec 8 2015

erik updated the diff for D120: INP-1470 - Google Sitemap support.

Requested fixes and improvements.

Dec 8 2015, 4:55 AM · Restricted Project

Dec 7 2015

alex added inline comments to D120: INP-1470 - Google Sitemap support.
Dec 7 2015, 9:55 AM · Restricted Project
alex added inline comments to D120: INP-1470 - Google Sitemap support.
Dec 7 2015, 9:34 AM · Restricted Project
alex added a comment to D120: INP-1470 - Google Sitemap support.

Please revert change, that makes red categories not present in sitemap by default (seems to be 2 places: sql during upgrade and $in_sitemap = false during auto-creation), because it creates nasty side effect: when debug mode is enabled I don't see Platform category (IncludeInSitemap=0), while it's sub-categories (e.g. Maintenance Mode) are marked as IncludeInSitemap.

Dec 7 2015, 6:44 AM · Restricted Project
alex added a comment to D120: INP-1470 - Google Sitemap support.

I see following warnings when full Advanced theme rescan is happening:

  • simplexml_load_string(): Entity: line 1: parser error : xmlParseEntityRef: no name
  • simplexml_load_string(): <meta_info>CSS & JAVASCRIPT FOR IN-COMMERCE</meta_info>
  • simplexml_load_string(): ^
Dec 7 2015, 6:01 AM · Restricted Project
alex added inline comments to D120: INP-1470 - Google Sitemap support.
Dec 7 2015, 5:13 AM · Restricted Project
alex requested changes to D120: INP-1470 - Google Sitemap support.
Dec 7 2015, 5:04 AM · Restricted Project
glebs accepted D174: INP-1520 - Honor manually set owner of categories/category items created from CLI.
Dec 7 2015, 2:13 AM
glebs accepted D173: MINN-11 - Specify category for RSS feed articles via "CategoryId" field.
Dec 7 2015, 1:42 AM

Dec 6 2015

alex added a child revision for D172: MINN-10 - Don't use Web Request during Article adding/editing: D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.
Dec 6 2015, 8:36 AM
alex added a child revision for D50: INP-1413 - Don't do full Application Init during deployment: D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.
Dec 6 2015, 8:36 AM · Restricted Project
alex added a child revision for D175: INP-1521 - Don't expose InitList and PrintList tag communication to Web Request: D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.
Dec 6 2015, 8:36 AM
alex added a child revision for D174: INP-1520 - Honor manually set owner of categories/category items created from CLI: D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.
Dec 6 2015, 8:36 AM
alex added a child revision for D176: MINL-18 - Change link categories automatically according to it's Listing Type: D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.
Dec 6 2015, 8:36 AM
alex added parent revisions for D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI: D50: INP-1413 - Don't do full Application Init during deployment, D174: INP-1520 - Honor manually set owner of categories/category items created from CLI, D175: INP-1521 - Don't expose InitList and PrintList tag communication to Web Request, D179: INP-1523 - Populate user info, when sending membership expiration e-mails, D176: MINL-18 - Change link categories automatically according to it's Listing Type, D173: MINN-11 - Specify category for RSS feed articles via "CategoryId" field, D169: INP-1517 - Define INDEX_FILE constant in each CLI script, D170: INP-1518 - Remove excessive owner detection code from "cacheItemOwner" method, D172: MINN-10 - Don't use Web Request during Article adding/editing.
Dec 6 2015, 8:36 AM
alex added a child revision for D170: INP-1518 - Remove excessive owner detection code from "cacheItemOwner" method: D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.
Dec 6 2015, 8:36 AM
alex added a child revision for D173: MINN-11 - Specify category for RSS feed articles via "CategoryId" field: D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.
Dec 6 2015, 8:36 AM
alex added a child revision for D169: INP-1517 - Define INDEX_FILE constant in each CLI script: D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.
Dec 6 2015, 8:36 AM
alex added a child revision for D179: INP-1523 - Populate user info, when sending membership expiration e-mails: D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.
Dec 6 2015, 8:36 AM
alex updated the diff for D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.

Rollback changes, that were added through applying another needed patch.

Dec 6 2015, 8:32 AM
alex retitled D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI from to INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.
Dec 6 2015, 8:16 AM
alex updated the diff for D179: INP-1523 - Populate user info, when sending membership expiration e-mails.

Forgot to add language pack changes

Dec 6 2015, 7:45 AM
alex retitled D179: INP-1523 - Populate user info, when sending membership expiration e-mails from to INP-1523 - Populate user info, when sending membership expiration e-mails.
Dec 6 2015, 7:42 AM
alex retitled D178: INP-1524 - Disable auto-complete on password fields on user creation page from to INP-1524 - Disable auto-complete on password fields on user creation page.
Dec 6 2015, 7:11 AM

Dec 5 2015

alex retitled D177: INP-1522 - Adapt error output for CLI from to INP-1522 - Adapt error output for CLI.
Dec 5 2015, 1:24 PM
alex retitled D176: MINL-18 - Change link categories automatically according to it's Listing Type from to MINL-18 - Link isn't added/removed to category specified in Listing Type.
Dec 5 2015, 10:11 AM
alex retitled D175: INP-1521 - Don't expose InitList and PrintList tag communication to Web Request from to INP-1521 - Don't expose InitList and PrintList tag communication to Web Request.
Dec 5 2015, 8:32 AM

Dec 4 2015

glebs accepted D172: MINN-10 - Don't use Web Request during Article adding/editing.
Dec 4 2015, 2:53 AM

Dec 2 2015

glebs accepted D171: INP-1519 - Generate e-mail access key after subject is prepared.
Dec 2 2015, 2:01 AM
glebs accepted D170: INP-1518 - Remove excessive owner detection code from "cacheItemOwner" method.
Dec 2 2015, 1:51 AM
glebs accepted D169: INP-1517 - Define INDEX_FILE constant in each CLI script.
Dec 2 2015, 1:39 AM

Nov 30 2015

glebs accepted D168: INP-1515 - Allow to enable/disable the Site Domain.
Nov 30 2015, 2:03 AM · Restricted Project

Nov 27 2015

glebs accepted D161: INP-1509 - Change concept used for category path matching to module root category.
Nov 27 2015, 2:54 AM · Restricted Project

Nov 19 2015

glebs updated the test plan for D166: INP-1513 Fix word wrapping in "inp_edit_checkboxes" form control.
Nov 19 2015, 2:30 AM · Restricted Project
glebs updated the diff for D166: INP-1513 Fix word wrapping in "inp_edit_checkboxes" form control.

Made requested changes

Nov 19 2015, 2:28 AM · Restricted Project

Nov 18 2015

alex updated the test plan for D174: INP-1520 - Honor manually set owner of categories/category items created from CLI.
Nov 18 2015, 2:34 PM
alex retitled D174: INP-1520 - Honor manually set owner of categories/category items created from CLI from to INP-1520 - Honor manually set owner of categories/category items created from CLI.
Nov 18 2015, 2:34 PM
alex retitled D173: MINN-11 - Specify category for RSS feed articles via "CategoryId" field from to MINN-11 - Specify category for RSS feed articles via "CategoryId" field.
Nov 18 2015, 7:23 AM
alex retitled D172: MINN-10 - Don't use Web Request during Article adding/editing from to MINN-10 - Don't use Web Request during Article adding/editing.
Nov 18 2015, 6:36 AM

Nov 17 2015

alex retitled D171: INP-1519 - Generate e-mail access key after subject is prepared from to INP-1519 - Generate e-mail access key after subject is prepared.
Nov 17 2015, 2:17 PM
alex committed rTBST16303: Releasing version 'branches/1.0.x' (copy from 'trunk') of 'themes/bootstrap'….
Releasing version 'branches/1.0.x' (copy from 'trunk') of 'themes/bootstrap'…
Nov 17 2015, 5:55 AM
alex committed rTBST16302: Bug TBST-1 - Create theme in repository.
Bug TBST-1 - Create theme in repository
Nov 17 2015, 5:44 AM
alex updated the test plan for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Nov 17 2015, 4:49 AM · Restricted Project
erik updated the diff for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.

Removed excessive line, improved test plan before this revision

Nov 17 2015, 4:29 AM · Restricted Project
erik updated the test plan for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Nov 17 2015, 4:21 AM · Restricted Project
alex accepted D167: INP-1514 Reset validation errors before object loading.
Nov 17 2015, 3:12 AM · Restricted Project
alex updated the test plan for D167: INP-1514 Reset validation errors before object loading.
Nov 17 2015, 3:11 AM · Restricted Project
alex updated the test plan for D167: INP-1514 Reset validation errors before object loading.
Nov 17 2015, 3:11 AM · Restricted Project
alex added inline comments to D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Nov 17 2015, 3:10 AM · Restricted Project
alex requested changes to D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.

The test plan wasn't changed as requested.

Nov 17 2015, 3:04 AM · Restricted Project
alex added a parent revision for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method: D167: INP-1514 Reset validation errors before object loading.
Nov 17 2015, 2:35 AM · Restricted Project
alex updated the test plan for D167: INP-1514 Reset validation errors before object loading.
Nov 17 2015, 2:35 AM · Restricted Project
alex updated the test plan for D167: INP-1514 Reset validation errors before object loading.
Nov 17 2015, 2:34 AM · Restricted Project

Nov 16 2015

alex retitled D170: INP-1518 - Remove excessive owner detection code from "cacheItemOwner" method from to INP-1518 - Remove excessive owner detection code from "cacheItemOwner" method.
Nov 16 2015, 3:03 PM
alex retitled D169: INP-1517 - Define INDEX_FILE constant in each CLI script from to INP-1517 - Define INDEX_FILE constant in each CLI script.
Nov 16 2015, 2:37 PM
alex updated the test plan for D168: INP-1515 - Allow to enable/disable the Site Domain.
Nov 16 2015, 11:24 AM · Restricted Project
alex retitled D168: INP-1515 - Allow to enable/disable the Site Domain from to INP-1515 - Allow to enable/disable the Site Domain.
Nov 16 2015, 11:24 AM · Restricted Project
erik updated the test plan for D167: INP-1514 Reset validation errors before object loading.
Nov 16 2015, 4:39 AM · Restricted Project
erik retitled D167: INP-1514 Reset validation errors before object loading from to INP-1514 Reset validation errors before object loading.
Nov 16 2015, 4:33 AM · Restricted Project
erik updated the diff for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.

Removed Clear() calls, added in the previous version of revision.

Nov 16 2015, 4:20 AM · Restricted Project
glebs requested review of D3: INP-1381 - Create special template for fatal error page.
Nov 16 2015, 3:14 AM · Restricted Project
alex requested changes to D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.

... added Clear() calls to fit new plan.

Nov 16 2015, 3:04 AM · Restricted Project

Nov 14 2015

alex added a comment to D3: INP-1381 - Create special template for fatal error page.

Just send revision for review somehow without making any code changes.

Nov 14 2015, 8:35 AM · Restricted Project

Nov 13 2015

alex requested changes to D3: INP-1381 - Create special template for fatal error page.
Nov 13 2015, 4:43 AM · Restricted Project
alex requested changes to D166: INP-1513 Fix word wrapping in "inp_edit_checkboxes" form control.

The test plan:

  • doesn't include steps for testing clean install/upgrade
  • doesn't work (I've tried to do as written in test plan and problem is still there)
Nov 13 2015, 3:23 AM · Restricted Project
glebs retitled D166: INP-1513 Fix word wrapping in "inp_edit_checkboxes" form control from to INP-1513 Fix wrong line wrapping in inp_edit_checkboxes.
Nov 13 2015, 2:12 AM · Restricted Project

Nov 11 2015

alex accepted D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 11 2015, 6:38 AM · Restricted Project
erik updated the diff for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

Fixed SQL code indent

Nov 11 2015, 6:18 AM · Restricted Project
alex requested changes to D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

Code tested according to plan. Please do that last cosmetical change and we're done here.

Nov 11 2015, 5:10 AM · Restricted Project
alex updated the test plan for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 11 2015, 5:05 AM · Restricted Project
alex updated the test plan for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 11 2015, 5:01 AM · Restricted Project

Nov 10 2015

erik updated the diff for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

Removed new helper, made inline code with count() in cycle conditions

Nov 10 2015, 11:45 AM · Restricted Project
alex added inline comments to D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 10 2015, 5:23 AM · Restricted Project