Page MenuHomeIn-Portal Phabricator
Feed All Stories

Aug 13 2020

alex requested review of D387: INP-1789 - Teach "Changes Log" section to respect "kDBItem::Update" calls with limited field set.
Aug 13 2020, 5:12 AM · Restricted Project

Aug 10 2020

alex added a project to D386: INP-1788 - Trigger a warning, when not all fields were updated via "kDBItem::Update" method call: Restricted Project.
Aug 10 2020, 10:45 AM · Restricted Project
alex requested review of D386: INP-1788 - Trigger a warning, when not all fields were updated via "kDBItem::Update" method call.
Aug 10 2020, 9:20 AM · Restricted Project

Jun 11 2020

alex accepted D231: INP-1560 Migrate "mysql" to "mysqli" database type during upgrade.
Jun 11 2020, 4:59 AM

Jun 10 2020

alex added a project to D385: INP-1787 - Don't use "get_magic_quotes_gpc" function: Restricted Project.
Jun 10 2020, 8:27 AM · Restricted Project
alex requested review of D385: INP-1787 - Don't use "get_magic_quotes_gpc" function.
Jun 10 2020, 8:27 AM · Restricted Project
alex added a project to D384: INP-1786 - Don't use "continue" inside a "switch" statement: Restricted Project.
Jun 10 2020, 8:14 AM · Restricted Project
alex requested review of D384: INP-1786 - Don't use "continue" inside a "switch" statement.
Jun 10 2020, 8:14 AM · Restricted Project

Jun 4 2020

alex added a project to D383: INP-1785 - Always apply "no_default" format, when getting original field value: Restricted Project.
Jun 4 2020, 5:27 AM · Restricted Project
alex requested review of D383: INP-1785 - Always apply "no_default" format, when getting original field value.
Jun 4 2020, 5:26 AM · Restricted Project

May 29 2020

alex added a project to D382: INP-1784 - Adjust "grid_total_td" block to respect "format" parameter: Restricted Project.
May 29 2020, 5:35 AM · Restricted Project
alex requested review of D382: INP-1784 - Adjust "grid_total_td" block to respect "format" parameter.
May 29 2020, 5:34 AM · Restricted Project

May 13 2020

alex added a project to D381: INP-1783 - Add "checkboxes" control type for configuration settings: Restricted Project.
May 13 2020, 9:13 AM · Restricted Project
alex requested review of D381: INP-1783 - Add "checkboxes" control type for configuration settings.
May 13 2020, 9:12 AM · Restricted Project

Apr 22 2020

alex updated the diff for D229: INP-1565 Add support for "relative" date format.
  1. moved handling of "relative" format from "kDateFormatter::Parse" method (where it wasn't working obviously) to the "kDateFormatter::Format" method
  2. restored "DateHelper" class, that was removed in 622 diff by mistake
Apr 22 2020, 3:49 AM

Apr 14 2020

erik added a comment to D361: INP-1764 - Set correct exit code, when exception happens in CLI.
Apr 14 2020, 2:03 PM · Restricted Project
erik accepted D361: INP-1764 - Set correct exit code, when exception happens in CLI.

Tested - got 0 and 1 codes, as planned.

Apr 14 2020, 5:45 AM · Restricted Project

Mar 26 2020

erik accepted D379: INP-1781 - Respect sub-item status, when performing unique validation.
Mar 26 2020, 6:12 AM · Restricted Project

Mar 18 2020

alex requested review of D379: INP-1781 - Respect sub-item status, when performing unique validation.

Please test again. Also update test plan to include testing of added code fragment: http://qa.in-portal.org/D379?vs=927&id=929#toc .

Mar 18 2020, 4:52 AM · Restricted Project
alex updated the diff for D379: INP-1781 - Respect sub-item status, when performing unique validation.

Don't perform unique validation from TEMP to LIVE table, when parent record isn't yet created in TEMP table.

Mar 18 2020, 4:45 AM · Restricted Project
alex planned changes to D379: INP-1781 - Respect sub-item status, when performing unique validation.

Detected an issue (SQL error), when validation of sub-item happens to before parent item is saved into the database.

Mar 18 2020, 4:22 AM · Restricted Project

Mar 11 2020

erik requested review of D380: INP-1782 Allow multiple sections from single unit to have separate permissions.
Mar 11 2020, 1:46 PM

Mar 9 2020

alex added a comment to D377: INP-1779 - Throw an exception, when SQL error is detected in CLI.
In D377#7476, @erik wrote:

Tested, accepted.

In the run_event. php first line must be commented to make test plan possible.

exit_code(1, 'This script needs to be enabled manually !');

Mar 9 2020, 6:59 AM · Restricted Project
alex updated the test plan for D377: INP-1779 - Throw an exception, when SQL error is detected in CLI.
Mar 9 2020, 6:59 AM · Restricted Project
erik accepted D377: INP-1779 - Throw an exception, when SQL error is detected in CLI.

In the run_event. php first line must be commented to make test plan possible.

Mar 9 2020, 5:43 AM · Restricted Project
erik accepted D378: INP-1780 - Sync "Semaphores" table structure between clean install and upgrade.

Got JS alert "Copying operation in Temporary tables has failed. Please contact website administrator." If this is popup about concurrent Save attempt - then accepted.

Mar 9 2020, 5:30 AM · Restricted Project

Feb 19 2020

erik accepted D379: INP-1781 - Respect sub-item status, when performing unique validation.
Feb 19 2020, 11:47 AM · Restricted Project
alex updated the test plan for D379: INP-1781 - Respect sub-item status, when performing unique validation.
Feb 19 2020, 11:11 AM · Restricted Project
alex requested review of D379: INP-1781 - Respect sub-item status, when performing unique validation.
Feb 19 2020, 11:09 AM · Restricted Project

Jan 27 2020

alex updated the test plan for D378: INP-1780 - Sync "Semaphores" table structure between clean install and upgrade.
Jan 27 2020, 6:52 AM · Restricted Project
alex requested review of D378: INP-1780 - Sync "Semaphores" table structure between clean install and upgrade.
Jan 27 2020, 6:52 AM · Restricted Project

Jan 24 2020

alex added a project to D377: INP-1779 - Throw an exception, when SQL error is detected in CLI: Restricted Project.
Jan 24 2020, 3:02 AM · Restricted Project
alex requested review of D377: INP-1779 - Throw an exception, when SQL error is detected in CLI.
Jan 24 2020, 3:02 AM · Restricted Project

Jan 21 2020

alex accepted D376: INP-1778 Auto-focus correct form control on error.
Jan 21 2020, 9:23 AM

Jan 17 2020

erik updated the test plan for D376: INP-1778 Auto-focus correct form control on error.
Jan 17 2020, 8:09 AM
erik requested review of D376: INP-1778 Auto-focus correct form control on error.
Jan 17 2020, 8:06 AM

Dec 16 2019

alex added inline comments to D237: INP-1572 - Change semaphores to allow concurrent editing of different DB records.
Dec 16 2019, 7:42 AM · Restricted Project

Oct 17 2019

erik accepted D375: INP-1777 - Preserve non-existing selected options during record field value display.
Oct 17 2019, 12:07 PM · Restricted Project
alex added a project to D375: INP-1777 - Preserve non-existing selected options during record field value display: Restricted Project.
Oct 17 2019, 7:59 AM · Restricted Project
alex requested review of D375: INP-1777 - Preserve non-existing selected options during record field value display.
Oct 17 2019, 7:58 AM · Restricted Project

Aug 6 2019

erik accepted D374: INP-1776 - Define permission mapping for "OnExportCancel" event.
Aug 6 2019, 6:14 AM
alex requested review of D374: INP-1776 - Define permission mapping for "OnExportCancel" event.
Aug 6 2019, 5:06 AM

Jul 15 2019

alex updated the diff for D373: INP-1775 - Rename uploaded images to match their image type (when "storage_format" is used).

Debug code removed.

Jul 15 2019, 8:13 AM · Restricted Project
alex updated the diff for D373: INP-1775 - Rename uploaded images to match their image type (when "storage_format" is used).

Usage of \FileHelper::ensureUniqueFilename was expecting specific version of that method only available in In-Portal 5.2.x.

Jul 15 2019, 8:12 AM · Restricted Project

Jul 12 2019

erik accepted D372: INP-1774 - Display scaled down file size in uploader.
Jul 12 2019, 5:45 AM · Restricted Project
erik accepted D373: INP-1775 - Rename uploaded images to match their image type (when "storage_format" is used).
Jul 12 2019, 5:38 AM · Restricted Project

Jul 11 2019

alex updated the test plan for D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jul 11 2019, 12:22 PM · Restricted Project
alex updated the diff for D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.

Fixed case, when "output_format" option was ignored, when image wasn't resized.

Jul 11 2019, 12:14 PM · Restricted Project

Jul 10 2019

alex updated the test plan for D373: INP-1775 - Rename uploaded images to match their image type (when "storage_format" is used).
Jul 10 2019, 11:43 PM · Restricted Project
alex updated the test plan for D373: INP-1775 - Rename uploaded images to match their image type (when "storage_format" is used).
Jul 10 2019, 10:30 AM · Restricted Project
alex added a project to D373: INP-1775 - Rename uploaded images to match their image type (when "storage_format" is used): Restricted Project.
Jul 10 2019, 10:19 AM · Restricted Project
alex added a child revision for D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing: D373: INP-1775 - Rename uploaded images to match their image type (when "storage_format" is used).
Jul 10 2019, 10:19 AM · Restricted Project
alex added a parent revision for D373: INP-1775 - Rename uploaded images to match their image type (when "storage_format" is used): D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jul 10 2019, 10:19 AM · Restricted Project
alex requested review of D373: INP-1775 - Rename uploaded images to match their image type (when "storage_format" is used).
Jul 10 2019, 10:18 AM · Restricted Project

Jul 5 2019

alex added a project to D372: INP-1774 - Display scaled down file size in uploader: Restricted Project.
Jul 5 2019, 10:19 AM · Restricted Project
alex requested review of D372: INP-1774 - Display scaled down file size in uploader.
Jul 5 2019, 10:12 AM · Restricted Project

Jun 27 2019

alex accepted D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jun 27 2019, 6:20 AM · Restricted Project
erik requested review of D370: INP-1773 Use "round" function during image resize instead of "ceil".

Changed test plan to use image helper.

Jun 27 2019, 5:39 AM · Restricted Project
erik updated the test plan for D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jun 27 2019, 5:38 AM · Restricted Project
alex accepted D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 27 2019, 4:49 AM · Restricted Project
alex updated the test plan for D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 27 2019, 4:49 AM · Restricted Project
alex requested changes to D370: INP-1773 Use "round" function during image resize instead of "ceil".

Opening Front-End gives me these PHP warnings:

Jun 27 2019, 4:43 AM · Restricted Project

Jun 26 2019

erik updated the test plan for D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 26 2019, 9:41 AM · Restricted Project
alex updated the test plan for D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jun 26 2019, 8:52 AM · Restricted Project
alex updated the test plan for D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 26 2019, 8:51 AM · Restricted Project
alex added a project to D370: INP-1773 Use "round" function during image resize instead of "ceil": Restricted Project.
Jun 26 2019, 8:46 AM · Restricted Project
alex added a project to D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images: Restricted Project.
Jun 26 2019, 8:46 AM · Restricted Project
erik updated the test plan for D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 26 2019, 6:40 AM · Restricted Project
erik requested review of D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 26 2019, 6:40 AM · Restricted Project
erik updated the test plan for D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jun 26 2019, 6:25 AM · Restricted Project
erik added a comment to D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jun 26 2019, 6:22 AM · Restricted Project
erik requested review of D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jun 26 2019, 6:20 AM · Restricted Project

Jun 25 2019

alex updated the diff for D369: INP-1771 - Change slave lag detection code to use "SHOW SLAVE STATUS" query.

Handle cases, when slave is too busy catching up with a master.

Jun 25 2019, 7:41 AM · Restricted Project
erik accepted D369: INP-1771 - Change slave lag detection code to use "SHOW SLAVE STATUS" query.
Jun 25 2019, 5:40 AM · Restricted Project
alex updated the test plan for D369: INP-1771 - Change slave lag detection code to use "SHOW SLAVE STATUS" query.
Jun 25 2019, 5:19 AM · Restricted Project

Jun 24 2019

alex updated the test plan for D369: INP-1771 - Change slave lag detection code to use "SHOW SLAVE STATUS" query.
Jun 24 2019, 8:57 AM · Restricted Project
alex updated the test plan for D369: INP-1771 - Change slave lag detection code to use "SHOW SLAVE STATUS" query.
Jun 24 2019, 8:56 AM · Restricted Project
alex requested review of D369: INP-1771 - Change slave lag detection code to use "SHOW SLAVE STATUS" query.
Jun 24 2019, 8:32 AM · Restricted Project

Jun 20 2019

alex accepted D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 20 2019, 10:03 AM · Restricted Project

Jun 19 2019

erik updated the test plan for D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 19 2019, 7:53 AM · Restricted Project
erik updated the diff for D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.

Combined error messages.

Jun 19 2019, 7:52 AM · Restricted Project
alex requested changes to D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 19 2019, 3:00 AM · Restricted Project

Jun 18 2019

erik updated the test plan for D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 10:23 AM · Restricted Project
erik updated the test plan for D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 10:22 AM · Restricted Project
erik updated the diff for D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.

Fixed thrown exceprion messages.

Jun 18 2019, 10:21 AM · Restricted Project
erik added inline comments to D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 10:10 AM · Restricted Project
erik updated the test plan for D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 9:47 AM · Restricted Project
erik updated the test plan for D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 9:01 AM · Restricted Project
alex added a project to D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing: Restricted Project.
Jun 18 2019, 3:07 AM · Restricted Project
alex requested changes to D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.

In the themes\advanced\in-bulletin\elements\side_boxes\polls.elm.tpl change poll image output code to:

Jun 18 2019, 3:03 AM · Restricted Project

Jun 14 2019

erik updated the test plan for D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 14 2019, 9:31 AM · Restricted Project
erik requested review of D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 14 2019, 9:29 AM · Restricted Project

Jun 7 2019

alex accepted D367: INP-1770 Load default user persistent settings all at once.
Jun 7 2019, 10:12 AM
erik updated the diff for D367: INP-1770 Load default user persistent settings all at once.

Removed excessive (array) typecast.

Jun 7 2019, 5:29 AM
alex requested changes to D367: INP-1770 Load default user persistent settings all at once.
Jun 7 2019, 2:35 AM

Jun 6 2019

erik updated the test plan for D367: INP-1770 Load default user persistent settings all at once.
Jun 6 2019, 12:24 PM
erik updated the diff for D367: INP-1770 Load default user persistent settings all at once.

Fixed logic.

Jun 6 2019, 12:23 PM
alex requested changes to D367: INP-1770 Load default user persistent settings all at once.

Also since task does optimization only, then here we should be checking that persistent setting retrieval with/without fallback code works as before (not covered) + verify performed SQL count (covered).

Jun 6 2019, 9:47 AM

Jun 5 2019

erik requested review of D367: INP-1770 Load default user persistent settings all at once.
Jun 5 2019, 10:17 AM

May 31 2019

erik accepted D366: INP-1769 - Truncate search result table instead of dropping it.
May 31 2019, 5:56 AM · Restricted Project