Page MenuHomeIn-Portal Phabricator
Feed All Stories

Yesterday

alex added a comment to D551: INP-1932 - Unify code for converting absolute into relative paths.
In D551#11308, @erik wrote:

\ImageHelper::ResizeImage - change "thumb_format" of poll's "Image" field to "resize:200x200;default:core/admin_templates/img/ajax_iframe_progress.gif" and try uploading a large (>200 by width/height) file on the poll editing page in the Admin Console

convertPathToRelative is called to convert each element in the $params array, however only "default" parameter contains file path. There are made excessive convertPathToRelative calls for some parameters (quality, output_format, etc.)

Tue, Dec 23, 6:28 AM
erik accepted D553: INP-1934 - Improve template compilation error reportring.
Tue, Dec 23, 5:40 AM
erik reopened D551: INP-1932 - Unify code for converting absolute into relative paths.

\ImageHelper::ResizeImage - change "thumb_format" of poll's "Image" field to "resize:200x200;default:core/admin_templates/img/ajax_iframe_progress.gif" and try uploading a large (>200 by width/height) file on the poll editing page in the Admin Console

Tue, Dec 23, 5:33 AM
erik accepted D552: INP-1933 - Report Compiled Template removal errors.
Tue, Dec 23, 4:14 AM

Mon, Dec 22

erik requested changes to D546: INP-1930 - Add Command-Line Template Compilation Support.

After clean install
Part 4.9 - confirm that you'll see an error message above the system settings list indicating which folders weren't deleted as part of the system setting change. - There appears only "Please manually delete paths:" message. No folder names are present in the message.

Mon, Dec 22, 4:55 AM

Sat, Dec 20

alex added a child revision for D551: INP-1932 - Unify code for converting absolute into relative paths: D553: INP-1934 - Improve template compilation error reportring.
Sat, Dec 20, 1:04 PM
alex added a parent revision for D553: INP-1934 - Improve template compilation error reportring: D551: INP-1932 - Unify code for converting absolute into relative paths.
Sat, Dec 20, 1:04 PM
alex requested review of D553: INP-1934 - Improve template compilation error reportring.
Sat, Dec 20, 1:04 PM
alex requested review of D546: INP-1930 - Add Command-Line Template Compilation Support.
Sat, Dec 20, 12:43 PM
alex updated the test plan for D546: INP-1930 - Add Command-Line Template Compilation Support.
Sat, Dec 20, 12:43 PM
alex updated the diff for D546: INP-1930 - Add Command-Line Template Compilation Support.

Restored chages in the TemplatesCache class, that were accidentally removed.

Sat, Dec 20, 6:19 AM
alex updated the diff for D546: INP-1930 - Add Command-Line Template Compilation Support.

Corrected permissions on the system folder itself. Report indirect compiled template removal as part of system setting change.

Sat, Dec 20, 6:17 AM
alex updated the test plan for D546: INP-1930 - Add Command-Line Template Compilation Support.
Sat, Dec 20, 6:15 AM
alex updated the test plan for D552: INP-1933 - Report Compiled Template removal errors.
Sat, Dec 20, 6:14 AM
alex added a parent revision for D546: INP-1930 - Add Command-Line Template Compilation Support: D552: INP-1933 - Report Compiled Template removal errors.
Sat, Dec 20, 6:12 AM
alex added a child revision for D552: INP-1933 - Report Compiled Template removal errors: D546: INP-1930 - Add Command-Line Template Compilation Support.
Sat, Dec 20, 6:12 AM
alex added a parent revision for D552: INP-1933 - Report Compiled Template removal errors: D551: INP-1932 - Unify code for converting absolute into relative paths.
Sat, Dec 20, 5:53 AM
alex added a child revision for D551: INP-1932 - Unify code for converting absolute into relative paths: D552: INP-1933 - Report Compiled Template removal errors.
Sat, Dec 20, 5:53 AM
alex updated the test plan for D552: INP-1933 - Report Compiled Template removal errors.
Sat, Dec 20, 5:51 AM
alex requested review of D552: INP-1933 - Report Compiled Template removal errors.
Sat, Dec 20, 5:49 AM

Fri, Dec 19

alex added "INP-1932" JIRA issue(s) to rINP16864: Fixes INP-1932 - Unify code for converting absolute into relative paths.
Fri, Dec 19, 11:27 AM
alex committed rINP16864: Fixes INP-1932 - Unify code for converting absolute into relative paths.
Fixes INP-1932 - Unify code for converting absolute into relative paths
Fri, Dec 19, 11:27 AM
alex closed D551: INP-1932 - Unify code for converting absolute into relative paths.
Fri, Dec 19, 11:27 AM

Thu, Dec 18

alex added a comment to D551: INP-1932 - Unify code for converting absolute into relative paths.
In D551#11256, @erik wrote:
  1. \NParserCompiler::FindTemplateFiles - recompile all templates from the System Tools section - first convertPathToRelative call is with $path = /core/admin_templates parameter, so no comversion happens - incoming path already is relative. However, result is relative path, so test is passed.
Thu, Dec 18, 2:44 AM

Wed, Dec 17

erik accepted D551: INP-1932 - Unify code for converting absolute into relative paths.
  1. \NParserCompiler::FindTemplateFiles - recompile all templates from the System Tools section - first convertPathToRelative call is with $path = /core/admin_templates parameter, so no comversion happens - incoming path already is relative. However, result is relative path, so test is passed.
Wed, Dec 17, 8:36 AM
alex updated the diff for D551: INP-1932 - Unify code for converting absolute into relative paths.

Reverted change from array_merge into += during template parser mass-compilation error displaying.

Wed, Dec 17, 4:37 AM
alex requested review of D551: INP-1932 - Unify code for converting absolute into relative paths.
Wed, Dec 17, 3:01 AM
alex updated the diff for D550: INP-1931 - Color Log Level names in the System Log.

Added color names in comments.

Wed, Dec 17, 2:24 AM

Tue, Dec 16

erik accepted D550: INP-1931 - Color Log Level names in the System Log.
Tue, Dec 16, 1:02 PM
alex updated the test plan for D550: INP-1931 - Color Log Level names in the System Log.
Tue, Dec 16, 12:46 PM
alex updated the diff for D550: INP-1931 - Color Log Level names in the System Log.

Improve handling of log levels, that doesn't require coloring.

Tue, Dec 16, 12:43 PM
erik accepted D550: INP-1931 - Color Log Level names in the System Log.

All task-defined coloring is right.

Tue, Dec 16, 8:24 AM
alex requested review of D550: INP-1931 - Color Log Level names in the System Log.
Tue, Dec 16, 6:17 AM

Thu, Dec 11

alex updated the test plan for D549: MINC-214 - Unify total calculation for Sale Reports.
Thu, Dec 11, 6:34 AM
erik added a comment to D549: MINC-214 - Unify total calculation for Sale Reports.

"use the above-created user and products (several with different quantities)"

Thu, Dec 11, 4:57 AM
erik accepted D549: MINC-214 - Unify total calculation for Sale Reports.
Thu, Dec 11, 4:56 AM
alex updated the diff for D549: MINC-214 - Unify total calculation for Sale Reports.

Cosmetic change.

Thu, Dec 11, 4:42 AM
erik accepted D548: MINC-213 - Change architecture of the Sales Report generator.
Thu, Dec 11, 4:32 AM
alex updated the test plan for D549: MINC-214 - Unify total calculation for Sale Reports.
Thu, Dec 11, 4:10 AM
alex requested review of D549: MINC-214 - Unify total calculation for Sale Reports.
Thu, Dec 11, 4:09 AM

Wed, Dec 10

alex updated the test plan for D548: MINC-213 - Change architecture of the Sales Report generator.
Wed, Dec 10, 12:37 PM
alex updated the test plan for D548: MINC-213 - Change architecture of the Sales Report generator.
Wed, Dec 10, 12:37 PM
alex requested review of D548: MINC-213 - Change architecture of the Sales Report generator.
Wed, Dec 10, 12:35 PM
alex added "INP-1859" JIRA issue(s) to rMINC16863: Bug INP-1859 - Escape MySQL 8.3 keywords.
Wed, Dec 10, 3:12 AM
alex committed rMINC16863: Bug INP-1859 - Escape MySQL 8.3 keywords.
Bug INP-1859 - Escape MySQL 8.3 keywords
Wed, Dec 10, 3:12 AM
alex closed D547: INP-1859 - Escape MySQL 8.3 keywords.
Wed, Dec 10, 3:12 AM

Tue, Dec 9

erik accepted D547: INP-1859 - Escape MySQL 8.3 keywords.

Without this change - also no SQL error. Maybe, because no MySQL 8.x in the test system.

Tue, Dec 9, 10:20 AM
alex updated the test plan for D547: INP-1859 - Escape MySQL 8.3 keywords.
Tue, Dec 9, 9:56 AM
alex requested review of D547: INP-1859 - Escape MySQL 8.3 keywords.
Tue, Dec 9, 9:54 AM

Tue, Nov 25

erik accepted D546: INP-1930 - Add Command-Line Template Compilation Support.
Tue, Nov 25, 11:26 AM
alex requested review of D546: INP-1930 - Add Command-Line Template Compilation Support.
In D546#11169, @erik wrote:

failed parts 1.10, 1.11. (in both clean install and upgrade cases)

after "use the Clear Templates Cache functionality"
system/cache/core/admin_templates folder is present and has drwxr-xr-x permissions, but system/cache/core/admin_templates/config folder is not present, and system/cache/core/admin_templates/config/config_universal.php file is not present.

under system/cache/core/admin_templates folder are present only incs folder and and tools folder

after "Compiled Template Permission Mode" is changed, system/cache/core/admin_templates/tools folder disappears and system/cache/core/admin_templates/config folder is created, so all other test plan checks are passed.

Tue, Nov 25, 10:53 AM
alex updated the test plan for D546: INP-1930 - Add Command-Line Template Compilation Support.
Tue, Nov 25, 10:52 AM
erik requested changes to D546: INP-1930 - Add Command-Line Template Compilation Support.

failed parts 1.10, 1.11. (in both clean install and upgrade cases)

Tue, Nov 25, 10:19 AM
alex updated the test plan for D546: INP-1930 - Add Command-Line Template Compilation Support.
Tue, Nov 25, 5:40 AM
alex requested review of D546: INP-1930 - Add Command-Line Template Compilation Support.
Tue, Nov 25, 5:37 AM

Nov 19 2025

erik accepted D545: INP-1929 - Increase e-mail template name size.
Nov 19 2025, 10:34 AM
alex requested review of D545: INP-1929 - Increase e-mail template name size.
Nov 19 2025, 8:29 AM

Nov 5 2025

alex added "INP-1928" JIRA issue(s) to rINP16862: Fixes INP-1928 - Automatic Scheduled Task creation protection.
Nov 5 2025, 7:58 AM
alex committed rINP16862: Fixes INP-1928 - Automatic Scheduled Task creation protection.
Fixes INP-1928 - Automatic Scheduled Task creation protection
Nov 5 2025, 7:58 AM
alex closed D544: INP-1928 - Automatic Scheduled Task creation protection.
Nov 5 2025, 7:58 AM

Oct 23 2025

erik accepted D544: INP-1928 - Automatic Scheduled Task creation protection.
Oct 23 2025, 10:45 AM