Page MenuHomeIn-Portal Phabricator

INP-1739 - Cache results of "\fckFCKHelper::getStyles" method

Authored by alex on Apr 18 2018, 6:12 AM.


Test Plan

Part 1

Repeat test plan of D251.

Part 2

  • in IDE:
    1. open /system/debug.php for editing
    2. uncomment DBG_CURL constant definition and save changes
    3. open /themes/advanced/index.tpl template for editing
    4. change <inp2:st_ContentBlock num="1"/> into <inp2:st_ContentBlock num="1" mode="inline"/><inp2:st_ContentBlock num="2" mode="inline"/> and save changes
  • in Admin Console:
    1. go to Website & ContentBrowse Website section
    2. click on Content Mode button in top frame
    3. if you get SQL error about ResponseHttpCode column in CurlLog table, then fix that table declaration by setting a default value for that column and repeating previous step
    4. confirm, that CURL request for getting styles was made only once

Diff Detail

rINP In-Portal
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Apr 18 2018, 6:12 AM
erik accepted this revision.Apr 25 2018, 6:08 AM
This revision is now accepted and ready to land.Apr 25 2018, 6:08 AM
This revision was automatically updated to reflect the committed changes.