Page MenuHomeIn-Portal Phabricator
Feed All Stories

Tue, Sep 2

alex requested changes to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Tue, Sep 2, 8:02 AM
erik updated the test plan for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Tue, Sep 2, 7:37 AM
erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Made all requested fixes. Created tests for kUbitFormatter class.

Tue, Sep 2, 7:33 AM
alex requested changes to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Also try to modify tested code to confirm, that related tests would fail.

Tue, Sep 2, 5:33 AM
erik accepted D539: INP-1923 - Display "Server Hostname" in the System Log.
Tue, Sep 2, 5:23 AM

Mon, Sep 1

erik updated the test plan for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Mon, Sep 1, 1:38 PM
erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Changed ligic, added unit tests.

Mon, Sep 1, 1:33 PM
alex requested review of D539: INP-1923 - Display "Server Hostname" in the System Log.
Mon, Sep 1, 7:05 AM
alex requested changes to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Let's implement this the other way around (sender does type casting, but recipient throws an exception on error on any PHP version):

Mon, Sep 1, 3:46 AM

Sun, Aug 31

alex added "INP-1874" JIRA issue(s) to rINP16855: Fixes INP-1874 - Sanitize $_SERVER['PHP_SELF'] value.
Sun, Aug 31, 12:18 PM
alex committed rINP16855: Fixes INP-1874 - Sanitize $_SERVER['PHP_SELF'] value.
Fixes INP-1874 - Sanitize $_SERVER['PHP_SELF'] value
Sun, Aug 31, 12:18 PM
alex added "INP-1876" JIRA issue(s) to rINP16854: Fixes INP-1876 - Verify system settings access permissions before allowing to….
Sun, Aug 31, 12:15 PM
alex committed rINP16854: Fixes INP-1876 - Verify system settings access permissions before allowing to….
Fixes INP-1876 - Verify system settings access permissions before allowing to…
Sun, Aug 31, 12:15 PM
alex closed D486: INP-1876 - Verify system settings access permissions before allowing to change them.
Sun, Aug 31, 12:15 PM · Restricted Project
alex added "INP-1880" JIRA issue(s) to rINP16853: Fixes INP-1880 - Fix notice on missing event permission mapping.
Sun, Aug 31, 12:09 PM
alex committed rINP16853: Fixes INP-1880 - Fix notice on missing event permission mapping.
Fixes INP-1880 - Fix notice on missing event permission mapping
Sun, Aug 31, 12:09 PM
alex closed D491: INP-1880 - Fix notice on missing event permission mapping.
Sun, Aug 31, 12:09 PM · Restricted Project
alex added "INP-1887" JIRA issue(s) to rINP16852: Fixes INP-1887 - Don't define the "EDITING_MODE" constant in the Installation….
Sun, Aug 31, 12:06 PM
alex committed rINP16852: Fixes INP-1887 - Don't define the "EDITING_MODE" constant in the Installation….
Fixes INP-1887 - Don't define the "EDITING_MODE" constant in the Installation…
Sun, Aug 31, 12:06 PM
alex closed D498: INP-1887 - Don't define the "EDITING_MODE" constant in the Installation Wizard.
Sun, Aug 31, 12:06 PM
alex added "INP-1888" JIRA issue(s) to rINP16851: Fixes INP-1888 - Detect Memcache availability during installation using….
Sun, Aug 31, 12:05 PM
alex committed rINP16851: Fixes INP-1888 - Detect Memcache availability during installation using….
Fixes INP-1888 - Detect Memcache availability during installation using…
Sun, Aug 31, 12:05 PM
alex closed D499: INP-1888 - Detect Memcache availability during installation using Memcache/Memcached PHP modules.
Sun, Aug 31, 12:05 PM
alex committed rINP16850: Fixes INP-1889 - Don't use DB Load Balancer during PHPUnit Testing.
Fixes INP-1889 - Don't use DB Load Balancer during PHPUnit Testing
Sun, Aug 31, 12:02 PM
alex added "INP-1889" JIRA issue(s) to rINP16850: Fixes INP-1889 - Don't use DB Load Balancer during PHPUnit Testing.
Sun, Aug 31, 12:02 PM
alex closed D500: INP-1889 - Don't use DB Load Balancer during PHPUnit Testing.
Sun, Aug 31, 12:02 PM
alex added "INP-1891" JIRA issue(s) to rINP16849: Fixes INP-1891 - Display PHP errors in the Phing build log.
Sun, Aug 31, 12:01 PM
alex committed rINP16849: Fixes INP-1891 - Display PHP errors in the Phing build log.
Fixes INP-1891 - Display PHP errors in the Phing build log
Sun, Aug 31, 12:01 PM
alex closed D502: INP-1891 - Display PHP errors in the Phing build log.
Sun, Aug 31, 12:01 PM
alex added "INP-1894" JIRA issue(s) to rINP16848: Bug INP-1894 - Extract "Change Log" code to a central place.
Sun, Aug 31, 11:58 AM
alex committed rINP16848: Bug INP-1894 - Extract "Change Log" code to a central place.
Bug INP-1894 - Extract "Change Log" code to a central place
Sun, Aug 31, 11:58 AM
alex closed D505: INP-1894 - Extract "Change Log" code to a central place.
Sun, Aug 31, 11:58 AM
alex added "INP-1905" JIRA issue(s) to rINP16847: Fixes INP-1905 - Clear the "Temp Mode" flag after the Temp Table removal from….
Sun, Aug 31, 11:56 AM
alex committed rINP16847: Fixes INP-1905 - Clear the "Temp Mode" flag after the Temp Table removal from….
Fixes INP-1905 - Clear the "Temp Mode" flag after the Temp Table removal from…
Sun, Aug 31, 11:56 AM
alex closed D516: INP-1905 - Clear the "Temp Mode" flag after the Temp Table removal from the "OnCancelEdit" event.
Sun, Aug 31, 11:56 AM
alex added "INP-1908" JIRA issue(s) to rINP16846: Fixes INP-1908 - Discard template parser opened output buffers before doing a….
Sun, Aug 31, 11:45 AM
alex committed rINP16846: Fixes INP-1908 - Discard template parser opened output buffers before doing a….
Fixes INP-1908 - Discard template parser opened output buffers before doing a…
Sun, Aug 31, 11:45 AM
alex closed D519: INP-1908 - Discard template parser opened output buffers before doing a redirect.
Sun, Aug 31, 11:45 AM
alex added "INP-1910" JIRA issue(s) to rINP16845: Fixes INP-1910 - Allow specifying upcoming System Log record defaults.
Sun, Aug 31, 11:43 AM
alex committed rINP16845: Fixes INP-1910 - Allow specifying upcoming System Log record defaults.
Fixes INP-1910 - Allow specifying upcoming System Log record defaults
Sun, Aug 31, 11:43 AM
alex closed D521: INP-1910 - Allow specifying upcoming System Log record defaults.
Sun, Aug 31, 11:43 AM
alex added "MINC-210" JIRA issue(s) to rMINC16844: Fixes MINC-210 - Repair Downloadable products file downloads on the Front-End.
Sun, Aug 31, 11:39 AM
alex committed rMINC16844: Fixes MINC-210 - Repair Downloadable products file downloads on the Front-End.
Fixes MINC-210 - Repair Downloadable products file downloads on the Front-End
Sun, Aug 31, 11:39 AM
alex closed D530: MINC-210 - Repair Downloadable products file downloads on the Front-End.
Sun, Aug 31, 11:39 AM
alex added "INP-1853" JIRA issue(s) to rINP16843: Fixes INP-1853 - Use the "\kUtil::varDumpColorized" method in the System Log….
Sun, Aug 31, 11:33 AM
alex committed rINP16843: Fixes INP-1853 - Use the "\kUtil::varDumpColorized" method in the System Log….
Fixes INP-1853 - Use the "\kUtil::varDumpColorized" method in the System Log…
Sun, Aug 31, 11:33 AM
alex closed D459: INP-1853 - Use the "\kUtil::varDumpColorized" method in the System Log Web UI.
Sun, Aug 31, 11:33 AM
alex added "INP-1852" JIRA issue(s) to rINP16842: Fixes INP-1852 - Create the "\kUtil::varDumpColorized" method.
Sun, Aug 31, 11:30 AM
alex committed rINP16842: Fixes INP-1852 - Create the "\kUtil::varDumpColorized" method.
Fixes INP-1852 - Create the "\kUtil::varDumpColorized" method
Sun, Aug 31, 11:30 AM
alex closed D458: INP-1852 - Create the "\kUtil::varDumpColorized" method.
Sun, Aug 31, 11:30 AM · Restricted Project
alex added "INP-1854" JIRA issue(s) to rINP16841: Fixes INP-1854 - Create global switch for Web Request/Session Data logging into….
Sun, Aug 31, 11:07 AM
alex committed rINP16841: Fixes INP-1854 - Create global switch for Web Request/Session Data logging into….
Fixes INP-1854 - Create global switch for Web Request/Session Data logging into…
Sun, Aug 31, 11:07 AM
alex closed D466: INP-1854 - Create global switch for Web Request/Session Data logging into the System Log.
Sun, Aug 31, 11:07 AM

Aug 14 2025

erik accepted D372: INP-1774 - Display scaled down file size in uploader.
Aug 14 2025, 1:36 PM · Restricted Project
alex requested review of D372: INP-1774 - Display scaled down file size in uploader.
Aug 14 2025, 5:36 AM · Restricted Project
alex updated the test plan for D372: INP-1774 - Display scaled down file size in uploader.
Aug 14 2025, 5:36 AM · Restricted Project
alex updated the diff for D372: INP-1774 - Display scaled down file size in uploader.

Fixed the filesize(): stat failed for error when uploading file larger, than 1MB.

Aug 14 2025, 5:26 AM · Restricted Project

Aug 13 2025

alex updated the test plan for D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.
Aug 13 2025, 6:58 AM

Aug 11 2025

alex added a comment to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.
In D529#10934, @erik wrote:

Added tests for Core and Custom modules -

Aug 11 2025, 7:45 AM
alex planned changes to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.
Aug 11 2025, 7:44 AM
alex updated the diff for D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Added tests for "core" and "custom" modules.

Aug 11 2025, 7:42 AM
erik requested changes to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Added tests for Core and Custom modules -

Aug 11 2025, 6:19 AM
alex updated the diff for D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Reclassified some tests from Unit to Functional.

Aug 11 2025, 2:10 AM

Aug 8 2025

alex updated the diff for D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Renamed the "kOptionsFormatter" class test for Phabricator to be able to generate coverage report from it.

Aug 8 2025, 2:28 AM

Aug 6 2025

alex added a comment to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Found these problems and fixed them (related to tests in the patch):

Aug 6 2025, 9:21 AM
alex updated the diff for D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Added more unit tests (original version created by Erik).

Aug 6 2025, 9:15 AM

Aug 5 2025

erik requested changes to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Tested all units, additional bugs found in the In-Commerce module.

Aug 5 2025, 12:27 PM
alex added "MINC-212" JIRA issue(s) to rMINC16840: Fixes MINC-212 - Fix notice in the "Entire Order" functionality for the….
Aug 5 2025, 2:45 AM
alex committed rMINC16840: Fixes MINC-212 - Fix notice in the "Entire Order" functionality for the….
Fixes MINC-212 - Fix notice in the "Entire Order" functionality for the…
Aug 5 2025, 2:45 AM
alex closed D538: MINC-212 Fix notice in the "Entire Order" functionality for the di/coupi/api units.
Aug 5 2025, 2:45 AM

Aug 4 2025

erik updated the test plan for D538: MINC-212 Fix notice in the "Entire Order" functionality for the di/coupi/api units.
Aug 4 2025, 6:32 AM
erik updated the test plan for D538: MINC-212 Fix notice in the "Entire Order" functionality for the di/coupi/api units.
Aug 4 2025, 6:29 AM
erik requested review of D538: MINC-212 Fix notice in the "Entire Order" functionality for the di/coupi/api units.
Aug 4 2025, 6:27 AM
alex added "INP-1919" JIRA issue(s) to rINP16839: Fixes INP-1919 - Reset unit config cache after Module Root Category change.
Aug 4 2025, 2:44 AM
alex committed rINP16839: Fixes INP-1919 - Reset unit config cache after Module Root Category change.
Fixes INP-1919 - Reset unit config cache after Module Root Category change
Aug 4 2025, 2:44 AM
alex closed D533: INP-1919 Reset unit config cache after Module Root Category change.
Aug 4 2025, 2:44 AM
alex accepted D533: INP-1919 Reset unit config cache after Module Root Category change.
Aug 4 2025, 2:42 AM

Aug 1 2025

alex requested changes to D537: MINC-211 Remove "TitleField" option for the di/coupi/api units.
  1. I've noticed, that the same issue happens also with coupi and api units of the In-Commerce. Please expand the Differential Revision code/test plan to cover them as well.
  2. I've noticed, that you're testing, that notice is gone, but not testing that item adding code still works. Please test that as well.
  3. I've also renamed the task. Please rename your changelist in the PhpStorm to avoid accidental Differential Revision rename on patch update.
Aug 1 2025, 3:36 AM
alex retitled D537: MINC-211 Remove "TitleField" option for the di/coupi/api units from MINC-211 Fix discount items configuration to MINC-211 Remove "TitleField" option for the di/coupi/api units.
Aug 1 2025, 3:31 AM

Jul 31 2025

erik added a comment to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Partially tested (done testing for Core module part).

  1. Languages.

1.1. Broken In-Portal clean install due error in lang prefix, preventing language record creation, required in normal installation process.
1.2. Due specific option_sql configuration for PackName and LocalName fields, possible add only record with values, that already exists. So, when no records in Languages table - can't add first language record.

  1. Categories - works well in admin interface, but problematic to add through object, because of Priority field options, that are populated only in OnPreSaveCreated event hook.
  2. Change logs - sometimes can't create through object same as languages, due specific Prefix and MasterPrefix field options_sql configuration. But in system records are created by direct SQL, so this not a problem. maybe.
  3. Users - can't create and update records with US State, because state options are populated too late - after SetFieldsFromHash already set error to the State field.
Jul 31 2025, 12:10 PM
erik updated the test plan for D537: MINC-211 Remove "TitleField" option for the di/coupi/api units.
Jul 31 2025, 5:51 AM
erik requested review of D537: MINC-211 Remove "TitleField" option for the di/coupi/api units.
Jul 31 2025, 5:51 AM
erik accepted D535: INP-1921 - Improve Change Log performance.
Jul 31 2025, 5:30 AM

Jul 30 2025

alex requested review of D535: INP-1921 - Improve Change Log performance.
Jul 30 2025, 5:43 AM

Jul 29 2025

alex added a comment to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.
In D529#10861, @erik wrote:

I do not understand relation between test plan and proposed automation logic.

  1. As I understand from test plan, not only required fields should be tested, but fields with specific formatter.
  2. As I understand from test plan, should test not only create, but also update.
  3. Each unit may be specific, may have dependencies to another units, so proposed automation logic seems is not helpful.
Jul 29 2025, 2:21 AM

Jul 28 2025

erik added a comment to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

I do not understand relation between test plan and proposed automation logic.

Jul 28 2025, 11:46 AM
alex added "INP-1920" JIRA issue(s) to rMINN16838: Bug INP-1920 - Ensure consistent named tab preset usage.
Jul 28 2025, 7:08 AM
alex committed rMINN16838: Bug INP-1920 - Ensure consistent named tab preset usage.
Bug INP-1920 - Ensure consistent named tab preset usage
Jul 28 2025, 7:08 AM
alex added "INP-1920" JIRA issue(s) to rMINB16837: Bug INP-1920 - Ensure consistent named tab preset usage.
Jul 28 2025, 7:08 AM
alex committed rMINB16837: Bug INP-1920 - Ensure consistent named tab preset usage.
Bug INP-1920 - Ensure consistent named tab preset usage
Jul 28 2025, 7:08 AM
alex added "INP-1920" JIRA issue(s) to rINP16836: Fixes INP-1920 - Ensure consistent named tab preset usage.
Jul 28 2025, 7:08 AM
alex committed rINP16836: Fixes INP-1920 - Ensure consistent named tab preset usage.
Fixes INP-1920 - Ensure consistent named tab preset usage
Jul 28 2025, 7:08 AM
alex closed D534: INP-1920 - Ensure consistent named tab preset usage.
Jul 28 2025, 7:08 AM
erik accepted D534: INP-1920 - Ensure consistent named tab preset usage.
Jul 28 2025, 6:37 AM
alex requested review of D534: INP-1920 - Ensure consistent named tab preset usage.
Jul 28 2025, 3:41 AM
alex added "INP-1915" JIRA issue(s) to rMINC16835: Bug INP-1915 - Add support for IPv6 addresses.
Jul 28 2025, 3:02 AM
alex committed rMINC16835: Bug INP-1915 - Add support for IPv6 addresses.
Bug INP-1915 - Add support for IPv6 addresses
Jul 28 2025, 3:02 AM
alex added "INP-1915" JIRA issue(s) to rMINB16834: Bug INP-1915 - Add support for IPv6 addresses.
Jul 28 2025, 3:02 AM
alex committed rMINB16834: Bug INP-1915 - Add support for IPv6 addresses.
Bug INP-1915 - Add support for IPv6 addresses
Jul 28 2025, 3:02 AM
alex added "INP-1915" JIRA issue(s) to rINP16833: Fixes INP-1915 - Add support for IPv6 addresses.
Jul 28 2025, 3:02 AM