Made all requested fixes. Created tests for kUbitFormatter class.
- Queries
- All Stories
- Search
- Advanced Search
All Stories
Tue, Sep 2
Also try to modify tested code to confirm, that related tests would fail.
Mon, Sep 1
Changed ligic, added unit tests.
Let's implement this the other way around (sender does type casting, but recipient throws an exception on error on any PHP version):
Sun, Aug 31
Aug 14 2025
Fixed the filesize(): stat failed for error when uploading file larger, than 1MB.
Aug 13 2025
Aug 11 2025
In D529#10934, @erik wrote:Added tests for Core and Custom modules -
unknown_option_tests_v2.patch72 KBDownload
Added tests for "core" and "custom" modules.
Added tests for Core and Custom modules -
Reclassified some tests from Unit to Functional.
Aug 8 2025
Renamed the "kOptionsFormatter" class test for Phabricator to be able to generate coverage report from it.
Aug 6 2025
Found these problems and fixed them (related to tests in the patch):
Added more unit tests (original version created by Erik).
Aug 5 2025
Tested all units, additional bugs found in the In-Commerce module.
Aug 4 2025
Aug 1 2025
- I've noticed, that the same issue happens also with coupi and api units of the In-Commerce. Please expand the Differential Revision code/test plan to cover them as well.
- I've noticed, that you're testing, that notice is gone, but not testing that item adding code still works. Please test that as well.
- I've also renamed the task. Please rename your changelist in the PhpStorm to avoid accidental Differential Revision rename on patch update.
Jul 31 2025
Partially tested (done testing for Core module part).
- Languages.
1.1. Broken In-Portal clean install due error in lang prefix, preventing language record creation, required in normal installation process.
1.2. Due specific option_sql configuration for PackName and LocalName fields, possible add only record with values, that already exists. So, when no records in Languages table - can't add first language record.
- Categories - works well in admin interface, but problematic to add through object, because of Priority field options, that are populated only in OnPreSaveCreated event hook.
- Change logs - sometimes can't create through object same as languages, due specific Prefix and MasterPrefix field options_sql configuration. But in system records are created by direct SQL, so this not a problem. maybe.
- Users - can't create and update records with US State, because state options are populated too late - after SetFieldsFromHash already set error to the State field.
Jul 30 2025
Jul 29 2025
In D529#10861, @erik wrote:I do not understand relation between test plan and proposed automation logic.
- As I understand from test plan, not only required fields should be tested, but fields with specific formatter.
- As I understand from test plan, should test not only create, but also update.
- Each unit may be specific, may have dependencies to another units, so proposed automation logic seems is not helpful.
Jul 28 2025
I do not understand relation between test plan and proposed automation logic.