Page MenuHomeIn-Portal Phabricator
Feed All Stories

Thu, Sep 4

alex added "INP-1926" JIRA issue(s) to rINP16860: Fixes INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Thu, Sep 4, 7:29 AM
alex committed rINP16860: Fixes INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Fixes INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log
Thu, Sep 4, 7:29 AM
alex closed D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Thu, Sep 4, 7:29 AM
erik accepted D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Thu, Sep 4, 6:28 AM
alex updated the diff for D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.

Use "la_fld_LogServerHostname" phrases (existing) instead of "la_fld_ServerHostname" (non-existing) in the Session Log grid.

Thu, Sep 4, 5:57 AM
erik requested changes to D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.

In the D539 added another phrase. Phrase la_fld_ServerHostname is detected as missing during tests.

Thu, Sep 4, 5:12 AM
alex requested review of D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
In D542#11101, @erik wrote:

All by test plan is ok, but missing phrase for "Server Hostname" field (Session log grid column title).

Thu, Sep 4, 2:24 AM
alex updated the test plan for D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Thu, Sep 4, 2:18 AM

Wed, Sep 3

erik requested changes to D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.

All by test plan is ok, but missing phrase for "Server Hostname" field (Session log grid column title).

Wed, Sep 3, 12:25 PM
alex added a parent revision for D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log: D539: INP-1923 - Display "Server Hostname" in the System Log.
Wed, Sep 3, 11:52 AM
alex added a child revision for D539: INP-1923 - Display "Server Hostname" in the System Log: D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Wed, Sep 3, 11:52 AM
alex requested review of D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Wed, Sep 3, 11:51 AM
alex committed rINP16859: Fixes INP-1923 - Display "Server Hostname" in the System Log.
Fixes INP-1923 - Display "Server Hostname" in the System Log
Wed, Sep 3, 11:46 AM
alex added "INP-1923" JIRA issue(s) to rINP16859: Fixes INP-1923 - Display "Server Hostname" in the System Log.
Wed, Sep 3, 11:46 AM
alex closed D539: INP-1923 - Display "Server Hostname" in the System Log.
Wed, Sep 3, 11:46 AM
alex planned changes to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.
Wed, Sep 3, 11:20 AM
alex updated the diff for D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Extracted Arcanist integration into a separate Differential Revision.

Wed, Sep 3, 11:19 AM
alex added "INP-1924" JIRA issue(s) to rINP16858: Fixes INP-1924 - Immediately skip tests, that doesn't work without an Internet….
Wed, Sep 3, 11:09 AM
alex committed rINP16858: Fixes INP-1924 - Immediately skip tests, that doesn't work without an Internet….
Fixes INP-1924 - Immediately skip tests, that doesn't work without an Internet…
Wed, Sep 3, 11:09 AM
alex closed D541: INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection.
Wed, Sep 3, 11:09 AM
alex committed rINP16857: Fixes INP-1900 - Ensure numeric parameter values inside "kUtil::Pounds2Kg"….
Fixes INP-1900 - Ensure numeric parameter values inside "kUtil::Pounds2Kg"…
Wed, Sep 3, 11:03 AM
alex added "INP-1900" JIRA issue(s) to rINP16857: Fixes INP-1900 - Ensure numeric parameter values inside "kUtil::Pounds2Kg"….
Wed, Sep 3, 11:03 AM
alex closed D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Wed, Sep 3, 11:03 AM
erik accepted D541: INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection.
Wed, Sep 3, 10:47 AM
alex accepted D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Wed, Sep 3, 10:17 AM
alex updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Rename test file/class to make Phabricator understand PHPUnit test results/coverage.

Wed, Sep 3, 10:08 AM
alex added a child revision for D540: INP-1925 - Configure PHPUnit integration with Arcanist: D541: INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection.
Wed, Sep 3, 9:57 AM
alex added a parent revision for D541: INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection: D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Wed, Sep 3, 9:57 AM
alex requested review of D541: INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection.
Wed, Sep 3, 9:44 AM
alex committed rINP16856: Fixes INP-1925 - Configure PHPUnit integration with Arcanist.
Fixes INP-1925 - Configure PHPUnit integration with Arcanist
Wed, Sep 3, 9:35 AM
alex added "INP-1925" JIRA issue(s) to rINP16856: Fixes INP-1925 - Configure PHPUnit integration with Arcanist.
Wed, Sep 3, 9:35 AM
alex closed D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Wed, Sep 3, 9:35 AM
erik accepted D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Wed, Sep 3, 9:28 AM
alex updated the test plan for D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Wed, Sep 3, 8:25 AM
alex updated the test plan for D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Wed, Sep 3, 8:19 AM
alex added child revisions for D540: INP-1925 - Configure PHPUnit integration with Arcanist: D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method, D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.
Wed, Sep 3, 8:17 AM
alex added a parent revision for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method: D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Wed, Sep 3, 8:17 AM
alex added a parent revision for D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values: D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Wed, Sep 3, 8:17 AM
alex requested review of D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Wed, Sep 3, 8:15 AM
erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Replaced assertEquels with assertSame in all tests, added in this revision.

Wed, Sep 3, 5:28 AM
alex requested changes to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Wed, Sep 3, 4:14 AM

Tue, Sep 2

erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Added test case when pounds and ounces both are zero.

Tue, Sep 2, 9:09 AM
erik added inline comments to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Tue, Sep 2, 9:05 AM