Corrected phrasing.

Removed debug code from test plan execution attempt.

Error fixed after svn update and clear memory cache.

Yes, when restarting before open index.php, then all is ok

In D501#10225, @erik wrote:

Tests passed, but first time after patch applied need wait long time (2-3 minutes) to get ID shown. Next page refreshes becomes fast (~1 sec).

There happens error, due to this line in the AbstractBrowserTestCase.php

Tests passed, but first time after patch applied need wait long time (2-3 minutes) to get ID shown. Next page refreshes becomes fast (~1 sec).

In D497#10220, @erik wrote:

maybe, test plan should include requirement to have checked "Use Cron to run Scheduled Tasks" - otherwise visible email queue is usually empty.

All tests passed.

In D494#10203, @erik wrote:

All tested, All formal checks passed. But all builds, that has call to selenium - failed with message like.

BUILD FAILED
/home/sites/dev/web/SVN/5.2.x/tools/build/targets/common.xml:216:6: /home/sites/dev/web/SVN/5.2.x/tools/build/targets/common.xml:235:46: Task exited with code 2

Total time: 31.6997 seconds

At selenium window also some errors displayed -

All tested, All formal checks passed. But all builds, that has call to selenium - failed with message like.

In D494#10195, @erik wrote:

Failed build at part 4 after command

phing -f tools/build/build_all.xml phpunit

BUILD FAILED
/home/sites/dev/web/SVN/5.2.x/tools/build/targets/common.xml:192:6: /home/sites/ dev/web/SVN/5.2.x/tools/build/targets/common.xml:205:46: Task exited with code 2

Total time: 6 minutes 42.55 seconds

Same way failed all builds until part 5.7 tests continued, because all formal requirements passed.

Failed build at part 4 after command

phing -f tools/build/build_all.xml phpunit

Removed debug code, that added from test plan.

Speed up code coverage collection 4.25x times by not building coverage report for files, that weren't executed in tests.

1. fixed sh: ${phpunit.testsuite}: bad substitution
2. use proper php binary for executing PHPUnit

Partialy tested, build failed after "run the phing -f tools/build/build_all.xml phpunit command" in the part 4 of test plan

Rebasing.

accepted, detected difference fixed in new patch version

Disabled the EnableSystemLog setting in the Phing-generated /system/config.php.

All passed, excepting last part - config.php comparision.

Reduce scope (set of fields) for which \kDBBase::UpdateFormattersSubFields method is used to prevent accidental data loss.

In D496#10147, @erik wrote:

2 B part ir the test plan is failed. Build was not successful -

BuildException: /home/sites/dev/web/SVN/5.2.x/tools/build/targets/common.xml:84:48: /home/sites/dev/web/SVN/5.2.x/tools/build/targets/common.xml:84:48: PHPLocTask depends on PHPLoc being installed and on include_path. in /home/sites/dev/.config/composer/vendor/phing/phing/classes/phing/tasks/ext/phploc/PHPLocTask.php:189

2 B part ir the test plan is failed. Build was not successful -

New data came in during LIVE testing: the kDBItem::UpdateFormattersSubFields is used too aggressively, which results in clearing already populated date/time virtual fields. Need to adjust code/test plan for that.

In D495#10109, @erik wrote:

Error on Clean install without applying patch

On "Step 8 - Basic Configuration" first page load after previous step.

Notice (#1): Constant EDITING_MODE already defined in \home\sites\dev\web\SVN\5.2.x\core\install\step_templates\post_config.tpl on line 85

Not passed 3 E a part of the plan. Made run of php74 which phing` -f tools/build/build_all.xml build` command.
Command finished with fatal error.

Error on Clean install without applying patch

In D494#10047, @erik wrote:

tested, each test command, containing build_all.xml or build_custom.xml leads to config.php change where HMAC key containing variable ($_CONFIG['Misc']['SecurityHmacKey']) disappears, and then build failed due [InvalidArgumentException] "The HMAC key is empty."

Image with typical console output is attached.

Fixed a typo (used collation instead of collection word).

1. removed support for the utf8mb4_general_ci collection, because you can't even install In-Portal with it due to the ERROR 1071 (42000): Specified key was too long; max key length is 1000 bytes error
2. rephrase invalid collation message to clearly say "what's wrong" instead of saying "what to do next"
3. added explanatory message, that tells to use utfmb3_general_ci for MySQL Server 8.x+ versions

Actualized "/system/config.php", that is created upon build.

Actualized "/system/config.php", that is created upon build.

tested, each test command, containing build_all.xml or build_custom.xml leads to config.php change where HMAC key containing variable ($_CONFIG['Misc']['SecurityHmacKey']) disappears, and then build failed due [InvalidArgumentException] "The HMAC key is empty."

Can't test because of different php version on VM.

In D494#10043, @erik wrote:

No, build was not successful.

[phingcall] /home/sites/dev/web/SVN/5.2.x/tools/build/targets/deploy.xml:37:41: Task exited with code 1

BUILD FAILED
/home/sites/dev/web/SVN/5.2.x/tools/build/targets/deploy.xml:25:6: /home/sites/dev/web/SVN/5.2.x/tools/build/targets/deploy.xml:29:22: Execution of the target buildfile failed. Aborting.

Total time: 29.8418 seconds

No, build was not successful.

In D494#10041, @erik wrote:

Partially tested, tests from part 4 like "confirm, by looking at the colorized output of the above command, that phpunit target was called" - failed. No PHPunit output generated.

Partially tested, tests from part 4 like "confirm, by looking at the colorized output of the above command, that phpunit target was called" - failed. No PHPunit output generated.

Non-obvious Phabricator Differential logic:

• the arc patch command svn mv SVN command (file move) as svn cp (file copy) + svn rm (file removal) commands;
• directory removal, where file move occurred, isn't marked as removed.