Page MenuHomeIn-Portal Phabricator
Feed All Stories

Yesterday

erik accepted D505: INP-1894 - Extract "Change Log" code to a central place.
Fri, May 2, 11:44 AM
erik accepted D514: INP-1822 - Use modern cookie encryption library.
Fri, May 2, 11:40 AM

Wed, Apr 30

erik updated the test plan for D520: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Wed, Apr 30, 6:09 AM
erik requested review of D520: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Wed, Apr 30, 6:09 AM
alex requested changes to D508: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.

Please resubmit from the 5.3.x branch, because an associated Jira task is for the 5.3.x branch as well.

Wed, Apr 30, 4:30 AM

Tue, Apr 29

alex accepted D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Tue, Apr 29, 8:03 AM
alex updated the test plan for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Tue, Apr 29, 8:00 AM
erik accepted D519: INP-1908 - Discard template parser opened output buffers before doing a redirect.
Tue, Apr 29, 8:00 AM
alex requested review of D519: INP-1908 - Discard template parser opened output buffers before doing a redirect.
In D519#10607, @erik wrote:

Part 2 - "confirm, that you're seeing an Admin Console" - no, adding test code to OnLogin prevents from login to the adm.console.

Tue, Apr 29, 7:43 AM
alex updated the test plan for D519: INP-1908 - Discard template parser opened output buffers before doing a redirect.
Tue, Apr 29, 7:42 AM

Fri, Apr 25

erik updated the diff for D512: INP-1902 Populate the "SessionCookieDomains" system setting upon installationI.

Boyscout improvements in session.php

Fri, Apr 25, 11:31 AM

Wed, Apr 16

erik requested changes to D519: INP-1908 - Discard template parser opened output buffers before doing a redirect.

Part 2 - "confirm, that you're seeing an Admin Console" - no, adding test code to OnLogin prevents from login to the adm.console.
Part 3 - "replace the tab URL with the provided URL (text after #redirect#)" - seems, missing some action and/or confirmation after this step ot the test plan

Wed, Apr 16, 5:29 AM

Tue, Apr 15

alex updated the test plan for D519: INP-1908 - Discard template parser opened output buffers before doing a redirect.
Tue, Apr 15, 11:14 AM
alex requested review of D519: INP-1908 - Discard template parser opened output buffers before doing a redirect.
Tue, Apr 15, 11:07 AM
alex added "INP-1906" JIRA issue(s) to rINP16827: Fixes INP-1906 - Execute "customProcessing" method in the "OnDelete" and….
Tue, Apr 15, 3:59 AM
alex committed rINP16827: Fixes INP-1906 - Execute "customProcessing" method in the "OnDelete" and….
Fixes INP-1906 - Execute "customProcessing" method in the "OnDelete" and…
Tue, Apr 15, 3:59 AM
alex closed D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.
Tue, Apr 15, 3:58 AM
alex updated the diff for D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.

Applying the Boyscout Rule principe.

Tue, Apr 15, 3:16 AM
alex accepted D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.
Tue, Apr 15, 3:12 AM

Thu, Apr 10

alex committed rINP16826: Bug INP-1725 - Introduce secure Session Key generation/storage.
Bug INP-1725 - Introduce secure Session Key generation/storage
Thu, Apr 10, 12:55 AM
alex added "INP-1725" JIRA issue(s) to rINP16826: Bug INP-1725 - Introduce secure Session Key generation/storage.
Thu, Apr 10, 12:55 AM
alex added "INP-1725" JIRA issue(s) to rINP16825: Bug INP-1725 - Introduce secure Session Key generation/storage.
Thu, Apr 10, 12:51 AM
alex committed rINP16825: Bug INP-1725 - Introduce secure Session Key generation/storage.
Bug INP-1725 - Introduce secure Session Key generation/storage
Thu, Apr 10, 12:51 AM

Wed, Apr 9

alex added a comment to D518: INP-1907 - Permit file uploads in any Web Browser.
In D518#10578, @erik wrote:

Today I have z-index; 0; in DIV Can't provide screenshot without -index today.

Wed, Apr 9, 6:40 AM
erik added a comment to D518: INP-1907 - Permit file uploads in any Web Browser.

Today I have z-index; 0; in DIV Can't provide screenshot without -index today.

Wed, Apr 9, 6:27 AM
alex updated the test plan for D518: INP-1907 - Permit file uploads in any Web Browser.
Wed, Apr 9, 3:11 AM
alex added a comment to D518: INP-1907 - Permit file uploads in any Web Browser.
In D518#10573, @erik wrote:
Wed, Apr 9, 3:10 AM

Tue, Apr 8

erik accepted D518: INP-1907 - Permit file uploads in any Web Browser.

Part 2 - all right, so revision is accepted.

Tue, Apr 8, 9:27 AM
alex updated the diff for D518: INP-1907 - Permit file uploads in any Web Browser.

Added reference to the used code origins.

Tue, Apr 8, 8:18 AM
alex requested review of D518: INP-1907 - Permit file uploads in any Web Browser.
Tue, Apr 8, 8:15 AM

Apr 3 2025

erik updated the diff for D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.

done all requested code improvements

Apr 3 2025, 6:03 AM
erik updated the test plan for D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.
Apr 3 2025, 6:01 AM
alex added a comment to D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.

Update test plan to cover requested changes as well.

Apr 3 2025, 2:34 AM
alex requested changes to D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.
Apr 3 2025, 2:32 AM
alex updated the test plan for D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.
Apr 3 2025, 2:15 AM

Apr 2 2025

erik updated the test plan for D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.
Apr 2 2025, 6:23 AM
erik requested review of D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.
Apr 2 2025, 6:20 AM

Mar 25 2025

erik accepted D516: INP-1905 - Clear the "Temp Mode" flag after the Temp Table removal from the "OnCancelEdit" event.
Mar 25 2025, 7:57 AM
alex requested review of D516: INP-1905 - Clear the "Temp Mode" flag after the Temp Table removal from the "OnCancelEdit" event.
Mar 25 2025, 7:43 AM

Mar 13 2025

erik accepted D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 13 2025, 12:59 PM
erik accepted D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 13 2025, 11:48 AM
alex requested review of D513: INP-1904 - Support opening an Admin Console from a Site Domain.
In D513#10483, @erik wrote:

Part 3.1.1 login to the Admin Console by accessing it on the sd1.test.domain.com domain over http:// protocol - FAILED, after login attempt - redirect to the login page. SUCCESS after cookies deleted (beyond test plan)
Part 3.1.12 confirm, that orange buttons for editing page/content blocks are now shown - NOT STABLE. At first attempt - no orange buttons. Then I logged in from main domain, set Default theme as primary theme, checked that orange buttons shown, restored Advanced theme as primary theme, then tried again login to sd1 domain, failed, cleared cookies, login to sd1 admin - and only then orange buttons shown

Mar 13 2025, 7:30 AM
alex updated the test plan for D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 13 2025, 7:28 AM
alex updated the test plan for D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 13 2025, 7:28 AM
alex added a parent revision for D513: INP-1904 - Support opening an Admin Console from a Site Domain: D514: INP-1822 - Use modern cookie encryption library.
Mar 13 2025, 7:27 AM
alex added child revisions for D514: INP-1822 - Use modern cookie encryption library: D511: INP-1903 - Disallow opening a website on unsupported domains/protocols, D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 13 2025, 7:27 AM
alex added a parent revision for D511: INP-1903 - Disallow opening a website on unsupported domains/protocols: D514: INP-1822 - Use modern cookie encryption library.
Mar 13 2025, 7:27 AM
alex requested review of D514: INP-1822 - Use modern cookie encryption library.
Mar 13 2025, 7:27 AM
alex requested review of D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 13 2025, 7:03 AM
alex updated the test plan for D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 13 2025, 6:59 AM
alex added a comment to D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
In D511#10453, @erik wrote:

Part 3.2 go to the Configuration → Website → Advanced section - FAILED, can't. login, redirects to login screen. Logged in only after all current site cookies deleted before login.

Mar 13 2025, 6:58 AM
erik requested changes to D513: INP-1904 - Support opening an Admin Console from a Site Domain.

Part 3.1.1 login to the Admin Console by accessing it on the sd1.test.domain.com domain over http:// protocol - FAILED, after login attempt - redirect to the login page. SUCCESS after cookies deleted (beyond test plan)
Part 3.1.12 confirm, that orange buttons for editing page/content blocks are now shown - NOT STABLE. At first attempt - no orange buttons. Then I logged in from main domain, set Default theme as primary theme, checked that orange buttons shown, restored Advanced theme as primary theme, then tried again login to sd1 domain, failed, cleared cookies, login to sd1 admin - and only then orange buttons shown

Mar 13 2025, 6:14 AM
alex updated the diff for D513: INP-1904 - Support opening an Admin Console from a Site Domain.

Added some explanatory comments.

Mar 13 2025, 4:49 AM

Mar 12 2025

alex requested review of D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 12 2025, 1:14 PM
alex added a comment to D513: INP-1904 - Support opening an Admin Console from a Site Domain.
In D513#10467, @erik wrote:

Part 3.1.7 confirm that [SD ID: 1] is added in the current page blur bar (the 1 is site domain ID) - NO, [SD ID: ] is added. And this is right, because at Preparations 10 "add 1st site domain with: Domain Name=sd1-http.test.domain.com", not sd1.test.domain.com
Part 3.1.9 confirm, that you'll see [Site Domain ID: 1] text (the 1 is site domain ID) - NO I see [Site Domain ID: 0]

Mar 12 2025, 1:14 PM
alex updated the test plan for D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 12 2025, 1:12 PM
alex updated the test plan for D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 12 2025, 12:27 PM
alex updated the test plan for D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 12 2025, 12:02 PM
alex updated the test plan for D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 12 2025, 11:39 AM
alex updated the test plan for D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 12 2025, 11:38 AM
alex updated the test plan for D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 12 2025, 11:26 AM
alex updated the test plan for D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 12 2025, 10:51 AM
erik requested changes to D513: INP-1904 - Support opening an Admin Console from a Site Domain.

Part 3.1.7 confirm that [SD ID: 1] is added in the current page blur bar (the 1 is site domain ID) - NO, [SD ID: ] is added. And this is right, because at Preparations 10 "add 1st site domain with: Domain Name=sd1-http.test.domain.com", not sd1.test.domain.com
Part 3.1.9 confirm, that you'll see [Site Domain ID: 1] text (the 1 is site domain ID) - NO I see [Site Domain ID: 0]
Part 3.1.12 logout - FAILED, infinite redirect to http://sd1.test.domain.com/SVN/5.3.x/admin/index.php?env=-index%3Am0--default---&expired=1 happens
Part 3.2.2 confirm that you're looking at Admin Console at the test.domain.com domain over https:// protocol - NO, I'm looking at Admin Console at the sd1.test.domain.com domain over https:// protocol
Part 3.2.3 confirm that [SD ID: 1] is added in the current page blur bar (the 1 is site domain ID) = NO, [SD ID: ] is added in the current page blue bar
Part 3.2.5 confirm, that you'll see [Site Domain ID: 1] text (the 1 is site domain ID) - NO I see [Site Domain ID: 0]
Part 4.2 confirm, that you'll see [Site Domain ID: 1] text (the 1 is site domain ID) - NO I see [Site Domain ID: 0]
Part 4.4 confirm, that you'll see [Site Domain ID: 1] text (the 1 is site domain ID) - NO I see [Site Domain ID: 0]

Mar 12 2025, 10:04 AM
alex added a parent revision for D513: INP-1904 - Support opening an Admin Console from a Site Domain: D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 12 2025, 8:35 AM
alex added a child revision for D511: INP-1903 - Disallow opening a website on unsupported domains/protocols: D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 12 2025, 8:35 AM
alex updated the test plan for D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 12 2025, 8:35 AM
alex requested review of D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 12 2025, 8:33 AM
erik requested changes to D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.

Part 3.2 go to the Configuration → Website → Advanced section - FAILED, can't. login, redirects to login screen. Logged in only after all current site cookies deleted before login.
Part 7.9 confirm, that domain/protocol combo is allowed - NO The "https://front-https.test.domain.com" protocol/domain combo is not allowed.
Part 10.2 login - FAILED, can't. login, redirects to login screen. Logged in only after all current site cookies deleted before login.

Mar 12 2025, 7:48 AM
alex requested review of D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 12 2025, 6:01 AM
alex updated the test plan for D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 12 2025, 6:01 AM
alex updated the diff for D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.

Excluded "site_domain_eh.php" with no changes from the Differential Revision.

Mar 12 2025, 5:55 AM
alex updated the diff for D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.

Restored Browse Mode support when Front-End and Admin Console are using different SSL domains.

Mar 12 2025, 5:43 AM
alex planned changes to D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.

Discovered a bug where Front-End can’t be opened in a Browse Mode if SSL is being used and Front-End and Admin Console are using different SSL domains.

Mar 12 2025, 5:42 AM
alex added a parent revision for D511: INP-1903 - Disallow opening a website on unsupported domains/protocols: D283: INP-1666 - Move "EDITING_MODE" constant definition to "adm:OnStartup" event hook.
Mar 12 2025, 3:54 AM
alex added a child revision for D283: INP-1666 - Move "EDITING_MODE" constant definition to "adm:OnStartup" event hook: D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 12 2025, 3:54 AM · Restricted Project

Mar 10 2025

erik updated the test plan for D512: INP-1902 Populate the "SessionCookieDomains" system setting upon installationI.
Mar 10 2025, 10:16 AM
erik requested review of D512: INP-1902 Populate the "SessionCookieDomains" system setting upon installationI.
Mar 10 2025, 10:14 AM
erik accepted D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 10 2025, 6:38 AM
alex requested review of D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.

Updated test plan. Please retest.

Mar 10 2025, 5:36 AM
alex added a comment to D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
In D511#10419, @erik wrote:

All tested, there is list of possible differences from test plan expectations.

Part 2.7 confirm you stayed on the admin1-https.test.domain.com domain and http:// protocol - NO, STAYED ON same domain/protocol test.domain.com

Mar 10 2025, 5:35 AM
alex updated the test plan for D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 10 2025, 5:34 AM

Mar 6 2025

erik requested changes to D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.

All tested, there is list of possible differences from test plan expectations.

Mar 6 2025, 6:27 AM

Mar 5 2025

alex updated the test plan for D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 5 2025, 10:33 AM
alex updated the test plan for D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 5 2025, 10:31 AM
alex requested review of D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 5 2025, 10:29 AM

Feb 10 2025

erik updated the test plan for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Feb 10 2025, 4:58 AM
erik requested review of D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Feb 10 2025, 4:55 AM

Feb 5 2025

erik updated the test plan for D508: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Feb 5 2025, 5:02 AM
erik updated the test plan for D508: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Feb 5 2025, 5:00 AM
erik updated the test plan for D508: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Feb 5 2025, 4:59 AM
erik requested review of D508: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Feb 5 2025, 4:58 AM
erik updated the test plan for D507: INP-1899 Preserve original formatting of multi-line error messages/exceptions in Debugger.
Feb 5 2025, 4:43 AM
erik updated the test plan for D507: INP-1899 Preserve original formatting of multi-line error messages/exceptions in Debugger.
Feb 5 2025, 4:42 AM
erik requested review of D507: INP-1899 Preserve original formatting of multi-line error messages/exceptions in Debugger.
Feb 5 2025, 4:40 AM

Jan 29 2025

alex updated the test plan for D506: INP-1895 Ensure consistent return type of the "kTempTablesHandler::CloneItems" method.
Jan 29 2025, 10:59 AM
erik updated the test plan for D506: INP-1895 Ensure consistent return type of the "kTempTablesHandler::CloneItems" method.
Jan 29 2025, 10:28 AM
erik updated the test plan for D506: INP-1895 Ensure consistent return type of the "kTempTablesHandler::CloneItems" method.
Jan 29 2025, 10:26 AM
erik requested review of D506: INP-1895 Ensure consistent return type of the "kTempTablesHandler::CloneItems" method.
Jan 29 2025, 10:24 AM
alex updated the diff for D503: INP-1893 Denormalize "ChangeLogs" database table.

Ensure new identical field order in both unit config and database table.

Jan 29 2025, 6:29 AM
alex updated the diff for D503: INP-1893 Denormalize "ChangeLogs" database table.
  1. extract "\ChangeLogHelper::getUserFields" from the "\ChangeLogHelper::getAddFields" for easier customization
  2. change cache key of the \ChangeLogHelper::getAddFields method to include also session_id
Jan 29 2025, 6:21 AM