Page MenuHomeIn-Portal Phabricator
Feed All Stories

Today

erik added a comment to D494: INP-1863 - Correct PHPUnit integration.

tested, each test command, containing build_all.xml or build_custom.xml leads to config.php change where HMAC key containing variable ($_CONFIG['Misc']['SecurityHmacKey']) disappears, and then build failed due [InvalidArgumentException] "The HMAC key is empty."

Tue, Nov 12, 10:21 AM
erik added a comment to D494: INP-1863 - Correct PHPUnit integration.

Can't test because of different php version on VM.

Tue, Nov 12, 4:36 AM

Yesterday

alex added a comment to D494: INP-1863 - Correct PHPUnit integration.
In D494#10043, @erik wrote:

No, build was not successful.

[phingcall] /home/sites/dev/web/SVN/5.2.x/tools/build/targets/deploy.xml:37:41: Task exited with code 1

BUILD FAILED
/home/sites/dev/web/SVN/5.2.x/tools/build/targets/deploy.xml:25:6: /home/sites/dev/web/SVN/5.2.x/tools/build/targets/deploy.xml:29:22: Execution of the target buildfile failed. Aborting.

Total time: 29.8418 seconds

Mon, Nov 11, 11:22 AM
alex updated the test plan for D494: INP-1863 - Correct PHPUnit integration.
Mon, Nov 11, 11:20 AM
erik added a comment to D494: INP-1863 - Correct PHPUnit integration.

No, build was not successful.

Mon, Nov 11, 8:50 AM
alex added a comment to D494: INP-1863 - Correct PHPUnit integration.
In D494#10041, @erik wrote:

Partially tested, tests from part 4 like "confirm, by looking at the colorized output of the above command, that phpunit target was called" - failed. No PHPunit output generated.

Mon, Nov 11, 8:47 AM
erik added a comment to D494: INP-1863 - Correct PHPUnit integration.

Partially tested, tests from part 4 like "confirm, by looking at the colorized output of the above command, that phpunit target was called" - failed. No PHPunit output generated.

Mon, Nov 11, 8:42 AM

Sat, Nov 9

alex added a comment to D494: INP-1863 - Correct PHPUnit integration.

Non-obvious Phabricator Differential logic:

  • the arc patch command svn mv SVN command (file move) as svn cp (file copy) + svn rm (file removal) commands;
  • directory removal, where file move occurred, isn't marked as removed.
Sat, Nov 9, 9:17 AM
alex updated the summary of D494: INP-1863 - Correct PHPUnit integration.
Sat, Nov 9, 9:16 AM
alex updated the summary of D494: INP-1863 - Correct PHPUnit integration.
Sat, Nov 9, 9:16 AM
alex updated the test plan for D494: INP-1863 - Correct PHPUnit integration.
Sat, Nov 9, 9:11 AM
alex updated the diff for D494: INP-1863 - Correct PHPUnit integration.

Same diff, but file moves in "modules/custom" folder are displayed correctly.

Sat, Nov 9, 8:51 AM

Fri, Nov 8

alex updated the test plan for D494: INP-1863 - Correct PHPUnit integration.
Fri, Nov 8, 1:49 PM
alex updated the diff for D494: INP-1863 - Correct PHPUnit integration.

Included moved files, that were missing in original diff.

Fri, Nov 8, 1:34 PM
alex updated the diff for D494: INP-1863 - Correct PHPUnit integration.
  1. Updating D494: INP-1863 - Correct PHPUnit integration #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. Included changes:
  5. M composer.json
  6. M composer.lock
  7. M core/kernel/application.php
  8. V core/tests/AbstractTestCase.php to: core/tests/Unit/AbstractTestCase.php
  9. V core/tests/Unit/AbstractTestCase.php from: core/tests/AbstractTestCase.php
  10. V core/tests/Unit/kernel/utility/formatters/kFormatterTest.php from: core/tests/kernel/utility/formatters/kFormatterTest.php
  11. V core/tests/kernel/utility/formatters/kFormatterTest.php to: core/tests/Unit/kernel/utility/formatters/kFormatterTest.php
Fri, Nov 8, 1:20 PM
alex requested review of D494: INP-1863 - Correct PHPUnit integration.
Fri, Nov 8, 1:11 PM

Thu, Oct 31

alex added "INP-1827" JIRA issue(s) to rINP16818: Bug INP-1827 - Connect a testing framework.
Thu, Oct 31, 4:52 AM
alex committed rINP16818: Bug INP-1827 - Connect a testing framework.
Bug INP-1827 - Connect a testing framework
Thu, Oct 31, 4:52 AM

Wed, Oct 30

alex added "INP-1881" JIRA issue(s) to rINP16817: Fixes INP-1881 - Change default Debugger URL handler to PhpStorm.
Wed, Oct 30, 7:56 AM
alex committed rINP16817: Fixes INP-1881 - Change default Debugger URL handler to PhpStorm.
Fixes INP-1881 - Change default Debugger URL handler to PhpStorm
Wed, Oct 30, 7:56 AM
alex closed D493: INP-1881 - Change default Debugger URL handler to PhpStorm.
Wed, Oct 30, 7:56 AM
alex added "INP-1883" JIRA issue(s) to rINP16816: Merge (5.3.x > 5.2.x): * [backported] Fixes INP-1883 - Rework URL-encoding in….
Wed, Oct 30, 7:54 AM
alex committed rINP16816: Merge (5.3.x > 5.2.x): * [backported] Fixes INP-1883 - Rework URL-encoding in….
Merge (5.3.x > 5.2.x): * [backported] Fixes INP-1883 - Rework URL-encoding in…
Wed, Oct 30, 7:53 AM
erik accepted D493: INP-1881 - Change default Debugger URL handler to PhpStorm.
Wed, Oct 30, 6:02 AM

Tue, Oct 29

alex added "INP-1882" JIRA issue(s) to rINP16815: Fixes INP-1882 - Rework URL-encoding in Debugger Report file URLs.
Tue, Oct 29, 3:52 AM
alex committed rINP16815: Fixes INP-1882 - Rework URL-encoding in Debugger Report file URLs.
Fixes INP-1882 - Rework URL-encoding in Debugger Report file URLs
Tue, Oct 29, 3:52 AM
alex closed D492: INP-1882 - Rework URL-encoding in Debugger Report file URLs.
Tue, Oct 29, 3:52 AM

Mon, Oct 28

erik accepted D492: INP-1882 - Rework URL-encoding in Debugger Report file URLs.
Mon, Oct 28, 9:17 AM
alex requested review of D492: INP-1882 - Rework URL-encoding in Debugger Report file URLs.

Test plan updated.

Mon, Oct 28, 9:15 AM
alex updated the test plan for D492: INP-1882 - Rework URL-encoding in Debugger Report file URLs.
Mon, Oct 28, 9:15 AM
alex planned changes to D492: INP-1882 - Rework URL-encoding in Debugger Report file URLs.
In D492#9995, @erik wrote:

Part 1 - microsoft do not support such links as 'file://' (security issue), so browser does not decode it properly. Result is like "file:///" in the FireFox browser. {F669820}And like 'about:blank#blocked' when trying follow this link in the Chrome browser.

Mon, Oct 28, 9:13 AM
erik requested changes to D492: INP-1882 - Rework URL-encoding in Debugger Report file URLs.

Part 1 - microsoft do not support such links as 'file://' (security issue), so browser does not decode it properly. Result is like "file:///" in the FireFox browser. {F669820}And like 'about:blank#blocked' when trying follow this link in the Chrome browser.

Mon, Oct 28, 7:08 AM
alex added "INP-1872" JIRA issue(s) to rINP16814: Fixes INP-1872 - Properly handle constant absence during category cache rebuild.
Mon, Oct 28, 6:26 AM
alex committed rINP16814: Fixes INP-1872 - Properly handle constant absence during category cache rebuild.
Fixes INP-1872 - Properly handle constant absence during category cache rebuild
Mon, Oct 28, 6:26 AM
alex closed D480: INP-1872 - Properly handle constant absence during category cache rebuild.
Mon, Oct 28, 6:26 AM · Restricted Project
alex added "INP-1725" JIRA issue(s) to rINP16813: Bug INP-1725 - Introduce secure Session Key generation/storage.
Mon, Oct 28, 6:21 AM
alex committed rINP16813: Bug INP-1725 - Introduce secure Session Key generation/storage.
Bug INP-1725 - Introduce secure Session Key generation/storage
Mon, Oct 28, 6:21 AM
erik accepted D480: INP-1872 - Properly handle constant absence during category cache rebuild.

All right, when debugger is off. When debugger os on - got about 20 "Trying to access array offset on value of type bool" notices

Mon, Oct 28, 5:20 AM · Restricted Project

Sat, Oct 26

alex requested review of D480: INP-1872 - Properly handle constant absence during category cache rebuild.
Sat, Oct 26, 9:51 AM · Restricted Project
alex planned changes to D480: INP-1872 - Properly handle constant absence during category cache rebuild.
Sat, Oct 26, 9:51 AM · Restricted Project
alex added a comment to D480: INP-1872 - Properly handle constant absence during category cache rebuild.
In D480#9710, @erik wrote:

System log errors exists, but, seems, not related to the current patch. Equal errors count with patch and without patch.

All errors are

Sat, Oct 26, 9:50 AM · Restricted Project
alex updated the test plan for D492: INP-1882 - Rework URL-encoding in Debugger Report file URLs.
Sat, Oct 26, 9:50 AM
alex updated the test plan for D493: INP-1881 - Change default Debugger URL handler to PhpStorm.
Sat, Oct 26, 9:47 AM
alex requested review of D493: INP-1881 - Change default Debugger URL handler to PhpStorm.
Sat, Oct 26, 9:27 AM
alex added parent revisions for D492: INP-1882 - Rework URL-encoding in Debugger Report file URLs: D113: INP-1463 - Use "http_build_query" for file editing link building, D136: INP-1483 - Use "path" in from DBG_EDITOR_URL constant only when available.
Sat, Oct 26, 9:03 AM
alex added a child revision for D113: INP-1463 - Use "http_build_query" for file editing link building: D492: INP-1882 - Rework URL-encoding in Debugger Report file URLs.
Sat, Oct 26, 9:03 AM
alex added a child revision for D136: INP-1483 - Use "path" in from DBG_EDITOR_URL constant only when available: D492: INP-1882 - Rework URL-encoding in Debugger Report file URLs.
Sat, Oct 26, 9:03 AM
alex updated the summary of D492: INP-1882 - Rework URL-encoding in Debugger Report file URLs.
Sat, Oct 26, 8:57 AM
alex requested review of D492: INP-1882 - Rework URL-encoding in Debugger Report file URLs.
Sat, Oct 26, 8:37 AM

Wed, Oct 23

alex added a project to D491: INP-1880 - Fix notice on missing event permission mapping: Restricted Project.
Wed, Oct 23, 8:29 AM · Restricted Project
alex requested review of D491: INP-1880 - Fix notice on missing event permission mapping.
Wed, Oct 23, 8:28 AM · Restricted Project

Sun, Oct 20

alex added "MINC-202" JIRA issue(s) to rMINC16812: Fixes MINC-202 - Fix currency selection in Site Domain scenario.
Sun, Oct 20, 1:43 PM
alex committed rMINC16812: Fixes MINC-202 - Fix currency selection in Site Domain scenario.
Fixes MINC-202 - Fix currency selection in Site Domain scenario
Sun, Oct 20, 1:42 PM
alex closed D474: MINC-202 - Fix currency selection in Site Domain scenario.
Sun, Oct 20, 1:42 PM
alex added "INP-1858" JIRA issue(s) to rMINN16811: Bug INP-1858 - HTML-escape data in Admin Console grids.
Sun, Oct 20, 1:39 PM
alex committed rMINN16811: Bug INP-1858 - HTML-escape data in Admin Console grids.
Bug INP-1858 - HTML-escape data in Admin Console grids
Sun, Oct 20, 1:39 PM
alex added "INP-1858" JIRA issue(s) to rMINL16810: Bug INP-1858 - HTML-escape data in Admin Console grids.
Sun, Oct 20, 1:38 PM
alex committed rMINL16810: Bug INP-1858 - HTML-escape data in Admin Console grids.
Bug INP-1858 - HTML-escape data in Admin Console grids
Sun, Oct 20, 1:38 PM
alex added "INP-1858" JIRA issue(s) to rMINC16809: Bug INP-1858 - HTML-escape data in Admin Console grids.
Sun, Oct 20, 1:38 PM
alex committed rMINC16809: Bug INP-1858 - HTML-escape data in Admin Console grids.
Bug INP-1858 - HTML-escape data in Admin Console grids
Sun, Oct 20, 1:38 PM
alex committed rMINB16808: Bug INP-1858 - HTML-escape data in Admin Console grids.
Bug INP-1858 - HTML-escape data in Admin Console grids
Sun, Oct 20, 1:37 PM
alex added "INP-1858" JIRA issue(s) to rMINB16808: Bug INP-1858 - HTML-escape data in Admin Console grids.
Sun, Oct 20, 1:37 PM
alex added "INP-1858" JIRA issue(s) to rINP16807: Fixes INP-1858 - HTML-escape data in Admin Console grids.
Sun, Oct 20, 1:36 PM
alex committed rINP16807: Fixes INP-1858 - HTML-escape data in Admin Console grids.
Fixes INP-1858 - HTML-escape data in Admin Console grids
Sun, Oct 20, 1:36 PM
alex added "INP-1857" JIRA issue(s) to rINP16806: Fixes INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
Sun, Oct 20, 1:26 PM
alex committed rINP16806: Fixes INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
Fixes INP-1857 - Prevent recursion in the "\kUrlManager::show404" method
Sun, Oct 20, 1:26 PM
alex closed D462: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
Sun, Oct 20, 1:26 PM · Restricted Project
alex added "INP-1856" JIRA issue(s) to rMINC16805: Bug INP-1856 - Make cookies unavailable via the "kApplication::GetVar" calls.
Sun, Oct 20, 1:20 PM
alex committed rMINC16805: Bug INP-1856 - Make cookies unavailable via the "kApplication::GetVar" calls.
Bug INP-1856 - Make cookies unavailable via the "kApplication::GetVar" calls
Sun, Oct 20, 1:20 PM
alex committed rINP16804: Fixes INP-1856 - Make cookies unavailable via the "kApplication::GetVar" calls.
Fixes INP-1856 - Make cookies unavailable via the "kApplication::GetVar" calls
Sun, Oct 20, 1:20 PM
alex added "INP-1856" JIRA issue(s) to rINP16804: Fixes INP-1856 - Make cookies unavailable via the "kApplication::GetVar" calls.
Sun, Oct 20, 1:20 PM
alex added "INP-1851" JIRA issue(s) to rINP16803: Fixes INP-1851 - Log file upload meta-information as part of the Request Data.
Sun, Oct 20, 1:10 PM
alex committed rINP16803: Fixes INP-1851 - Log file upload meta-information as part of the Request Data.
Fixes INP-1851 - Log file upload meta-information as part of the Request Data
Sun, Oct 20, 1:10 PM
alex closed D457: INP-1851 - Log file upload meta-information as part of the Request Data.
Sun, Oct 20, 1:10 PM · Restricted Project
alex retitled D457: INP-1851 - Log file upload meta-information as part of the Request Data from INP-1851 - Log file upload meta-infomation as part of the Request Data to INP-1851 - Log file upload meta-information as part of the Request Data.
Sun, Oct 20, 1:09 PM · Restricted Project
alex added "INP-1849" JIRA issue(s) to rINP16802: Fixes INP-1849 - Ignore non-string Mod-Rewrite URL during URL parsing.
Sun, Oct 20, 1:05 PM
alex committed rINP16802: Fixes INP-1849 - Ignore non-string Mod-Rewrite URL during URL parsing.
Fixes INP-1849 - Ignore non-string Mod-Rewrite URL during URL parsing
Sun, Oct 20, 1:05 PM
alex added "INP-1846" JIRA issue(s) to rINP16801: Fixes INP-1846 - Escape Request URI in the System Log.
Sun, Oct 20, 8:39 AM
alex committed rINP16801: Fixes INP-1846 - Escape Request URI in the System Log.
Fixes INP-1846 - Escape Request URI in the System Log
Sun, Oct 20, 8:39 AM

Sat, Oct 19

alex added "INP-1758", "INP-1827", "INP-1829", "INP-1834", "INP-1869", "INP-1879" JIRA issue(s) to rINP16800: Merging from 5.2.x to 5.3.x.
Sat, Oct 19, 2:55 PM
alex committed rINP16800: Merging from 5.2.x to 5.3.x.
Merging from 5.2.x to 5.3.x
Sat, Oct 19, 2:55 PM

Wed, Oct 16

alex added "INP-1879" JIRA issue(s) to rINP16799: Fixes INP-1879 - Adjust Phabricator URL to use SSL.
Wed, Oct 16, 12:41 PM
alex committed rINP16799: Fixes INP-1879 - Adjust Phabricator URL to use SSL.
Fixes INP-1879 - Adjust Phabricator URL to use SSL
Wed, Oct 16, 12:41 PM
alex closed D490: INP-1879 - Adjust Phabricator URL to use SSL.
Wed, Oct 16, 12:41 PM
erik accepted D490: INP-1879 - Adjust Phabricator URL to use SSL.
Wed, Oct 16, 12:30 PM
alex updated the test plan for D490: INP-1879 - Adjust Phabricator URL to use SSL.
Wed, Oct 16, 12:27 PM
alex added a parent revision for D490: INP-1879 - Adjust Phabricator URL to use SSL: D20: INP-1390 - Create Phabricator configuration file.
Wed, Oct 16, 12:25 PM
alex added a child revision for D20: INP-1390 - Create Phabricator configuration file: D490: INP-1879 - Adjust Phabricator URL to use SSL.
Wed, Oct 16, 12:25 PM
alex requested review of D490: INP-1879 - Adjust Phabricator URL to use SSL.
Wed, Oct 16, 12:23 PM
erik accepted D489: INP-1878 - Add support for the WEBP format.
Wed, Oct 16, 8:05 AM · Restricted Project
alex added a project to D489: INP-1878 - Add support for the WEBP format: Restricted Project.
Wed, Oct 16, 7:41 AM · Restricted Project
alex requested review of D489: INP-1878 - Add support for the WEBP format.
Wed, Oct 16, 7:31 AM · Restricted Project

Tue, Oct 15

erik accepted D487: INP-1877 - Check meta-permissions for "root" user.
Tue, Oct 15, 10:54 AM
alex requested review of D487: INP-1877 - Check meta-permissions for "root" user.

Please retest (the test plan was improved).

Tue, Oct 15, 8:16 AM
alex updated the diff for D487: INP-1877 - Check meta-permissions for "root" user.

Cosmetic comment fixes.

Tue, Oct 15, 8:16 AM
alex updated the diff for D487: INP-1877 - Check meta-permissions for "root" user.

Fix for an exception on the configuration section for the "root" user.

Tue, Oct 15, 8:16 AM
alex planned changes to D487: INP-1877 - Check meta-permissions for "root" user.

When root opens a configuration section an exception is thrown:

Exception: Permission section not specified for prefix conf in ...\core\kernel\utility\event.php on line 439
Tue, Oct 15, 8:16 AM
alex updated the test plan for D487: INP-1877 - Check meta-permissions for "root" user.
Tue, Oct 15, 8:16 AM

Oct 8 2024

erik accepted D487: INP-1877 - Check meta-permissions for "root" user.
Oct 8 2024, 10:37 AM
alex requested review of D487: INP-1877 - Check meta-permissions for "root" user.

Updated test plan.

Oct 8 2024, 10:19 AM