Page MenuHomeIn-Portal Phabricator
Feed All Stories

Thu, Sep 4

alex added "INP-1926" JIRA issue(s) to rINP16860: Fixes INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Thu, Sep 4, 7:29 AM
alex committed rINP16860: Fixes INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Fixes INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log
Thu, Sep 4, 7:29 AM
alex closed D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Thu, Sep 4, 7:29 AM
erik accepted D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Thu, Sep 4, 6:28 AM
alex updated the diff for D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.

Use "la_fld_LogServerHostname" phrases (existing) instead of "la_fld_ServerHostname" (non-existing) in the Session Log grid.

Thu, Sep 4, 5:57 AM
erik requested changes to D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.

In the D539 added another phrase. Phrase la_fld_ServerHostname is detected as missing during tests.

Thu, Sep 4, 5:12 AM
alex requested review of D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
In D542#11101, @erik wrote:

All by test plan is ok, but missing phrase for "Server Hostname" field (Session log grid column title).

Thu, Sep 4, 2:24 AM
alex updated the test plan for D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Thu, Sep 4, 2:18 AM

Wed, Sep 3

erik requested changes to D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.

All by test plan is ok, but missing phrase for "Server Hostname" field (Session log grid column title).

Wed, Sep 3, 12:25 PM
alex added a parent revision for D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log: D539: INP-1923 - Display "Server Hostname" in the System Log.
Wed, Sep 3, 11:52 AM
alex added a child revision for D539: INP-1923 - Display "Server Hostname" in the System Log: D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Wed, Sep 3, 11:52 AM
alex requested review of D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.
Wed, Sep 3, 11:51 AM
alex committed rINP16859: Fixes INP-1923 - Display "Server Hostname" in the System Log.
Fixes INP-1923 - Display "Server Hostname" in the System Log
Wed, Sep 3, 11:46 AM
alex added "INP-1923" JIRA issue(s) to rINP16859: Fixes INP-1923 - Display "Server Hostname" in the System Log.
Wed, Sep 3, 11:46 AM
alex closed D539: INP-1923 - Display "Server Hostname" in the System Log.
Wed, Sep 3, 11:46 AM
alex planned changes to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.
Wed, Sep 3, 11:20 AM
alex updated the diff for D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Extracted Arcanist integration into a separate Differential Revision.

Wed, Sep 3, 11:19 AM
alex added "INP-1924" JIRA issue(s) to rINP16858: Fixes INP-1924 - Immediately skip tests, that doesn't work without an Internet….
Wed, Sep 3, 11:09 AM
alex committed rINP16858: Fixes INP-1924 - Immediately skip tests, that doesn't work without an Internet….
Fixes INP-1924 - Immediately skip tests, that doesn't work without an Internet…
Wed, Sep 3, 11:09 AM
alex closed D541: INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection.
Wed, Sep 3, 11:09 AM
alex committed rINP16857: Fixes INP-1900 - Ensure numeric parameter values inside "kUtil::Pounds2Kg"….
Fixes INP-1900 - Ensure numeric parameter values inside "kUtil::Pounds2Kg"…
Wed, Sep 3, 11:03 AM
alex added "INP-1900" JIRA issue(s) to rINP16857: Fixes INP-1900 - Ensure numeric parameter values inside "kUtil::Pounds2Kg"….
Wed, Sep 3, 11:03 AM
alex closed D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Wed, Sep 3, 11:03 AM
erik accepted D541: INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection.
Wed, Sep 3, 10:47 AM
alex accepted D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Wed, Sep 3, 10:17 AM
alex updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Rename test file/class to make Phabricator understand PHPUnit test results/coverage.

Wed, Sep 3, 10:08 AM
alex added a child revision for D540: INP-1925 - Configure PHPUnit integration with Arcanist: D541: INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection.
Wed, Sep 3, 9:57 AM
alex added a parent revision for D541: INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection: D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Wed, Sep 3, 9:57 AM
alex requested review of D541: INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection.
Wed, Sep 3, 9:44 AM
alex committed rINP16856: Fixes INP-1925 - Configure PHPUnit integration with Arcanist.
Fixes INP-1925 - Configure PHPUnit integration with Arcanist
Wed, Sep 3, 9:35 AM
alex added "INP-1925" JIRA issue(s) to rINP16856: Fixes INP-1925 - Configure PHPUnit integration with Arcanist.
Wed, Sep 3, 9:35 AM
alex closed D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Wed, Sep 3, 9:35 AM
erik accepted D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Wed, Sep 3, 9:28 AM
alex updated the test plan for D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Wed, Sep 3, 8:25 AM
alex updated the test plan for D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Wed, Sep 3, 8:19 AM
alex added child revisions for D540: INP-1925 - Configure PHPUnit integration with Arcanist: D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method, D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.
Wed, Sep 3, 8:17 AM
alex added a parent revision for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method: D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Wed, Sep 3, 8:17 AM
alex added a parent revision for D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values: D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Wed, Sep 3, 8:17 AM
alex requested review of D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Wed, Sep 3, 8:15 AM
erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Replaced assertEquels with assertSame in all tests, added in this revision.

Wed, Sep 3, 5:28 AM
alex requested changes to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Wed, Sep 3, 4:14 AM

Tue, Sep 2

erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Added test case when pounds and ounces both are zero.

Tue, Sep 2, 9:09 AM
erik added inline comments to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Tue, Sep 2, 9:05 AM
alex requested changes to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Tue, Sep 2, 8:02 AM
erik updated the test plan for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Tue, Sep 2, 7:37 AM
erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Made all requested fixes. Created tests for kUbitFormatter class.

Tue, Sep 2, 7:33 AM
alex requested changes to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Also try to modify tested code to confirm, that related tests would fail.

Tue, Sep 2, 5:33 AM
erik accepted D539: INP-1923 - Display "Server Hostname" in the System Log.
Tue, Sep 2, 5:23 AM

Mon, Sep 1

erik updated the test plan for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Mon, Sep 1, 1:38 PM
erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Changed ligic, added unit tests.

Mon, Sep 1, 1:33 PM
alex requested review of D539: INP-1923 - Display "Server Hostname" in the System Log.
Mon, Sep 1, 7:05 AM
alex requested changes to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Let's implement this the other way around (sender does type casting, but recipient throws an exception on error on any PHP version):

Mon, Sep 1, 3:46 AM

Sun, Aug 31

alex added "INP-1874" JIRA issue(s) to rINP16855: Fixes INP-1874 - Sanitize $_SERVER['PHP_SELF'] value.
Sun, Aug 31, 12:18 PM
alex committed rINP16855: Fixes INP-1874 - Sanitize $_SERVER['PHP_SELF'] value.
Fixes INP-1874 - Sanitize $_SERVER['PHP_SELF'] value
Sun, Aug 31, 12:18 PM
alex added "INP-1876" JIRA issue(s) to rINP16854: Fixes INP-1876 - Verify system settings access permissions before allowing to….
Sun, Aug 31, 12:15 PM
alex committed rINP16854: Fixes INP-1876 - Verify system settings access permissions before allowing to….
Fixes INP-1876 - Verify system settings access permissions before allowing to…
Sun, Aug 31, 12:15 PM
alex closed D486: INP-1876 - Verify system settings access permissions before allowing to change them.
Sun, Aug 31, 12:15 PM · Restricted Project
alex added "INP-1880" JIRA issue(s) to rINP16853: Fixes INP-1880 - Fix notice on missing event permission mapping.
Sun, Aug 31, 12:09 PM
alex committed rINP16853: Fixes INP-1880 - Fix notice on missing event permission mapping.
Fixes INP-1880 - Fix notice on missing event permission mapping
Sun, Aug 31, 12:09 PM
alex closed D491: INP-1880 - Fix notice on missing event permission mapping.
Sun, Aug 31, 12:09 PM · Restricted Project
alex added "INP-1887" JIRA issue(s) to rINP16852: Fixes INP-1887 - Don't define the "EDITING_MODE" constant in the Installation….
Sun, Aug 31, 12:06 PM
alex committed rINP16852: Fixes INP-1887 - Don't define the "EDITING_MODE" constant in the Installation….
Fixes INP-1887 - Don't define the "EDITING_MODE" constant in the Installation…
Sun, Aug 31, 12:06 PM
alex closed D498: INP-1887 - Don't define the "EDITING_MODE" constant in the Installation Wizard.
Sun, Aug 31, 12:06 PM
alex added "INP-1888" JIRA issue(s) to rINP16851: Fixes INP-1888 - Detect Memcache availability during installation using….
Sun, Aug 31, 12:05 PM
alex committed rINP16851: Fixes INP-1888 - Detect Memcache availability during installation using….
Fixes INP-1888 - Detect Memcache availability during installation using…
Sun, Aug 31, 12:05 PM
alex closed D499: INP-1888 - Detect Memcache availability during installation using Memcache/Memcached PHP modules.
Sun, Aug 31, 12:05 PM
alex committed rINP16850: Fixes INP-1889 - Don't use DB Load Balancer during PHPUnit Testing.
Fixes INP-1889 - Don't use DB Load Balancer during PHPUnit Testing
Sun, Aug 31, 12:02 PM
alex added "INP-1889" JIRA issue(s) to rINP16850: Fixes INP-1889 - Don't use DB Load Balancer during PHPUnit Testing.
Sun, Aug 31, 12:02 PM
alex closed D500: INP-1889 - Don't use DB Load Balancer during PHPUnit Testing.
Sun, Aug 31, 12:02 PM
alex added "INP-1891" JIRA issue(s) to rINP16849: Fixes INP-1891 - Display PHP errors in the Phing build log.
Sun, Aug 31, 12:01 PM
alex committed rINP16849: Fixes INP-1891 - Display PHP errors in the Phing build log.
Fixes INP-1891 - Display PHP errors in the Phing build log
Sun, Aug 31, 12:01 PM
alex closed D502: INP-1891 - Display PHP errors in the Phing build log.
Sun, Aug 31, 12:01 PM
alex added "INP-1894" JIRA issue(s) to rINP16848: Bug INP-1894 - Extract "Change Log" code to a central place.
Sun, Aug 31, 11:58 AM
alex committed rINP16848: Bug INP-1894 - Extract "Change Log" code to a central place.
Bug INP-1894 - Extract "Change Log" code to a central place
Sun, Aug 31, 11:58 AM
alex closed D505: INP-1894 - Extract "Change Log" code to a central place.
Sun, Aug 31, 11:58 AM
alex added "INP-1905" JIRA issue(s) to rINP16847: Fixes INP-1905 - Clear the "Temp Mode" flag after the Temp Table removal from….
Sun, Aug 31, 11:56 AM
alex committed rINP16847: Fixes INP-1905 - Clear the "Temp Mode" flag after the Temp Table removal from….
Fixes INP-1905 - Clear the "Temp Mode" flag after the Temp Table removal from…
Sun, Aug 31, 11:56 AM
alex closed D516: INP-1905 - Clear the "Temp Mode" flag after the Temp Table removal from the "OnCancelEdit" event.
Sun, Aug 31, 11:56 AM
alex added "INP-1908" JIRA issue(s) to rINP16846: Fixes INP-1908 - Discard template parser opened output buffers before doing a….
Sun, Aug 31, 11:45 AM
alex committed rINP16846: Fixes INP-1908 - Discard template parser opened output buffers before doing a….
Fixes INP-1908 - Discard template parser opened output buffers before doing a…
Sun, Aug 31, 11:45 AM
alex closed D519: INP-1908 - Discard template parser opened output buffers before doing a redirect.
Sun, Aug 31, 11:45 AM
alex added "INP-1910" JIRA issue(s) to rINP16845: Fixes INP-1910 - Allow specifying upcoming System Log record defaults.
Sun, Aug 31, 11:43 AM
alex committed rINP16845: Fixes INP-1910 - Allow specifying upcoming System Log record defaults.
Fixes INP-1910 - Allow specifying upcoming System Log record defaults
Sun, Aug 31, 11:43 AM
alex closed D521: INP-1910 - Allow specifying upcoming System Log record defaults.
Sun, Aug 31, 11:43 AM
alex added "MINC-210" JIRA issue(s) to rMINC16844: Fixes MINC-210 - Repair Downloadable products file downloads on the Front-End.
Sun, Aug 31, 11:39 AM
alex committed rMINC16844: Fixes MINC-210 - Repair Downloadable products file downloads on the Front-End.
Fixes MINC-210 - Repair Downloadable products file downloads on the Front-End
Sun, Aug 31, 11:39 AM
alex closed D530: MINC-210 - Repair Downloadable products file downloads on the Front-End.
Sun, Aug 31, 11:39 AM
alex added "INP-1853" JIRA issue(s) to rINP16843: Fixes INP-1853 - Use the "\kUtil::varDumpColorized" method in the System Log….
Sun, Aug 31, 11:33 AM
alex committed rINP16843: Fixes INP-1853 - Use the "\kUtil::varDumpColorized" method in the System Log….
Fixes INP-1853 - Use the "\kUtil::varDumpColorized" method in the System Log…
Sun, Aug 31, 11:33 AM
alex closed D459: INP-1853 - Use the "\kUtil::varDumpColorized" method in the System Log Web UI.
Sun, Aug 31, 11:33 AM
alex added "INP-1852" JIRA issue(s) to rINP16842: Fixes INP-1852 - Create the "\kUtil::varDumpColorized" method.
Sun, Aug 31, 11:30 AM
alex committed rINP16842: Fixes INP-1852 - Create the "\kUtil::varDumpColorized" method.
Fixes INP-1852 - Create the "\kUtil::varDumpColorized" method
Sun, Aug 31, 11:30 AM
alex closed D458: INP-1852 - Create the "\kUtil::varDumpColorized" method.
Sun, Aug 31, 11:30 AM · Restricted Project
alex added "INP-1854" JIRA issue(s) to rINP16841: Fixes INP-1854 - Create global switch for Web Request/Session Data logging into….
Sun, Aug 31, 11:07 AM
alex committed rINP16841: Fixes INP-1854 - Create global switch for Web Request/Session Data logging into….
Fixes INP-1854 - Create global switch for Web Request/Session Data logging into…
Sun, Aug 31, 11:07 AM
alex closed D466: INP-1854 - Create global switch for Web Request/Session Data logging into the System Log.
Sun, Aug 31, 11:07 AM

Aug 14 2025

erik accepted D372: INP-1774 - Display scaled down file size in uploader.
Aug 14 2025, 1:36 PM · Restricted Project
alex requested review of D372: INP-1774 - Display scaled down file size in uploader.
Aug 14 2025, 5:36 AM · Restricted Project
alex updated the test plan for D372: INP-1774 - Display scaled down file size in uploader.
Aug 14 2025, 5:36 AM · Restricted Project
alex updated the diff for D372: INP-1774 - Display scaled down file size in uploader.

Fixed the filesize(): stat failed for error when uploading file larger, than 1MB.

Aug 14 2025, 5:26 AM · Restricted Project