Added more tests.

Added unit tests for multi-generator usage.

CS fix: added visibility modifier for the \AbstractSalesReportGenerator::$unitConfigBackup property.

Allow generating several sales reports (even of different type) during one PHP script run.

In D555#11331, @erik wrote:

Notices detected on the E-commerce → Transactions section.

1. Requested ID for prefix affil.log not passed
2. Parent ID not found (prefix: "affil.log"; sub-prefix: "apayments.log")
   
   
   

In D551#11308, @erik wrote:

\ImageHelper::ResizeImage - change "thumb_format" of poll's "Image" field to "resize:200x200;default:core/admin_templates/img/ajax_iframe_progress.gif" and try uploading a large (>200 by width/height) file on the poll editing page in the Admin Console

convertPathToRelative is called to convert each element in the $params array, however only "default" parameter contains file path. There are made excessive convertPathToRelative calls for some parameters (quality, output_format, etc.)

Restored chages in the TemplatesCache class, that were accidentally removed.

Corrected permissions on the system folder itself. Report indirect compiled template removal as part of system setting change.

In D551#11256, @erik wrote:

2. \NParserCompiler::FindTemplateFiles - recompile all templates from the System Tools section - first convertPathToRelative call is with $path = /core/admin_templates parameter, so no comversion happens - incoming path already is relative. However, result is relative path, so test is passed.

Reverted change from array_merge into += during template parser mass-compilation error displaying.

Added color names in comments.

Improve handling of log levels, that doesn't require coloring.

Cosmetic change.

In D546#11169, @erik wrote:

failed parts 1.10, 1.11. (in both clean install and upgrade cases)

after "use the Clear Templates Cache functionality"
system/cache/core/admin_templates folder is present and has drwxr-xr-x permissions, but system/cache/core/admin_templates/config folder is not present, and system/cache/core/admin_templates/config/config_universal.php file is not present.

under system/cache/core/admin_templates folder are present only incs folder and and tools folder

after "Compiled Template Permission Mode" is changed, system/cache/core/admin_templates/tools folder disappears and system/cache/core/admin_templates/config folder is created, so all other test plan checks are passed.

Use "la_fld_LogServerHostname" phrases (existing) instead of "la_fld_ServerHostname" (non-existing) in the Session Log grid.

In D542#11101, @erik wrote:

All by test plan is ok, but missing phrase for "Server Hostname" field (Session log grid column title).

Extracted Arcanist integration into a separate Differential Revision.

Rename test file/class to make Phabricator understand PHPUnit test results/coverage.