Page MenuHomeIn-Portal Phabricator
Feed All Stories

Yesterday

erik requested review of D508: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Tue, Feb 3, 6:01 AM
erik updated the test plan for D508: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Tue, Feb 3, 6:01 AM
erik updated the test plan for D508: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Tue, Feb 3, 6:00 AM
alex requested changes to D508: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
  1. resubmit from the 5.3.x branch, because an associated Jira task is for the 5.3.x branch as well.
Tue, Feb 3, 3:48 AM
alex abandoned D520: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.

Instead of updating D508 this Differential Revision was created. Closing as duplicate.

Tue, Feb 3, 3:47 AM
alex commandeered D520: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Tue, Feb 3, 3:46 AM
alex updated the diff for D508: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.

Resubmitting the same code from the 5.3.x branch.

Tue, Feb 3, 3:45 AM
alex added "INP-1822" JIRA issue(s) to rINP16869: Bug INP-1822 - Use modern cookie encryption library.
Tue, Feb 3, 3:38 AM
alex committed rINP16869: Bug INP-1822 - Use modern cookie encryption library.
Bug INP-1822 - Use modern cookie encryption library
Tue, Feb 3, 3:38 AM

Mon, Feb 2

alex retitled D537: MINC-211 PHP Notice when adding product to discount/affiliate plan from MINC-211 Remove "TitleField" option for the di/coupi/api units to MINC-211 PHP Notice when adding product to discount/affiliate plan.
Mon, Feb 2, 7:33 AM
erik added a comment to D537: MINC-211 PHP Notice when adding product to discount/affiliate plan.

No such notice in the coupi unit. TitleField for coupi unit was not configured.

Mon, Feb 2, 6:28 AM
erik updated the test plan for D537: MINC-211 PHP Notice when adding product to discount/affiliate plan.
Mon, Feb 2, 6:25 AM
erik updated the summary of D537: MINC-211 PHP Notice when adding product to discount/affiliate plan.
Mon, Feb 2, 6:24 AM
erik updated the diff for D537: MINC-211 PHP Notice when adding product to discount/affiliate plan.

Added similar fix for the api unit

Mon, Feb 2, 6:22 AM

Fri, Jan 16

alex added "INP-1933" JIRA issue(s) to rINP16868: Fixes INP-1933 - Report Compiled Template removal errors.
Fri, Jan 16, 3:36 AM
alex committed rINP16868: Fixes INP-1933 - Report Compiled Template removal errors.
Fixes INP-1933 - Report Compiled Template removal errors
Fri, Jan 16, 3:36 AM
alex closed D552: INP-1933 - Report Compiled Template removal errors.
Fri, Jan 16, 3:36 AM
alex updated the diff for D548: MINC-213 - Change architecture of the Sales Report generator.

Allow changing created report structure based on the filters.

Fri, Jan 16, 3:30 AM

Wed, Jan 14

alex abandoned D532: INP-1859 - Escape MySQL 8.3 keywords.

This appears to be a duplicate of the D547.

Wed, Jan 14, 8:24 AM
erik accepted D532: INP-1859 - Escape MySQL 8.3 keywords.
Wed, Jan 14, 5:29 AM

Tue, Jan 13

alex requested review of D532: INP-1859 - Escape MySQL 8.3 keywords.
Tue, Jan 13, 2:07 PM
alex added a comment to D532: INP-1859 - Escape MySQL 8.3 keywords.
In D532#11363, @erik wrote:
  1. missing system/downloads folder, so can't save file for downloadable product
Tue, Jan 13, 2:07 PM
erik requested changes to D532: INP-1859 - Escape MySQL 8.3 keywords.
  1. missing system/downloads folder, so can't save file for downloadable product
  2. on downloadable product creation "Price" field on the "Files & Pricing" tab is not required, but, if this input is missing, SQL error happens when trying buy this product in front-end.

Tue, Jan 13, 4:51 AM

Mon, Jan 12

alex added "INP-1937" JIRA issue(s) to rINP16867: [backported] Fixes INP-1937 - Define INDEX_FILE constant in each CLI script.
Mon, Jan 12, 10:06 AM
alex committed rINP16867: [backported] Fixes INP-1937 - Define INDEX_FILE constant in each CLI script.
[backported] Fixes INP-1937 - Define INDEX_FILE constant in each CLI script
Mon, Jan 12, 10:06 AM
erik accepted D548: MINC-213 - Change architecture of the Sales Report generator.
Mon, Jan 12, 4:32 AM

Thu, Jan 8

alex requested review of D548: MINC-213 - Change architecture of the Sales Report generator.
Thu, Jan 8, 5:04 AM
alex updated the test plan for D548: MINC-213 - Change architecture of the Sales Report generator.
Thu, Jan 8, 5:04 AM
alex updated the diff for D548: MINC-213 - Change architecture of the Sales Report generator.

Added more tests.

Thu, Jan 8, 5:03 AM

Wed, Jan 7

alex updated the diff for D548: MINC-213 - Change architecture of the Sales Report generator.

Added unit tests for multi-generator usage.

Wed, Jan 7, 10:32 AM

Tue, Jan 6

alex updated the diff for D548: MINC-213 - Change architecture of the Sales Report generator.

CS fix: added visibility modifier for the \AbstractSalesReportGenerator::$unitConfigBackup property.

Tue, Jan 6, 5:52 AM
alex updated the diff for D548: MINC-213 - Change architecture of the Sales Report generator.

Allow generating several sales reports (even of different type) during one PHP script run.

Tue, Jan 6, 5:48 AM
alex added "MINC-215" JIRA issue(s) to rMINC16866: Fixes MINC-215 - Repair grid filter in the "E-commerce > Transactions" grid.
Tue, Jan 6, 5:04 AM
alex committed rMINC16866: Fixes MINC-215 - Repair grid filter in the "E-commerce > Transactions" grid.
Fixes MINC-215 - Repair grid filter in the "E-commerce > Transactions" grid
Tue, Jan 6, 5:04 AM
alex closed D555: MINC-215 - Repair grid filter in the "E-commerce > Transactions" grid.
Tue, Jan 6, 5:04 AM
alex committed rINP16865: Fixes INP-1936 - Repair grid filter in the Group Selector popup.
Fixes INP-1936 - Repair grid filter in the Group Selector popup
Tue, Jan 6, 5:03 AM
alex added "INP-1936" JIRA issue(s) to rINP16865: Fixes INP-1936 - Repair grid filter in the Group Selector popup.
Tue, Jan 6, 5:03 AM
alex closed D554: INP-1936 - Repair grid filter in the Group Selector popup.
Tue, Jan 6, 5:03 AM

Dec 30 2025

erik accepted D554: INP-1936 - Repair grid filter in the Group Selector popup.
Dec 30 2025, 9:05 AM
erik accepted D555: MINC-215 - Repair grid filter in the "E-commerce > Transactions" grid.
Dec 30 2025, 8:59 AM
alex requested review of D555: MINC-215 - Repair grid filter in the "E-commerce > Transactions" grid.
Dec 30 2025, 8:55 AM
alex planned changes to D555: MINC-215 - Repair grid filter in the "E-commerce > Transactions" grid.
Dec 30 2025, 8:55 AM
alex added a comment to D555: MINC-215 - Repair grid filter in the "E-commerce > Transactions" grid.
In D555#11331, @erik wrote:

Notices detected on the E-commerce → Transactions section.

  1. Requested ID for prefix affil.log not passed
  2. Parent ID not found (prefix: "affil.log"; sub-prefix: "apayments.log")

Dec 30 2025, 8:55 AM
erik requested changes to D555: MINC-215 - Repair grid filter in the "E-commerce > Transactions" grid.

Notices detected on the E-commerce → Transactions section.

Dec 30 2025, 4:25 AM

Dec 29 2025

alex requested review of D555: MINC-215 - Repair grid filter in the "E-commerce > Transactions" grid.
Dec 29 2025, 8:06 AM
alex updated the test plan for D554: INP-1936 - Repair grid filter in the Group Selector popup.
Dec 29 2025, 8:02 AM
alex requested review of D554: INP-1936 - Repair grid filter in the Group Selector popup.
Dec 29 2025, 7:58 AM

Dec 23 2025

alex added a comment to D551: INP-1932 - Unify code for converting absolute into relative paths.
In D551#11308, @erik wrote:

\ImageHelper::ResizeImage - change "thumb_format" of poll's "Image" field to "resize:200x200;default:core/admin_templates/img/ajax_iframe_progress.gif" and try uploading a large (>200 by width/height) file on the poll editing page in the Admin Console

convertPathToRelative is called to convert each element in the $params array, however only "default" parameter contains file path. There are made excessive convertPathToRelative calls for some parameters (quality, output_format, etc.)

Dec 23 2025, 6:28 AM
erik accepted D553: INP-1934 - Improve template compilation error reportring.
Dec 23 2025, 5:40 AM
erik reopened D551: INP-1932 - Unify code for converting absolute into relative paths.

\ImageHelper::ResizeImage - change "thumb_format" of poll's "Image" field to "resize:200x200;default:core/admin_templates/img/ajax_iframe_progress.gif" and try uploading a large (>200 by width/height) file on the poll editing page in the Admin Console

Dec 23 2025, 5:33 AM
erik accepted D552: INP-1933 - Report Compiled Template removal errors.
Dec 23 2025, 4:14 AM

Dec 22 2025

erik requested changes to D546: INP-1930 - Add Command-Line Template Compilation Support.

After clean install
Part 4.9 - confirm that you'll see an error message above the system settings list indicating which folders weren't deleted as part of the system setting change. - There appears only "Please manually delete paths:" message. No folder names are present in the message.

Dec 22 2025, 4:55 AM

Dec 20 2025

alex added a child revision for D551: INP-1932 - Unify code for converting absolute into relative paths: D553: INP-1934 - Improve template compilation error reportring.
Dec 20 2025, 1:04 PM
alex added a parent revision for D553: INP-1934 - Improve template compilation error reportring: D551: INP-1932 - Unify code for converting absolute into relative paths.
Dec 20 2025, 1:04 PM
alex requested review of D553: INP-1934 - Improve template compilation error reportring.
Dec 20 2025, 1:04 PM
alex requested review of D546: INP-1930 - Add Command-Line Template Compilation Support.
Dec 20 2025, 12:43 PM
alex updated the test plan for D546: INP-1930 - Add Command-Line Template Compilation Support.
Dec 20 2025, 12:43 PM
alex updated the diff for D546: INP-1930 - Add Command-Line Template Compilation Support.

Restored chages in the TemplatesCache class, that were accidentally removed.

Dec 20 2025, 6:19 AM
alex updated the diff for D546: INP-1930 - Add Command-Line Template Compilation Support.

Corrected permissions on the system folder itself. Report indirect compiled template removal as part of system setting change.

Dec 20 2025, 6:17 AM
alex updated the test plan for D546: INP-1930 - Add Command-Line Template Compilation Support.
Dec 20 2025, 6:15 AM
alex updated the test plan for D552: INP-1933 - Report Compiled Template removal errors.
Dec 20 2025, 6:14 AM
alex added a parent revision for D546: INP-1930 - Add Command-Line Template Compilation Support: D552: INP-1933 - Report Compiled Template removal errors.
Dec 20 2025, 6:12 AM
alex added a child revision for D552: INP-1933 - Report Compiled Template removal errors: D546: INP-1930 - Add Command-Line Template Compilation Support.
Dec 20 2025, 6:12 AM
alex added a parent revision for D552: INP-1933 - Report Compiled Template removal errors: D551: INP-1932 - Unify code for converting absolute into relative paths.
Dec 20 2025, 5:53 AM
alex added a child revision for D551: INP-1932 - Unify code for converting absolute into relative paths: D552: INP-1933 - Report Compiled Template removal errors.
Dec 20 2025, 5:53 AM
alex updated the test plan for D552: INP-1933 - Report Compiled Template removal errors.
Dec 20 2025, 5:51 AM
alex requested review of D552: INP-1933 - Report Compiled Template removal errors.
Dec 20 2025, 5:49 AM

Dec 19 2025

alex added "INP-1932" JIRA issue(s) to rINP16864: Fixes INP-1932 - Unify code for converting absolute into relative paths.
Dec 19 2025, 11:27 AM
alex committed rINP16864: Fixes INP-1932 - Unify code for converting absolute into relative paths.
Fixes INP-1932 - Unify code for converting absolute into relative paths
Dec 19 2025, 11:27 AM
alex closed D551: INP-1932 - Unify code for converting absolute into relative paths.
Dec 19 2025, 11:27 AM

Dec 18 2025

alex added a comment to D551: INP-1932 - Unify code for converting absolute into relative paths.
In D551#11256, @erik wrote:
  1. \NParserCompiler::FindTemplateFiles - recompile all templates from the System Tools section - first convertPathToRelative call is with $path = /core/admin_templates parameter, so no comversion happens - incoming path already is relative. However, result is relative path, so test is passed.
Dec 18 2025, 2:44 AM

Dec 17 2025

erik accepted D551: INP-1932 - Unify code for converting absolute into relative paths.
  1. \NParserCompiler::FindTemplateFiles - recompile all templates from the System Tools section - first convertPathToRelative call is with $path = /core/admin_templates parameter, so no comversion happens - incoming path already is relative. However, result is relative path, so test is passed.
Dec 17 2025, 8:36 AM
alex updated the diff for D551: INP-1932 - Unify code for converting absolute into relative paths.

Reverted change from array_merge into += during template parser mass-compilation error displaying.

Dec 17 2025, 4:37 AM
alex requested review of D551: INP-1932 - Unify code for converting absolute into relative paths.
Dec 17 2025, 3:01 AM
alex updated the diff for D550: INP-1931 - Color Log Level names in the System Log.

Added color names in comments.

Dec 17 2025, 2:24 AM

Dec 16 2025

erik accepted D550: INP-1931 - Color Log Level names in the System Log.
Dec 16 2025, 1:02 PM
alex updated the test plan for D550: INP-1931 - Color Log Level names in the System Log.
Dec 16 2025, 12:46 PM
alex updated the diff for D550: INP-1931 - Color Log Level names in the System Log.

Improve handling of log levels, that doesn't require coloring.

Dec 16 2025, 12:43 PM
erik accepted D550: INP-1931 - Color Log Level names in the System Log.

All task-defined coloring is right.

Dec 16 2025, 8:24 AM
alex requested review of D550: INP-1931 - Color Log Level names in the System Log.
Dec 16 2025, 6:17 AM

Dec 11 2025

alex updated the test plan for D549: MINC-214 - Unify total calculation for Sale Reports.
Dec 11 2025, 6:34 AM
erik added a comment to D549: MINC-214 - Unify total calculation for Sale Reports.

"use the above-created user and products (several with different quantities)"

Dec 11 2025, 4:57 AM
erik accepted D549: MINC-214 - Unify total calculation for Sale Reports.
Dec 11 2025, 4:56 AM
alex updated the diff for D549: MINC-214 - Unify total calculation for Sale Reports.

Cosmetic change.

Dec 11 2025, 4:42 AM
erik accepted D548: MINC-213 - Change architecture of the Sales Report generator.
Dec 11 2025, 4:32 AM
alex updated the test plan for D549: MINC-214 - Unify total calculation for Sale Reports.
Dec 11 2025, 4:10 AM
alex requested review of D549: MINC-214 - Unify total calculation for Sale Reports.
Dec 11 2025, 4:09 AM

Dec 10 2025

alex updated the test plan for D548: MINC-213 - Change architecture of the Sales Report generator.
Dec 10 2025, 12:37 PM
alex updated the test plan for D548: MINC-213 - Change architecture of the Sales Report generator.
Dec 10 2025, 12:37 PM
alex requested review of D548: MINC-213 - Change architecture of the Sales Report generator.
Dec 10 2025, 12:35 PM
alex added "INP-1859" JIRA issue(s) to rMINC16863: Bug INP-1859 - Escape MySQL 8.3 keywords.
Dec 10 2025, 3:12 AM
alex committed rMINC16863: Bug INP-1859 - Escape MySQL 8.3 keywords.
Bug INP-1859 - Escape MySQL 8.3 keywords
Dec 10 2025, 3:12 AM
alex closed D547: INP-1859 - Escape MySQL 8.3 keywords.
Dec 10 2025, 3:12 AM

Dec 9 2025

erik accepted D547: INP-1859 - Escape MySQL 8.3 keywords.

Without this change - also no SQL error. Maybe, because no MySQL 8.x in the test system.

Dec 9 2025, 10:20 AM
alex updated the test plan for D547: INP-1859 - Escape MySQL 8.3 keywords.
Dec 9 2025, 9:56 AM
alex requested review of D547: INP-1859 - Escape MySQL 8.3 keywords.
Dec 9 2025, 9:54 AM

Nov 25 2025

erik accepted D546: INP-1930 - Add Command-Line Template Compilation Support.
Nov 25 2025, 11:26 AM
alex requested review of D546: INP-1930 - Add Command-Line Template Compilation Support.
In D546#11169, @erik wrote:

failed parts 1.10, 1.11. (in both clean install and upgrade cases)

after "use the Clear Templates Cache functionality"
system/cache/core/admin_templates folder is present and has drwxr-xr-x permissions, but system/cache/core/admin_templates/config folder is not present, and system/cache/core/admin_templates/config/config_universal.php file is not present.

under system/cache/core/admin_templates folder are present only incs folder and and tools folder

after "Compiled Template Permission Mode" is changed, system/cache/core/admin_templates/tools folder disappears and system/cache/core/admin_templates/config folder is created, so all other test plan checks are passed.

Nov 25 2025, 10:53 AM
alex updated the test plan for D546: INP-1930 - Add Command-Line Template Compilation Support.
Nov 25 2025, 10:52 AM
erik requested changes to D546: INP-1930 - Add Command-Line Template Compilation Support.

failed parts 1.10, 1.11. (in both clean install and upgrade cases)

Nov 25 2025, 10:19 AM