Page MenuHomeIn-Portal Phabricator

erik (Erik Snarski [Intechnic])
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 25 2014, 9:29 AM (136 mo, 3 w)

Recent Activity

Yesterday

erik accepted D516: INP-1905 - Clear the "Temp Mode" flag after the Temp Table removal from the "OnCancelEdit" event.
Tue, Mar 25, 7:57 AM

Thu, Mar 13

erik accepted D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Thu, Mar 13, 12:59 PM
erik accepted D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Thu, Mar 13, 11:48 AM
erik requested changes to D513: INP-1904 - Support opening an Admin Console from a Site Domain.

Part 3.1.1 login to the Admin Console by accessing it on the sd1.test.domain.com domain over http:// protocol - FAILED, after login attempt - redirect to the login page. SUCCESS after cookies deleted (beyond test plan)
Part 3.1.12 confirm, that orange buttons for editing page/content blocks are now shown - NOT STABLE. At first attempt - no orange buttons. Then I logged in from main domain, set Default theme as primary theme, checked that orange buttons shown, restored Advanced theme as primary theme, then tried again login to sd1 domain, failed, cleared cookies, login to sd1 admin - and only then orange buttons shown

Thu, Mar 13, 6:14 AM

Wed, Mar 12

erik requested changes to D513: INP-1904 - Support opening an Admin Console from a Site Domain.

Part 3.1.7 confirm that [SD ID: 1] is added in the current page blur bar (the 1 is site domain ID) - NO, [SD ID: ] is added. And this is right, because at Preparations 10 "add 1st site domain with: Domain Name=sd1-http.test.domain.com", not sd1.test.domain.com
Part 3.1.9 confirm, that you'll see [Site Domain ID: 1] text (the 1 is site domain ID) - NO I see [Site Domain ID: 0]
Part 3.1.12 logout - FAILED, infinite redirect to http://sd1.test.domain.com/SVN/5.3.x/admin/index.php?env=-index%3Am0--default---&expired=1 happens
Part 3.2.2 confirm that you're looking at Admin Console at the test.domain.com domain over https:// protocol - NO, I'm looking at Admin Console at the sd1.test.domain.com domain over https:// protocol
Part 3.2.3 confirm that [SD ID: 1] is added in the current page blur bar (the 1 is site domain ID) = NO, [SD ID: ] is added in the current page blue bar
Part 3.2.5 confirm, that you'll see [Site Domain ID: 1] text (the 1 is site domain ID) - NO I see [Site Domain ID: 0]
Part 4.2 confirm, that you'll see [Site Domain ID: 1] text (the 1 is site domain ID) - NO I see [Site Domain ID: 0]
Part 4.4 confirm, that you'll see [Site Domain ID: 1] text (the 1 is site domain ID) - NO I see [Site Domain ID: 0]

Wed, Mar 12, 10:04 AM
erik requested changes to D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.

Part 3.2 go to the Configuration → Website → Advanced section - FAILED, can't. login, redirects to login screen. Logged in only after all current site cookies deleted before login.
Part 7.9 confirm, that domain/protocol combo is allowed - NO The "https://front-https.test.domain.com" protocol/domain combo is not allowed.
Part 10.2 login - FAILED, can't. login, redirects to login screen. Logged in only after all current site cookies deleted before login.

Wed, Mar 12, 7:48 AM

Mon, Mar 10

erik updated the test plan for D512: INP-1902 Populate the "SessionCookieDomains" system setting upon installationI.
Mon, Mar 10, 10:16 AM
erik requested review of D512: INP-1902 Populate the "SessionCookieDomains" system setting upon installationI.
Mon, Mar 10, 10:14 AM
erik accepted D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mon, Mar 10, 6:38 AM

Thu, Mar 6

erik requested changes to D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.

All tested, there is list of possible differences from test plan expectations.

Thu, Mar 6, 6:27 AM

Feb 10 2025

erik updated the test plan for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Feb 10 2025, 4:58 AM
erik requested review of D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Feb 10 2025, 4:55 AM

Feb 5 2025

erik updated the test plan for D508: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Feb 5 2025, 5:02 AM
erik updated the test plan for D508: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Feb 5 2025, 5:00 AM
erik updated the test plan for D508: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Feb 5 2025, 4:59 AM
erik requested review of D508: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Feb 5 2025, 4:58 AM
erik updated the test plan for D507: INP-1899 Preserve original formatting of multi-line error messages/exceptions in Debugger.
Feb 5 2025, 4:43 AM
erik updated the test plan for D507: INP-1899 Preserve original formatting of multi-line error messages/exceptions in Debugger.
Feb 5 2025, 4:42 AM
erik requested review of D507: INP-1899 Preserve original formatting of multi-line error messages/exceptions in Debugger.
Feb 5 2025, 4:40 AM

Jan 29 2025

erik updated the test plan for D506: INP-1895 Ensure consistent return type of the "kTempTablesHandler::CloneItems" method.
Jan 29 2025, 10:28 AM
erik updated the test plan for D506: INP-1895 Ensure consistent return type of the "kTempTablesHandler::CloneItems" method.
Jan 29 2025, 10:26 AM
erik requested review of D506: INP-1895 Ensure consistent return type of the "kTempTablesHandler::CloneItems" method.
Jan 29 2025, 10:24 AM

Jan 28 2025

erik accepted D504: INP-1894 - Extract "Change Log" code to a central place.
Jan 28 2025, 8:55 AM

Jan 23 2025

erik updated the diff for D503: INP-1893 Denormalize "ChangeLogs" database table.

Done all requested minor fixes

Jan 23 2025, 10:45 AM
erik added inline comments to D503: INP-1893 Denormalize "ChangeLogs" database table.
Jan 23 2025, 9:27 AM
erik updated the diff for D503: INP-1893 Denormalize "ChangeLogs" database table.

Done all requested improvements

Jan 23 2025, 5:19 AM
erik added inline comments to D503: INP-1893 Denormalize "ChangeLogs" database table.
Jan 23 2025, 4:54 AM

Jan 22 2025

erik updated the test plan for D503: INP-1893 Denormalize "ChangeLogs" database table.
Jan 22 2025, 12:21 PM
erik requested review of D503: INP-1893 Denormalize "ChangeLogs" database table.
Jan 22 2025, 12:20 PM

Dec 23 2024

erik accepted D502: INP-1891 - Display PHP errors in the Phing build log.
Dec 23 2024, 6:04 AM

Dec 19 2024

erik added a comment to D500: INP-1889 - Don't use DB Load Balancer during PHPUnit Testing.

Error fixed after svn update and clear memory cache.

Dec 19 2024, 12:48 PM
erik accepted D500: INP-1889 - Don't use DB Load Balancer during PHPUnit Testing.
Dec 19 2024, 12:42 PM
erik added a comment to D501: INP-1890 - Force "\kApplication::NextResourceId" method to use master database connection.

Yes, when restarting before open index.php, then all is ok - no delay after patch applied

Dec 19 2024, 12:01 PM
erik accepted D491: INP-1880 - Fix notice on missing event permission mapping.
Dec 19 2024, 11:51 AM · Restricted Project
erik accepted D498: INP-1887 - Don't define the "EDITING_MODE" constant in the Installation Wizard.
Dec 19 2024, 11:34 AM
erik accepted D499: INP-1888 - Detect Memcache availability during installation using Memcache/Memcached PHP modules.
Dec 19 2024, 11:24 AM
erik requested changes to D500: INP-1889 - Don't use DB Load Balancer during PHPUnit Testing.

There happens error, due to this line in the AbstractBrowserTestCase.php

Dec 19 2024, 10:52 AM
erik accepted D501: INP-1890 - Force "\kApplication::NextResourceId" method to use master database connection.

Tests passed, but first time after patch applied need wait long time (2-3 minutes) to get ID shown. Next page refreshes becomes fast (~1 sec).

Dec 19 2024, 10:25 AM

Dec 10 2024

erik accepted D497: INP-1886 - Add value-clearing support for "kDateFormatter::UpdateSubFields" method.

All tests passed.

Dec 10 2024, 10:55 AM · Restricted Project

Nov 29 2024

erik accepted D494: INP-1863 - Correct PHPUnit integration.

All tested, All formal checks passed. But all builds, that has call to selenium - failed with message like.

Nov 29 2024, 4:36 AM

Nov 27 2024

erik requested changes to D494: INP-1863 - Correct PHPUnit integration.

Same way failed all builds until part 5.7 tests continued, because all formal requirements passed.

Nov 27 2024, 5:45 AM
erik added a comment to D494: INP-1863 - Correct PHPUnit integration.

Failed build at part 4 after command

phing -f tools/build/build_all.xml phpunit
Nov 27 2024, 5:11 AM

Nov 25 2024

erik added a comment to D494: INP-1863 - Correct PHPUnit integration.

Partialy tested, build failed after "run the phing -f tools/build/build_all.xml phpunit command" in the part 4 of test plan

Nov 25 2024, 5:34 AM

Nov 22 2024

erik accepted D495: INP-1884 - Actualize "/system/config.php" created during the build.

accepted, detected difference fixed in new patch version

Nov 22 2024, 4:51 AM
erik requested changes to D495: INP-1884 - Actualize "/system/config.php" created during the build.

All passed, excepting last part - config.php comparision.

Nov 22 2024, 4:40 AM

Nov 21 2024

erik accepted D496: INP-1885 - Consistently use PHP binary during the Build.
Nov 21 2024, 5:20 AM
erik requested changes to D496: INP-1885 - Consistently use PHP binary during the Build.

2 B part ir the test plan is failed. Build was not successful -

Nov 21 2024, 4:16 AM

Nov 20 2024

erik requested changes to D495: INP-1884 - Actualize "/system/config.php" created during the build.

Not passed 3 E a part of the plan. Made run of php74 which phing` -f tools/build/build_all.xml build` command.
Command finished with fatal error.

Nov 20 2024, 5:36 AM
erik added a comment to D495: INP-1884 - Actualize "/system/config.php" created during the build.

Error on Clean install without applying patch

Nov 20 2024, 4:51 AM

Nov 12 2024

erik added a comment to D494: INP-1863 - Correct PHPUnit integration.

tested, each test command, containing build_all.xml or build_custom.xml leads to config.php change where HMAC key containing variable ($_CONFIG['Misc']['SecurityHmacKey']) disappears, and then build failed due [InvalidArgumentException] "The HMAC key is empty."

Nov 12 2024, 10:21 AM
erik added a comment to D494: INP-1863 - Correct PHPUnit integration.

Can't test because of different php version on VM.

Nov 12 2024, 4:36 AM

Nov 11 2024

erik added a comment to D494: INP-1863 - Correct PHPUnit integration.

No, build was not successful.

Nov 11 2024, 8:50 AM
erik added a comment to D494: INP-1863 - Correct PHPUnit integration.

Partially tested, tests from part 4 like "confirm, by looking at the colorized output of the above command, that phpunit target was called" - failed. No PHPunit output generated.

Nov 11 2024, 8:42 AM

Oct 30 2024

erik accepted D493: INP-1881 - Change default Debugger URL handler to PhpStorm.
Oct 30 2024, 6:02 AM

Oct 28 2024

erik accepted D492: INP-1882 - Rework URL-encoding in Debugger Report file URLs.
Oct 28 2024, 9:17 AM
erik requested changes to D492: INP-1882 - Rework URL-encoding in Debugger Report file URLs.

Part 1 - microsoft do not support such links as 'file://' (security issue), so browser does not decode it properly. Result is like "file:///" in the FireFox browser. {F669820}And like 'about:blank#blocked' when trying follow this link in the Chrome browser.

Oct 28 2024, 7:08 AM
erik accepted D480: INP-1872 - Properly handle constant absence during category cache rebuild.

All right, when debugger is off. When debugger os on - got about 20 "Trying to access array offset on value of type bool" notices

Oct 28 2024, 5:20 AM · Restricted Project

Oct 16 2024

erik accepted D490: INP-1879 - Adjust Phabricator URL to use SSL.
Oct 16 2024, 12:30 PM
erik accepted D489: INP-1878 - Add support for the WEBP format.
Oct 16 2024, 8:05 AM · Restricted Project

Oct 15 2024

erik accepted D487: INP-1877 - Check meta-permissions for "root" user.
Oct 15 2024, 10:54 AM

Oct 8 2024

erik accepted D487: INP-1877 - Check meta-permissions for "root" user.
Oct 8 2024, 10:37 AM
erik requested changes to D487: INP-1877 - Check meta-permissions for "root" user.

Not passed test plan part

Oct 8 2024, 10:06 AM

Oct 3 2024

erik accepted D486: INP-1876 - Verify system settings access permissions before allowing to change them.
Oct 3 2024, 11:21 AM · Restricted Project
erik accepted D486: INP-1876 - Verify system settings access permissions before allowing to change them.

Test by plan is passed, but, to have Groups section visible, with root user go to Configuration->Users-General section, press Save button - and got "Exception: Permission section not specified for prefix conf in w:\SVN\5.2.x\core\kernel\utility\event.php on line 439"

Oct 3 2024, 9:53 AM · Restricted Project

Aug 5 2024

erik accepted D481: INP-1873 - Support MySQL 8 database collations.
Aug 5 2024, 9:38 AM · Restricted Project
erik requested changes to D480: INP-1872 - Properly handle constant absence during category cache rebuild.

System log errors exists, but, seems, not related to the current patch. Equal errors count with patch and without patch.

Aug 5 2024, 9:12 AM · Restricted Project

Jul 31 2024

erik accepted D478: INP-1756 - Create "Security*" classes for security-related jobs.
Jul 31 2024, 6:40 AM · Restricted Project

Jul 29 2024

erik accepted D477: INP-1871 - Properly dispose session during logout workflow.

Tested by using PHPStorm+XDebug with breakpoint in the SessionStorage::RemoveFromData method. Before patch applying SQL, that removes the priority_deleted session variable was executed. After patch applying SQL, that removes the priority_deleted session variable was not executed, because SessionSet property is set to false.

Jul 29 2024, 9:43 AM
erik accepted D476: INP-1870 - Save the session to the database immediately after the user login.
Jul 29 2024, 5:36 AM

Jul 25 2024

erik accepted D475: INP-1869 - Add vendor autoloader support for Class Locator.
Jul 25 2024, 6:44 AM

Jul 5 2024

erik requested review of D474: MINC-202 - Fix currency selection in Site Domain scenario.
Jul 5 2024, 6:14 AM
erik updated the test plan for D474: MINC-202 - Fix currency selection in Site Domain scenario.
Jul 5 2024, 6:13 AM
erik updated the test plan for D474: MINC-202 - Fix currency selection in Site Domain scenario.
Jul 5 2024, 6:12 AM

Jul 4 2024

erik requested review of D474: MINC-202 - Fix currency selection in Site Domain scenario.
Jul 4 2024, 11:16 AM

Jun 21 2024

erik accepted D473: INP-1867 - Remove the MySQL password warning from Phing DB dumps.

No words "mysqldump", "Warning" in the resulting files.

Jun 21 2024, 5:21 AM

Jun 17 2024

erik accepted D470: INP-1866 - Verify SSL certificate on cURL connections.
Jun 17 2024, 11:03 AM
erik requested review of D472: INP-1865 Use cryptographically safe session key generator.
Jun 17 2024, 9:14 AM
erik requested review of D471: INP-1864 Require Username on the Login Form.
Jun 17 2024, 7:42 AM
erik requested changes to D470: INP-1866 - Verify SSL certificate on cURL connections.

Last line from test result is: "Test 5 (correct custom cert failure): Failed"
Not match with defined in test plan "Test 5 (correct custom cert failure): Passed"

Jun 17 2024, 7:10 AM

Jun 3 2024

erik accepted D467: INP-1860 - Remove HTML from "Site_Name" system setting result based on usage place.
Jun 3 2024, 11:15 AM

May 31 2024

erik accepted D469: INP-1861 - Cache results of the PHP_CodeSniffer & PHP_MessDetector.

all right, test times:

May 31 2024, 7:13 AM · Restricted Project
erik accepted D469: INP-1861 - Cache results of the PHP_CodeSniffer & PHP_MessDetector.
May 31 2024, 5:34 AM · Restricted Project

May 30 2024

erik requested changes to D467: INP-1860 - Remove HTML from "Site_Name" system setting result based on usage place.

All right in general, but

May 30 2024, 12:06 PM
erik requested changes to D469: INP-1861 - Cache results of the PHP_CodeSniffer & PHP_MessDetector.

Time reports for all 8 tests

May 30 2024, 11:33 AM · Restricted Project
erik accepted D468: INP-1862 - Execute "lint" prior to deploy during the build.
May 30 2024, 10:35 AM · Restricted Project

Jan 24 2024

erik accepted D466: INP-1854 - Create global switch for Web Request/Session Data logging into the System Log.

All works right, only test plan must be corrected.

Jan 24 2024, 8:43 AM
erik accepted D464: INP-1859 - Escape MySQL 8.3 keywords.

Can't test with correct MySQL version, but visually code looks good and works good with current MySQL version.

Jan 24 2024, 5:01 AM · Restricted Project

Jan 22 2024

erik accepted D461: INP-1855 - Support for window scrolling offset in the "Form" JS class.
Jan 22 2024, 10:33 AM · Restricted Project
erik accepted D462: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
Jan 22 2024, 10:23 AM · Restricted Project

Jan 16 2024

erik requested changes to D460: INP-1840 - Reset form scroll prior to window resizing handling (bugfix).

In the chrome browser, after reload frame. window is not scrolled. In the firefox browser this auto-scrolling works good.

Jan 16 2024, 9:08 AM · Restricted Project

Jan 15 2024

erik accepted D459: INP-1853 - Use the "\kUtil::varDumpColorized" method in the System Log Web UI.
Jan 15 2024, 6:58 AM
erik accepted D458: INP-1852 - Create the "\kUtil::varDumpColorized" method.
Jan 15 2024, 6:32 AM · Restricted Project
erik requested changes to D458: INP-1852 - Create the "\kUtil::varDumpColorized" method.

Not working as expected in test plan. No result_number key detected.

Jan 15 2024, 6:19 AM · Restricted Project
erik accepted D457: INP-1851 - Log file upload meta-information as part of the Request Data.
Jan 15 2024, 4:31 AM · Restricted Project

Jan 11 2024

erik accepted D456: INP-1850 - Repair the "kHTTPQuery::getHeaders" method.
Jan 11 2024, 4:07 AM · Restricted Project

Jan 10 2024

erik added a comment to D456: INP-1850 - Repair the "kHTTPQuery::getHeaders" method.

Can't test - local system has apache_request_headers function and test array looks good without patch.

Jan 10 2024, 4:41 AM · Restricted Project

Jan 2 2024

erik added a comment to D453: INP-1847 - Specify image resizing defaults for category item images.

After in-portal update, test plan works well only after patch applying.

Jan 2 2024, 5:33 AM
erik accepted D453: INP-1847 - Specify image resizing defaults for category item images.

Test plan works well also without applying this patch.

Jan 2 2024, 5:02 AM

Dec 13 2023

erik requested review of D13: INP-1383 - Don't translate phrase from "empty_label" parameter of "PedefinedOptions" tag twice.

Written requested test plan

Dec 13 2023, 4:08 AM

Nov 27 2023

erik updated the test plan for D13: INP-1383 - Don't translate phrase from "empty_label" parameter of "PedefinedOptions" tag twice.
Nov 27 2023, 5:21 AM